All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Branden Bonaby <brandonbonaby94@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] staging: wlan-ng: line over 80 character limit
Date: Sun, 17 Mar 2019 11:45:50 +0100	[thread overview]
Message-ID: <20190317104550.GC16257@kroah.com> (raw)
In-Reply-To: <20190314201651.28111-1-brandonbonaby94@gmail.com>

On Thu, Mar 14, 2019 at 04:16:51PM -0400, Branden Bonaby wrote:
> Align macros and function to prevent them from going over
> the 80 character a line limit for readability. There should
> not be tabspace between #define and the name.
> WARNING: line over 80 characters

That is a lot of different things happening in the same patch.  This
should be probably just 2 patches, one for the macro alignment and one
for the function prototype changing.

thanks,

greg k-h


  reply	other threads:[~2019-03-17 10:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 21:48 [PATCH] staging: wlan-ng: line over 80 character limit Branden Bonaby
2019-03-13 22:09 ` [Outreachy kernel] " Julia Lawall
2019-03-14 20:16 ` [PATCH v2] " Branden Bonaby
2019-03-17 10:45   ` Greg KH [this message]
2019-03-18 17:14 ` [PATCH v3 0/2] staging: wlan-ng: realign function and macros Branden Bonaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190317104550.GC16257@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=brandonbonaby94@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.