Re: [PATCH 7/7] Staging: rtl8723bs: Add missing NULL check for kmalloc

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Mar 16, 2019 at 07:32:24PM -0500, Madhumitha Prabakaran wrote:
> Include missing NULL check for kmalloc in function rtw_init_evt_priv.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 2890e12f6fb1..4ea6483f4634 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -213,6 +213,8 @@ int rtw_init_evt_priv(struct evt_priv *pevtpriv)
>  	pevtpriv->c2h_wk_alive = false;
>  	pevtpriv->c2h_queue = rtw_cbuf_alloc(C2H_QUEUE_MAX_LEN+1);
>  
> +	if (!pevtpriv->c2h_queue)
> +		return -ENOMEM;
>  	return res;

This is good, but if you notice, there is no need for 'res' in this
function at all, you can just return 0 for it, right?

So in the earlier patches in this series, you could just drop the local
variable completly, making this a bit simpler to do.

thanks,

greg k-h