From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Emanuel Bennici <benniciemanuel78@gmail.com>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Eric Anholt <eric@anholt.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration
Date: Sun, 17 Mar 2019 13:38:23 +0100 [thread overview]
Message-ID: <20190317123823.GA9496@kroah.com> (raw)
In-Reply-To: <e62c9952-190b-d232-4987-5e1a05e16a57@gmail.com>
On Sun, Mar 17, 2019 at 01:14:26PM +0100, Emanuel Bennici wrote:
>
> Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:
> > On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
> >> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> >> ---
> >> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> >> 1 file changed, 1 insertion(+)
> > I can not take patches without any changelog information, sorry.
>
> Add blank Line after declaration of struct vchi_version to fix checkpatch.pl
> Check `CHECK: Please use a blank line after function/struct/union/enum
> declarations`.
>
> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> 1 file changed, 1 insertion(+)
>
<snip>
Sorry, I can't take a patch that I have to hand-edit either.
Please fix up and resend the series correctly, with a proper version
information about what changed from the previous patch series as the
kernel process documentation explains.
thanks,
greg k-h
prev parent reply other threads:[~2019-03-17 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 1:59 [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration Emanuel Bennici
2019-03-17 9:55 ` Greg Kroah-Hartman
2019-03-17 12:14 ` Emanuel Bennici
2019-03-17 12:38 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317123823.GA9496@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benniciemanuel78@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.