From: Greg KH <gregkh@linuxfoundation.org>
To: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] [Outreachy kernel]staging: greybus: dt compatible string "google,arche-platform" documented
Date: Sun, 17 Mar 2019 16:32:10 +0100 [thread overview]
Message-ID: <20190317153210.GD25814@kroah.com> (raw)
In-Reply-To: <1552833963-14600-1-git-send-email-payal.s.kshirsagar.98@gmail.com>
On Sun, Mar 17, 2019 at 08:16:03PM +0530, Payal Kshirsagar wrote:
> DT compatible string ‘{ .compatible = "google,arche-platform", }’
> appears in drivers/staging/greybus/arche-platform.c file at line no. 624
> and 630 documented in file named as
> ./Documentation/devicetree/bindings/vendor-prefixes.txt
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 62f0b03..110028b 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -157,6 +157,7 @@ globalscale Globalscale Technologies, Inc.
> globaltop GlobalTop Technology, Inc.
> gmt Global Mixed-mode Technology, Inc.
> goodix Shenzhen Huiding Technology Co., Ltd.
> +google,arche-platform
> google Google, Inc.
No this is not correct at all.
Please read up on what device tree strings are and how they work if you
wish to fix up stuff like this.
Blindly trying to make checkpatch.pl not complain about things is not
good.
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-17 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 14:46 [PATCH] [Outreachy kernel]staging: greybus: dt compatible string "google,arche-platform" documented Payal Kshirsagar
2019-03-17 15:32 ` Greg KH [this message]
2019-03-17 15:56 ` Payal Kshirsagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317153210.GD25814@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=payal.s.kshirsagar.98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.