All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [Outreachy kernel]staging: greybus: dt compatible string "google,arche-platform" documented
@ 2019-03-17 14:46 Payal Kshirsagar
  2019-03-17 15:32 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Payal Kshirsagar @ 2019-03-17 14:46 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

DT compatible string ‘{ .compatible = "google,arche-platform", }’
appears in drivers/staging/greybus/arche-platform.c file at line no. 624
and 630 documented in file named as
./Documentation/devicetree/bindings/vendor-prefixes.txt

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 62f0b03..110028b 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -157,6 +157,7 @@ globalscale	Globalscale Technologies, Inc.
 globaltop	GlobalTop Technology, Inc.
 gmt	Global Mixed-mode Technology, Inc.
 goodix	Shenzhen Huiding Technology Co., Ltd.
+google,arche-platform
 google	Google, Inc.
 grinn	Grinn
 grmn	Garmin Limited
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] [Outreachy kernel]staging: greybus: dt compatible string "google,arche-platform" documented
  2019-03-17 14:46 [PATCH] [Outreachy kernel]staging: greybus: dt compatible string "google,arche-platform" documented Payal Kshirsagar
@ 2019-03-17 15:32 ` Greg KH
  2019-03-17 15:56   ` Payal Kshirsagar
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-03-17 15:32 UTC (permalink / raw)
  To: Payal Kshirsagar; +Cc: outreachy-kernel

On Sun, Mar 17, 2019 at 08:16:03PM +0530, Payal Kshirsagar wrote:
> DT compatible string ‘{ .compatible = "google,arche-platform", }’
> appears in drivers/staging/greybus/arche-platform.c file at line no. 624
> and 630 documented in file named as
> ./Documentation/devicetree/bindings/vendor-prefixes.txt
> 
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 62f0b03..110028b 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -157,6 +157,7 @@ globalscale	Globalscale Technologies, Inc.
>  globaltop	GlobalTop Technology, Inc.
>  gmt	Global Mixed-mode Technology, Inc.
>  goodix	Shenzhen Huiding Technology Co., Ltd.
> +google,arche-platform
>  google	Google, Inc.

No this is not correct at all.

Please read up on what device tree strings are and how they work if you
wish to fix up stuff like this.

Blindly trying to make checkpatch.pl not complain about things is not
good.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [Outreachy kernel]staging: greybus: dt compatible string "google,arche-platform" documented
  2019-03-17 15:32 ` Greg KH
@ 2019-03-17 15:56   ` Payal Kshirsagar
  0 siblings, 0 replies; 3+ messages in thread
From: Payal Kshirsagar @ 2019-03-17 15:56 UTC (permalink / raw)
  To: Greg KH; +Cc: outreachy-kernel

[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]

Okay .

Payal

On Sun, Mar 17, 2019, 9:02 PM Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sun, Mar 17, 2019 at 08:16:03PM +0530, Payal Kshirsagar wrote:
> > DT compatible string ‘{ .compatible = "google,arche-platform", }’
> > appears in drivers/staging/greybus/arche-platform.c file at line no. 624
> > and 630 documented in file named as
> > ./Documentation/devicetree/bindings/vendor-prefixes.txt
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > index 62f0b03..110028b 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > @@ -157,6 +157,7 @@ globalscale       Globalscale Technologies, Inc.
> >  globaltop    GlobalTop Technology, Inc.
> >  gmt  Global Mixed-mode Technology, Inc.
> >  goodix       Shenzhen Huiding Technology Co., Ltd.
> > +google,arche-platform
> >  google       Google, Inc.
>
> No this is not correct at all.
>
> Please read up on what device tree strings are and how they work if you
> wish to fix up stuff like this.
>
> Blindly trying to make checkpatch.pl not complain about things is not
> good.
>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 2134 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-17 15:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-17 14:46 [PATCH] [Outreachy kernel]staging: greybus: dt compatible string "google,arche-platform" documented Payal Kshirsagar
2019-03-17 15:32 ` Greg KH
2019-03-17 15:56   ` Payal Kshirsagar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.