Re: [Outreachy kernel] [PATCH v2 2/5] Staging: rtl8723bs: Change type of variables and return type

[Madhumthia Prabakaran <madhumithabiw@gmail.com>]

On Sun, Mar 17, 2019 at 10:52:35PM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 17 Mar 2019, Madhumitha Prabakaran wrote:
> 
> > Change type of local variables 'res' and return type of functions
> > 'rtw_init_cmd_pri' and 'rtw_init_evt_priv', as function's
> > return types are defined for standard error codes _SUCCESS and _FAIL.
> 
> I'm not sure to undestand the reference to _SUCCESS and _FAIL.  sint is a
> typedef for signed int, but kernel code typically uses just int rather
> than signed int.  In any case, the change doesn't have any impact on the
> types in the code.

That's true. Should I drop this patch?

thanks

> 
> julia
> 
> > Also, change return type of functions declarations corresponding to
> > change made in function definitions.
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_cmd.c      | 8 ++++----
> >  drivers/staging/rtl8723bs/include/cmd_osdep.h | 4 ++--
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > index 793bc505fa9c..ab450f717f34 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > @@ -162,9 +162,9 @@ Caller and the rtw_cmd_thread can protect cmd_q by spin_lock.
> >  No irqsave is necessary.
> >  */
> >
> > -sint rtw_init_cmd_priv(struct	cmd_priv *pcmdpriv)
> > +int rtw_init_cmd_priv(struct	cmd_priv *pcmdpriv)
> >  {
> > -	sint res = _SUCCESS;
> > +	int res = _SUCCESS;
> >
> >  	init_completion(&pcmdpriv->cmd_queue_comp);
> >  	init_completion(&pcmdpriv->terminate_cmdthread_comp);
> > @@ -201,9 +201,9 @@ sint rtw_init_cmd_priv(struct	cmd_priv *pcmdpriv)
> >  }
> >
> >  static void c2h_wk_callback(_workitem *work);
> > -sint rtw_init_evt_priv(struct evt_priv *pevtpriv)
> > +int rtw_init_evt_priv(struct evt_priv *pevtpriv)
> >  {
> > -	sint res = _SUCCESS;
> > +	int res = _SUCCESS;
> >
> >  	/* allocate DMA-able/Non-Page memory for cmd_buf and rsp_buf */
> >  	atomic_set(&pevtpriv->event_seq, 0);
> > diff --git a/drivers/staging/rtl8723bs/include/cmd_osdep.h b/drivers/staging/rtl8723bs/include/cmd_osdep.h
> > index 8ed913726d5a..06ab48263757 100644
> > --- a/drivers/staging/rtl8723bs/include/cmd_osdep.h
> > +++ b/drivers/staging/rtl8723bs/include/cmd_osdep.h
> > @@ -8,8 +8,8 @@
> >  #define __CMD_OSDEP_H_
> >
> >
> > -sint rtw_init_cmd_priv(struct	cmd_priv *pcmdpriv);
> > -sint rtw_init_evt_priv(struct evt_priv *pevtpriv);
> > +int rtw_init_cmd_priv(struct	cmd_priv *pcmdpriv);
> > +int rtw_init_evt_priv(struct evt_priv *pevtpriv);
> >  extern void _rtw_free_evt_priv (struct	evt_priv *pevtpriv);
> >  extern void _rtw_free_cmd_priv (struct	cmd_priv *pcmdpriv);
> >  extern sint _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj);
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cce081516153acd64194786cb1373150172d73cf.1552858206.git.madhumithabiw%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903172250420.2434%40hadrien.
> For more options, visit https://groups.google.com/d/optout.