From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B510C10F06 for ; Mon, 18 Mar 2019 08:11:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65C742087C for ; Mon, 18 Mar 2019 08:11:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="gFEpjJhn"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="E7jXR3hz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726678AbfCRILd (ORCPT ); Mon, 18 Mar 2019 04:11:33 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:37635 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726689AbfCRILd (ORCPT ); Mon, 18 Mar 2019 04:11:33 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 39D68354C; Mon, 18 Mar 2019 04:02:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 18 Mar 2019 04:02:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=MEuiurTeIB4a2itE+ooKULoyLGL D/5/6l6W2Qfw+J4o=; b=gFEpjJhne74FQ3tvm3JC7NQSsiZWHNXH2tizJ0DhBei QaVufkhiYp2MtqmnDr+ZRHT/03W94b9XYYRAviolYzuu0sBN7GIQmkO2dPGu3HBZ CSvpsJbucl/eICXVEPXvLgNZZfHRcLnhqZdFCbRcgKGAU+I1kaYXcMJ4E+R6zqMu 41EJ/GwdwbjhOh5nWNgdoU1t0i9YaXl0UyiCnz91abEinjYpoWsjgb18yVAbPUR3 +6KrFtohKgRvSRg2xAvu1/I12qOaTZG/TTbeEUwD2Ii/Zkk1fIV3JUwGyRVHT4vP LCEXLYKcQ4efLE7m+DdP28g75A+zYvbl8yf+4rnYutw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=MEuiur TeIB4a2itE+ooKULoyLGLD/5/6l6W2Qfw+J4o=; b=E7jXR3hzsdOQfH+Q0TQULs T6Frf7AyHMNCU9k1qKVPFvvottKBGzE1HbIJkXZQHPPFEP8POh3DO72qdPJ3T54B adAUrL+1jj1BLKR/XI8sXC7jga6a98BsnrP/6DptkaaXalPQ6BKD4fWRWtPO82IP GPsUx5aB+HFEl/y8J2+RJGfZHtnXZncHoVfpdGoMhy9z9XDAPnwIuK3awlQIcDD7 RqiNRZ0TaEa1KVPYSaV9/DUfi1R9DyAeDoU3UlMBR/k0211av4eH91WnmgtLydoR DT9giRAQqbqf7+pOuPSylgM45doFGHbUqW66ZKr1AEqFg6sITFqBcnauQPDsNgGg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddriedtgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdtredttdervdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuffhomhgrihhnpehqvghmuhdroh hrghenucfkphepkeefrdekiedrkeelrddutdejnecurfgrrhgrmhepmhgrihhlfhhrohhm pehgrhgvgheskhhrohgrhhdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 230E41030F; Mon, 18 Mar 2019 04:02:48 -0400 (EDT) Date: Mon, 18 Mar 2019 09:02:46 +0100 From: Greg KH To: Emil Karlson Cc: stable@vger.kernel.org, Sasha Levin Subject: Re: Request to add fs/9p: use fscache mutex rather than spinlock to 4.4 stable Message-ID: <20190318080246.GA4746@kroah.com> References: <20190315200526.27503fdd@lettuce> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190315200526.27503fdd@lettuce> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Mar 15, 2019 at 08:05:26PM +0200, Emil Karlson wrote: > Greetings > > We are seeing BUGs like this in our test setup (with appropriate > debugging options on): > > [ 164.402581] BUG: sleeping function called from invalid context > at ../include/linux/wait.h:1095 [ 164.404409] in_atomic(): 1, > irqs_disabled(): 0, pid: 3083, name: cp [ 164.405651] 3 locks held by > cp/3083: [ 164.406467] #0: (sb_writers#6){......}, at: > [] __sb_start_write+0x9e/0xd0 [ 164.408213] #1: > (&type->i_mutex_dir_key#7){......}, at: [] > path_openat+0xb22/0x4090 [ 164.410329] #2: > (&(&v9inode->fscache_lock)->rlock){......}, at: [] > v9fs_cache_inode_set_cookie+0x53/0x160 [9p] [ 164.412738] CPU: 1 PID: > 3083 Comm: cp Tainted: G O 4.4.176 #1-NixOS [ 164.414119] > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS > rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org 04/01/2014 [ 164.416351] > 0000000000000447 ffff88004deef7f8 ffffffff818dc664 ffff88004dee8000 > [ 164.417850] ffff88004fc22fd0 ffff88004deef820 ffffffff811bb49f > ffff88004fc22a80 [ 164.419378] ffff88004fc22a80 ffffffffc0141940 > ffff88004deef860 ffffffff811bb605 [ 164.420976] Call Trace: > [ 164.421541] [] dump_stack+0x63/0x8f > [ 164.422551] [] ___might_sleep+0x1ef/0x2c0 > [ 164.423609] [] __might_sleep+0x95/0x1a0 > [ 164.424705] [] > __fscache_disable_cookie+0xa8/0x4c0 [fscache] [ 164.426101] > [] __fscache_relinquish_cookie+0x63/0x3d0 [fscache] > [ 164.427623] [] > v9fs_cache_inode_set_cookie+0xb0/0x160 [9p] [ 164.429093] > [] v9fs_vfs_atomic_open_dotl+0x7de/0xac0 [9p] > [ 164.430477] [] ? > v9fs_inode_from_fid_dotl+0x220/0x220 [9p] [ 164.431869] > [] ? security_capable+0x7a/0xb0 [ 164.433058] > [] ? privileged_wrt_inode_uidgid+0x7a/0xa0 > [ 164.434371] [] ? > capable_wrt_inode_uidgid+0x84/0xb0 [ 164.435600] > [] ? generic_permission+0x261/0x320 [ 164.436784] > [] ? __inode_permission+0xb3/0x240 [ 164.438050] > [] path_openat+0x1920/0x4090 [ 164.439150] > [] ? path_mountpoint+0x7e0/0x7e0 [ 164.440416] > [] ? deactivate_slab+0x17f/0x4c0 [ 164.441511] > [] ? deactivate_slab+0x369/0x4c0 [ 164.442586] > [] ? _raw_spin_unlock+0x27/0x40 [ 164.443733] > [] ? deactivate_slab+0x369/0x4c0 [ 164.444867] > [] do_filp_open+0x170/0x240 [ 164.445867] > [] ? user_path_mountpoint_at+0x40/0x40 > [ 164.447107] [] ? _raw_spin_unlock+0x27/0x40 > [ 164.448198] [] ? __alloc_fd+0x17b/0x410 > [ 164.449220] [] ? kmem_cache_alloc+0xc0/0x1f0 > [ 164.450354] [] do_sys_open+0x22d/0x3a0 > [ 164.451386] [] ? filp_open+0x60/0x60 > [ 164.452353] [] ? lockdep_sys_exit_thunk+0x12/0x14 > [ 164.453511] [] SyS_openat+0x14/0x20 > [ 164.454492] [] entry_SYSCALL_64_fastpath+0x1e/0x9a > > Applying the obvious patch > 8f5fed1e917588f946ad8882bd47a4093db0ff4c > on top of linux-4.4.176 #1-NixOS makes the issue disappear. > > Would it be possible to add this patch to linux-4.4 stable tree? Now queued up, thanks. greg k-h