From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Subject: Re: [PATCH 08/11] mt76x02u: implement pre TBTT work for USB
Date: Mon, 18 Mar 2019 10:50:15 +0100 [thread overview]
Message-ID: <20190318095014.GA3323@redhat.com> (raw)
In-Reply-To: <5844c0b8-3db9-d985-da75-a11318df37c5@nbd.name>
On Sat, Mar 16, 2019 at 08:44:21PM +0100, Felix Fietkau wrote:
> On 2019-03-04 10:48, Stanislaw Gruszka wrote:
> > Program beacons data and PS buffered frames on TBTT work for USB.
> > We do not have MT_TXQ_PSD queue available via USB endpoints. The way
> > we can send PS broadcast frames in timely manner before PS stations go
> > sleep again is program them in beacon data area. Hardware do not modify
> > those frames since TXWI is properly configured. mt76x02_mac_set_beacon()
> > already handle this and free no longer used frames.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> I think it's a nice idea, but there is one problem with that approach:
> beacon slots only have 1024 bytes for TXWI + data.
> I think to support this properly, you probably need to adjust beacon
> offsets for USB dynamically and limit the number of frames to what you
> can fit in SRAM.
That would be good since we could sent more buffered frames (ARP frames
are small), but for now I would prefer simpler solution to enable
AP support for USB: increase slot size to 1600 and make only 5 slots
available.
I assume we can not increase beacon SRAM area to more than 8kB.
Stanislaw
next prev parent reply other threads:[~2019-03-18 9:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 9:48 [PATCH 00/11] mt76x02: AP support for USB with PS Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 01/11] mt76x02: introduce mt76x02_beacon.c Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 02/11] mt76x02: add hrtimer for pre TBTT for USB Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 03/11] mt76x02: introduce beacon_ops Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 04/11] mt76x02u: implement beacon_ops Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 05/11] mt76x02: generalize some mmio beaconing functions Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 06/11] mt76x02u: add sta_ps Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 07/11] mt76x02: disable HW encryption for group frames Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 08/11] mt76x02u: implement pre TBTT work for USB Stanislaw Gruszka
2019-03-16 19:44 ` Felix Fietkau
2019-03-18 9:50 ` Stanislaw Gruszka [this message]
2019-03-18 9:57 ` Felix Fietkau
2019-03-18 10:03 ` Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 09/11] mt76x02u: add mt76_release_buffered_frames Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 10/11] mt76: unify set_tim Stanislaw Gruszka
2019-03-04 9:48 ` [PATCH 11/11] mt76x02: enable AP mode for USB Stanislaw Gruszka
2019-03-04 10:55 ` Lorenzo Bianconi
2019-03-04 11:00 ` Felix Fietkau
2019-03-04 11:04 ` Stanislaw Gruszka
2019-03-04 11:08 ` Lorenzo Bianconi
2019-03-04 12:45 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318095014.GA3323@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.