From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nithin Kumar Dabilpuram Subject: [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable Date: Mon, 18 Mar 2019 09:56:40 +0000 Message-ID: <20190318095613.28167-2-ndabilpuram@marvell.com> References: <20190219064840.12046-1-ndabilpuram@marvell.com> <20190318095613.28167-1-ndabilpuram@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Ferruh Yigit , Nithin Kumar Dabilpuram , "shahafs@mellanox.com" To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Return-path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 66865152A for ; Mon, 18 Mar 2019 10:56:53 +0100 (CET) In-Reply-To: <20190318095613.28167-1-ndabilpuram@marvell.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes both vlan id's as arguments. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: shahafs@mellanox.com Signed-off-by: Nithin Dabilpuram --- v2: * Split change into two seperate patches as suggested. app/test-pmd/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index f800503..0243f07 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2994,7 +2994,8 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id, uint1= 6_t vlan_id_outer) } =20 tx_vlan_reset(port_id); - ports[port_id].dev_conf.txmode.offloads |=3D DEV_TX_OFFLOAD_QINQ_INSERT; + ports[port_id].dev_conf.txmode.offloads |=3D (DEV_TX_OFFLOAD_VLAN_INSERT = | + DEV_TX_OFFLOAD_QINQ_INSERT); ports[port_id].tx_vlan_id =3D vlan_id; ports[port_id].tx_vlan_id_outer =3D vlan_id_outer; } --=20 2.8.4