Re: [PATCH] Staging: rtl8188eu: core: rtw_mlme.c: Fix unbalanced braces around else.

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Mar 18, 2019 at 06:29:18PM +0530, Sanjana Sanikommu wrote:
> Fix unbalanced braces after else statement.
> Issue found by checkpatch.pl semantic patch results for rtw_mlme.c
> 
> CHECK: Unbalanced braces around else statement.
> 
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_mlme.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> index ca0cf8a86671..cbee02a86d22 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> @@ -1111,9 +1111,9 @@ static u8 search_max_mac_id(struct adapter *padapter)
>  				break;
>  		}
>  		mac_id = aid + 1;
> -	} else
> +	} else {
>  #endif
> -	{/* adhoc  id =  31~2 */
> +/* adhoc  id =  31~2 */

Never put anything in the first column within a function, unless it is a
jump label.  This isn't ok, but most importantly, I think you broke the
build.  The { is in that location for a reason, due to the #endif above
it, and can not be changed.

Please always think about the checkpatch changes you are making and do
not just blindly do them.

thanks,

greg k-h