From: Eric Biggers <ebiggers@kernel.org>
To: ltp@lists.linux.it
Cc: linux-crypto@vger.kernel.org
Subject: [PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests
Date: Mon, 18 Mar 2019 10:13:21 -0700 [thread overview]
Message-ID: <20190318171327.237014-1-ebiggers@kernel.org> (raw)
Hello,
This series adds helper functions for testing AF_ALG (the userspace
interface to algorithms in the Linux kernel's crypto API) to the
Linux Test Project. It then adds a few sample regression tests.
I've had these patches sitting around for a while with the goal of also
writing some "real" tests that test for more than these specific bugs,
but haven't gotten around to it yet. And I now consider further
improving the in-kernel crypto self-tests to be a higher priority. But
I figured I'd send this out as-is in case people are interested in
having this merged, e.g. maybe other people want to add AF_ALG tests to
LTP too and the 'tst_af_alg' lib would be a good starting point.
Changed since v1:
- Define 'AF_ALG' in include/lapi/socket.h if undefined.
Also move 'SOL_ALG' definition to there.
- Add all new tests to runtest/crypto.
- In af_alg01, use .test() and .tcnt rather than a 'for' loop.
- Consistently use 'algfd' rather than 'alg_fd', and similarly for reqfd.
- Make two error messages in tst_af_alg.c clearer.
- Add SPDX license identifier to include/lapi/if_alg.h.
Eric Biggers (6):
lib: add tst_af_alg lib
crypto/af_alg01: new regression test for hmac nesting bug
crypto/af_alg02: new regression test for salsa20 empty message bug
crypto/af_alg03: new regression test for rfc7539 hash alg validation
crypto/af_alg04: new regression test for vmac race conditions
crypto/af_alg05: new regression test for skcipher_walk error bug
configure.ac | 1 +
include/lapi/if_alg.h | 38 ++++++++
include/lapi/socket.h | 8 ++
include/tst_af_alg.h | 136 ++++++++++++++++++++++++++
lib/tst_af_alg.c | 147 +++++++++++++++++++++++++++++
runtest/crypto | 5 +
runtest/cve | 2 +
testcases/kernel/crypto/.gitignore | 5 +
testcases/kernel/crypto/af_alg01.c | 78 +++++++++++++++
testcases/kernel/crypto/af_alg02.c | 29 ++++++
testcases/kernel/crypto/af_alg03.c | 31 ++++++
testcases/kernel/crypto/af_alg04.c | 56 +++++++++++
testcases/kernel/crypto/af_alg05.c | 43 +++++++++
13 files changed, 579 insertions(+)
create mode 100644 include/lapi/if_alg.h
create mode 100644 include/tst_af_alg.h
create mode 100644 lib/tst_af_alg.c
create mode 100644 testcases/kernel/crypto/af_alg01.c
create mode 100644 testcases/kernel/crypto/af_alg02.c
create mode 100644 testcases/kernel/crypto/af_alg03.c
create mode 100644 testcases/kernel/crypto/af_alg04.c
create mode 100644 testcases/kernel/crypto/af_alg05.c
--
2.21.0.225.g810b269d1ac-goog
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests
Date: Mon, 18 Mar 2019 10:13:21 -0700 [thread overview]
Message-ID: <20190318171327.237014-1-ebiggers@kernel.org> (raw)
Hello,
This series adds helper functions for testing AF_ALG (the userspace
interface to algorithms in the Linux kernel's crypto API) to the
Linux Test Project. It then adds a few sample regression tests.
I've had these patches sitting around for a while with the goal of also
writing some "real" tests that test for more than these specific bugs,
but haven't gotten around to it yet. And I now consider further
improving the in-kernel crypto self-tests to be a higher priority. But
I figured I'd send this out as-is in case people are interested in
having this merged, e.g. maybe other people want to add AF_ALG tests to
LTP too and the 'tst_af_alg' lib would be a good starting point.
Changed since v1:
- Define 'AF_ALG' in include/lapi/socket.h if undefined.
Also move 'SOL_ALG' definition to there.
- Add all new tests to runtest/crypto.
- In af_alg01, use .test() and .tcnt rather than a 'for' loop.
- Consistently use 'algfd' rather than 'alg_fd', and similarly for reqfd.
- Make two error messages in tst_af_alg.c clearer.
- Add SPDX license identifier to include/lapi/if_alg.h.
Eric Biggers (6):
lib: add tst_af_alg lib
crypto/af_alg01: new regression test for hmac nesting bug
crypto/af_alg02: new regression test for salsa20 empty message bug
crypto/af_alg03: new regression test for rfc7539 hash alg validation
crypto/af_alg04: new regression test for vmac race conditions
crypto/af_alg05: new regression test for skcipher_walk error bug
configure.ac | 1 +
include/lapi/if_alg.h | 38 ++++++++
include/lapi/socket.h | 8 ++
include/tst_af_alg.h | 136 ++++++++++++++++++++++++++
lib/tst_af_alg.c | 147 +++++++++++++++++++++++++++++
runtest/crypto | 5 +
runtest/cve | 2 +
testcases/kernel/crypto/.gitignore | 5 +
testcases/kernel/crypto/af_alg01.c | 78 +++++++++++++++
testcases/kernel/crypto/af_alg02.c | 29 ++++++
testcases/kernel/crypto/af_alg03.c | 31 ++++++
testcases/kernel/crypto/af_alg04.c | 56 +++++++++++
testcases/kernel/crypto/af_alg05.c | 43 +++++++++
13 files changed, 579 insertions(+)
create mode 100644 include/lapi/if_alg.h
create mode 100644 include/tst_af_alg.h
create mode 100644 lib/tst_af_alg.c
create mode 100644 testcases/kernel/crypto/af_alg01.c
create mode 100644 testcases/kernel/crypto/af_alg02.c
create mode 100644 testcases/kernel/crypto/af_alg03.c
create mode 100644 testcases/kernel/crypto/af_alg04.c
create mode 100644 testcases/kernel/crypto/af_alg05.c
--
2.21.0.225.g810b269d1ac-goog
next reply other threads:[~2019-03-18 17:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:13 Eric Biggers [this message]
2019-03-18 17:13 ` [LTP] [PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests Eric Biggers
2019-03-18 17:13 ` [PATCH v2 1/6] lib: add tst_af_alg lib Eric Biggers
2019-03-18 17:13 ` [LTP] " Eric Biggers
2019-03-18 17:13 ` [PATCH v2 2/6] crypto/af_alg01: new regression test for hmac nesting bug Eric Biggers
2019-03-18 17:13 ` [LTP] " Eric Biggers
2019-03-18 17:13 ` [PATCH v2 3/6] crypto/af_alg02: new regression test for salsa20 empty message bug Eric Biggers
2019-03-18 17:13 ` [LTP] " Eric Biggers
2019-03-18 17:13 ` [PATCH v2 4/6] crypto/af_alg03: new regression test for rfc7539 hash alg validation Eric Biggers
2019-03-18 17:13 ` [LTP] " Eric Biggers
2019-03-18 17:13 ` [PATCH v2 5/6] crypto/af_alg04: new regression test for vmac race conditions Eric Biggers
2019-03-18 17:13 ` [LTP] " Eric Biggers
2019-03-18 17:13 ` [PATCH v2 6/6] crypto/af_alg05: new regression test for skcipher_walk error bug Eric Biggers
2019-03-18 17:13 ` [LTP] " Eric Biggers
2019-03-18 18:27 ` [LTP] [PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests Petr Vorel
2019-03-18 18:27 ` Petr Vorel
2019-03-18 19:10 ` Petr Vorel
2019-03-18 19:10 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318171327.237014-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.