All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: vatsalanarang <vatsalanarang@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/2] Eliminate camel case
Date: Mon, 18 Mar 2019 18:41:27 +0100	[thread overview]
Message-ID: <20190318174127.GA22288@kroah.com> (raw)
In-Reply-To: <20190318165938.2503-1-vatsalanarang@gmail.com>

On Mon, Mar 18, 2019 at 10:29:38PM +0530, vatsalanarang wrote:
> Issue reported by checkpatch.pl tool
> 
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_display.c | 5 ++---
>  drivers/staging/sm750fb/ddk750_power.h   | 2 +-
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
> index 7f28e4cc4c79..6380e1536598 100644
> --- a/drivers/staging/sm750fb/ddk750_display.c
> +++ b/drivers/staging/sm750fb/ddk750_display.c
> @@ -147,8 +147,8 @@ void ddk750_set_logical_disp_out(enum disp_output output)
>  
>  	if (output & PNL_SEQ_USAGE) {
>  		/* set  panel sequence */
> -		sw_panel_power_sequence
> -		((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, 4);
> +		sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
> +				4);

This is not what your subject said it was doing :(

Also, it doesn't look correct, right?

And your From: line needs to match your signed-off-by line.

And finally, this is patch 2/2?  Where is 1/2?

thanks,

greg k-h


  reply	other threads:[~2019-03-18 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 16:59 [PATCH 2/2] Eliminate camel case vatsalanarang
2019-03-18 17:41 ` Greg KH [this message]
2019-03-18 18:16 ` Vatsala Narang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318174127.GA22288@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=vatsalanarang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.