From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-707-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 20149985BEC for ; Mon, 18 Mar 2019 22:48:57 +0000 (UTC) Date: Mon, 18 Mar 2019 18:48:50 -0400 From: "Michael S. Tsirkin" Message-ID: <20190318184809-mutt-send-email-mst@kernel.org> References: <54DB94AE64EDA14BAB6A1E9641A26B011AC7DEA3@hasmsx109.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54DB94AE64EDA14BAB6A1E9641A26B011AC7DEA3@hasmsx109.ger.corp.intel.com> Subject: Re: [virtio-comment] Duplicated text - Section 5.2.6.4 - version 1.1 draft 01 To: "Savir, Gil" Cc: "virtio-comment@lists.oasis-open.org" List-ID: On Tue, Mar 05, 2019 at 04:15:00PM +0000, Savir, Gil wrote: > In version 1.1 draft 01 - Section 5.2.6.4 - second bullet: > > Duplicated text "errors, data_len, sense_len and residual MUST reside in a single, separate device-writable descriptor" appears both in the beginning and at the end of the 2nd sentence. > > The original text: > * For SCSI commands there are additional constraints. errors, data_len, sense_len and residual MUST reside in a single, separate device-writable descriptor, sense MUST reside in a single separate devicewritable descriptor of size 96 bytes, and errors, data_len, sense_len and residual MUST reside a single separate device-writable descriptor. > > I suggest to delete the 1st one, so in the end result, fields are described in same order as appear in struct virtio_scsi_pc_req. > > Thanks, > Gil Savir > Thanks for the report! I saved this defect as https://github.com/oasis-tcs/virtio-spec/issues/39 > --------------------------------------------------------------------- > Intel Israel (74) Limited > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/ This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/