From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/icl: pass cfgcr* register around instead of pll_id Date: Mon, 18 Mar 2019 20:53:23 +0200 Message-ID: <20190318185323.GR3888@intel.com> References: <20190316004526.12065-1-lucas.demarchi@intel.com> <20190318133152.GJ3888@intel.com> <20190318184034.eqpjpyxupafrbx57@ldmartin-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A84489803 for ; Mon, 18 Mar 2019 18:53:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190318184034.eqpjpyxupafrbx57@ldmartin-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMTE6NDA6MzRBTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IE9uIE1vbiwgTWFyIDE4LCAyMDE5IGF0IDAzOjMxOjUyUE0gKzAyMDAsIFZpbGxl IFN5cmrDpGzDpCB3cm90ZToKPiA+T24gRnJpLCBNYXIgMTUsIDIwMTkgYXQgMDU6NDU6MjZQTSAt MDcwMCwgTHVjYXMgRGUgTWFyY2hpIHdyb3RlOgo+ID4+IFRoZSBjYWxsZXIgYWxyZWFkeSBrbm93 cyB3aGF0IHBsYXRmb3JtIHRoYXQgaXMgYW5kIHdoYXQgcmVnaXN0ZXIgc2hvdWxkCj4gPj4gYmUg dXNlZC4gSW5zdGVhZCBvZiBrZWVwIGFkZGluZyBpZi9lbHNlIGNoYWlucyBvbiBhIGxlYWYgZnVu Y3Rpb25zLAo+ID4+IGxldCB0aGUgY2FsbGVyIHBhc3MgdGhlIHJlZ2lzdGVyLgo+ID4+Cj4gPj4g V2UgcmVhZCBjZmdjcjAgdHdpY2UgZm9yIENOTCwgYnV0IHdlIHdlcmUgYWxyZWFkeSBkb2luZyB0 aGF0IGFueXdheS4KPiA+Pgo+ID4+IGljbF9jYWxjX2RwX2NvbWJvX3BsbF9saW5rKCkgaXMgb25s eSB1c2VkIGZvciBJQ0wsIGJ1dCBsZXQncyBrZWVwCj4gPj4gY29uc2lzdGVuY3kgd2l0aCBjbmxf Y2FsY193cnBsbF9saW5rKCkuCj4gPj4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJj aGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaWNsX2RzaS5jICAgICAgICB8ICA0ICsrKy0KPiA+PiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGRpLmMgICAgICB8IDI1ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiA+ PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyB8ICA2ICsrKy0tLQo+ID4+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oIHwgIDIgKy0KPiA+PiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgICB8ICAyICstCj4gPj4gIDUgZmlsZXMg Y2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaWNsX2RzaS5jCj4gPj4gaW5kZXggYmViMzBkOWE4NTVjLi4yOGY1ZGE2OTc2OTMgMTAw NjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jCj4gPj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jCj4gPj4gQEAgLTExODMsNyArMTE4Myw5IEBA IHN0YXRpYyB2b2lkIGdlbjExX2RzaV9nZXRfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICpl bmNvZGVyLAo+ID4+Cj4gPj4gIAkvKiBGSVhNRTogYWRhcHQgaWNsX2RkaV9jbG9ja19nZXQoKSBm b3IgRFNJIGFuZCB1c2UgdGhhdD8gKi8KPiA+PiAgCXBsbF9pZCA9IGludGVsX2dldF9zaGFyZWRf ZHBsbF9pZChkZXZfcHJpdiwgcGlwZV9jb25maWctPnNoYXJlZF9kcGxsKTsKPiA+PiAtCXBpcGVf Y29uZmlnLT5wb3J0X2Nsb2NrID0gY25sX2NhbGNfd3JwbGxfbGluayhkZXZfcHJpdiwgcGxsX2lk KTsKPiA+PiArCXBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrID0gY25sX2NhbGNfd3JwbGxfbGluayhk ZXZfcHJpdiwKPiA+PiArCQkJCQkJICAgICAgSUNMX0RQTExfQ0ZHQ1IwKHBsbF9pZCksCj4gPj4g KwkJCQkJCSAgICAgIElDTF9EUExMX0NGR0NSMShwbGxfaWQpKTsKPiA+PiAgCXBpcGVfY29uZmln LT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19jbG9jayA9IGludGVsX2RzaS0+cGNsazsKPiA+PiAg CXBpcGVfY29uZmlnLT5vdXRwdXRfdHlwZXMgfD0gQklUKElOVEVMX09VVFBVVF9EU0kpOwo+ID4+ ICB9Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+PiBpbmRleCA2OWFhMGQxNDg3OTUu LjI0Njc1ZWY4YjI2MiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kZGkuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPj4g QEAgLTEzMDQsMTggKzEzMDQsMTMgQEAgc3RhdGljIGludCBza2xfY2FsY193cnBsbF9saW5rKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+PiAgfQo+ID4+Cj4gPj4gIGludCBj bmxfY2FsY193cnBsbF9saW5rKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ PiAtCQkJZW51bSBpbnRlbF9kcGxsX2lkIHBsbF9pZCkKPiA+PiArCQkJaTkxNV9yZWdfdCBjZmdj cjBfcmVnLCBpOTE1X3JlZ190IGNmZ2NyMV9yZWcpCj4gPj4gIHsKPiA+PiAgCXUzMiBjZmdjcjAs IGNmZ2NyMTsKPiA+PiAgCXUzMiBwMCwgcDEsIHAyLCBkY29fZnJlcSwgcmVmX2Nsb2NrOwo+ID4+ Cj4gPj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkgewo+ID4+IC0JCWNmZ2NyMCA9 IEk5MTVfUkVBRChJQ0xfRFBMTF9DRkdDUjAocGxsX2lkKSk7Cj4gPj4gLQkJY2ZnY3IxID0gSTkx NV9SRUFEKElDTF9EUExMX0NGR0NSMShwbGxfaWQpKTsKPiA+PiAtCX0gZWxzZSB7Cj4gPj4gLQkJ Y2ZnY3IwID0gSTkxNV9SRUFEKENOTF9EUExMX0NGR0NSMChwbGxfaWQpKTsKPiA+PiAtCQljZmdj cjEgPSBJOTE1X1JFQUQoQ05MX0RQTExfQ0ZHQ1IxKHBsbF9pZCkpOwo+ID4+IC0JfQo+ID4+ICsJ Y2ZnY3IwID0gSTkxNV9SRUFEKGNmZ2NyMF9yZWcpOwo+ID4+ICsJY2ZnY3IxID0gSTkxNV9SRUFE KGNmZ2NyMV9yZWcpOwo+ID4KPiA+RG9uJ3Qgd2UgYWxyZWR5IGhhdmUgdGhlIGRwbGwgc3RhdGUg cmVhZCBvdXQgYXQgdGhpcyBwb2ludD8KPiAKPiBub3BzLgoKV2UgbXVzdCBoYXZlIGl0IHNpbmNl IGJ4dCBpcyBhbHJlYWR5IHVzaW5nIGl0LiBFaXRoZXIgdGhhdCBvciBieHQgaXMKYnJva2VuLgoK LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZng=