From: Vladimir Petrigo <vladimir.petrigo@gmail.com>
To: Phil Reid <preid@electromag.com.au>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stefan Popa <stefan.popa@analog.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
Slawomir Stepien <sst@poczta.fm>,
Nishad Kamdar <nishadkamdar@gmail.com>,
Renato Lui Geh <renatogeh@gmail.com>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/3] staging: iio: ad7192: Fix style issue
Date: Tue, 19 Mar 2019 11:14:57 +0300 [thread overview]
Message-ID: <20190319081457.GA61719@ubuntu> (raw)
In-Reply-To: <b486e164-7231-728e-6788-c787ed96bb57@electromag.com.au>
On Mon, Mar 18, 2019 at 10:27:57AM +0800, Phil Reid wrote:
> On 18/03/2019 4:53 am, Vladimir Petrigo wrote:
> >Signed-off-by: Vladimir Petrigo <vladimir.petrigo@gmail.com>
> >---
> > drivers/staging/iio/adc/ad7192.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> >index acdbc07..7c632cf 100644
> >--- a/drivers/staging/iio/adc/ad7192.c
> >+++ b/drivers/staging/iio/adc/ad7192.c
> >@@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev,
> > }
> > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> >- in_voltage-voltage_scale_available,
> >+ in_voltage - voltage_scale_available,
> > 0444, ad7192_show_scale_available, NULL, 0);
> > static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> >
> G'day Vladimir ,
>
> This is not a mathematical op.
> It gets passed to __ATTR() macro and converted to a string.
>
>
> --
> Regards
> Phil
Hello Phil,
Thank you for the prompt reply.
Should I remove that changes from the patchset v2 then?
--
Best regards,
Vladimir
next prev parent reply other threads:[~2019-03-19 8:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 20:53 [PATCH 0/3] Code formatting clean up Vladimir Petrigo
2019-03-17 20:53 ` [PATCH 1/3] staging: iio: ad7192: Fix style issue Vladimir Petrigo
2019-03-18 2:27 ` Phil Reid
2019-03-19 8:14 ` Vladimir Petrigo [this message]
2019-03-17 20:53 ` [PATCH 2/3] staging: iio: ad7280a: Add parentheses to macros Vladimir Petrigo
2019-03-20 7:38 ` Dan Carpenter
2019-03-21 21:14 ` Vladimir Petrigo
2019-03-17 20:53 ` [PATCH 3/3] staging: iio: ad7780: " Vladimir Petrigo
2019-03-20 7:42 ` Dan Carpenter
2019-03-21 21:12 ` Vladimir Petrigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319081457.GA61719@ubuntu \
--to=vladimir.petrigo@gmail.com \
--cc=alexandru.ardelean@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nishadkamdar@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=preid@electromag.com.au \
--cc=renatogeh@gmail.com \
--cc=sst@poczta.fm \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.