From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,1/2] dt-bindings: usb: add documentation for typec switch via GPIO From: Heikki Krogerus Message-Id: <20190319081801.GP7752@kuha.fi.intel.com> Date: Tue, 19 Mar 2019 10:18:01 +0200 To: Jun Li Cc: Rob Herring , "gregkh@linuxfoundation.org" , "hdegoede@redhat.com" , "andy.shevchenko@gmail.com" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , dl-linux-imx List-ID: T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMTA6NTk6MzFBTSArMDAwMCwgSnVuIExpIHdyb3RlOgo+ IAo+IAo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEhlaWtraSBLcm9n ZXJ1cyA8aGVpa2tpLmtyb2dlcnVzQGxpbnV4LmludGVsLmNvbT4KPiA+IFNlbnQ6IDIwMTnlubQz 5pyIMTPml6UgMTc6MzYKPiA+IFRvOiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+ID4g Q2M6IEp1biBMaSA8anVuLmxpQG54cC5jb20+OyBncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZzsg aGRlZ29lZGVAcmVkaGF0LmNvbTsKPiA+IGFuZHkuc2hldmNoZW5rb0BnbWFpbC5jb207IGxpbnV4 LXVzYkB2Z2VyLmtlcm5lbC5vcmc7Cj4gPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgZGwt bGludXgtaW14IDxsaW51eC1pbXhAbnhwLmNvbT4KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMg MS8yXSBkdC1iaW5kaW5nczogdXNiOiBhZGQgZG9jdW1lbnRhdGlvbiBmb3IgdHlwZWMgc3dpdGNo Cj4gPiB2aWEgR1BJTwo+ID4gCj4gPiBPbiBUdWUsIE1hciAxMiwgMjAxOSBhdCAwOTo0NToyN0FN IC0wNTAwLCBSb2IgSGVycmluZyB3cm90ZToKPiA+ID4gT24gTW9uLCBNYXIgMTEsIDIwMTkgYXQg MTA6NDA6MDlBTSArMDAwMCwgSnVuIExpIHdyb3RlOgo+ID4gPiA+IFNvbWUgdHlwZWMgc3VwZXIg c3BlZWQgYWN0aXZlIGNoYW5uZWwgc3dpdGNoIGNhbiBiZSBjb250cm9sbGVkIHZpYSBhCj4gPiA+ ID4gR1BJTywgdGhpcyBiaW5kaW5nIGNhbiBiZSB1c2VkIHRvIHNwZWNpZnkgdGhlIHN3aXRjaCBu b2RlIGJ5IGEgR1BJTwo+ID4gPiA+IGFuZCB0aGUgcmVtb3RlIGVuZHBvaW50IG9mIGl0cyBjb25z dW1lci4KPiA+ID4gPgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IExpIEp1biA8anVuLmxpQG54cC5j b20+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi90eXBl Yy1zd2l0Y2gtZ3Bpby50eHQgIHwgMzAKPiA+ID4gPiArKysrKysrKysrKysrKysrKysrKysrCj4g PiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspCj4gPiA+ID4KPiA+ID4gPiBk aWZmIC0tZ2l0Cj4gPiA+ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNi L3R5cGVjLXN3aXRjaC1ncGlvLnR4dAo+ID4gPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL3VzYi90eXBlYy1zd2l0Y2gtZ3Bpby50eHQKPiA+ID4gPiBuZXcgZmlsZSBtb2Rl IDEwMDY0NAo+ID4gPiA+IGluZGV4IDAwMDAwMDAuLjRlZjc2Y2YKPiA+ID4gPiAtLS0gL2Rldi9u dWxsCj4gPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi90 eXBlYy1zd2l0Y2gtZ3Bpby50eHQKPiA+ID4gPiBAQCAtMCwwICsxLDMwIEBACj4gPiA+ID4gK1R5 cGVjIG9yaWVudGF0aW9uIHN3aXRjaCB2aWEgYSBHUElPCj4gPiA+ID4gKy0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ID4gKwo+ID4gPiA+ICtSZXF1aXJlZCBwcm9wZXJ0 aWVzOgo+ID4gPiA+ICstIGNvbXBhdGlibGU6IHNob3VsZCBiZSBzZXQgb25lIG9mIGZvbGxvd2lu ZzoKPiA+ID4gPiArCS0gIm54cCxwdG4zNjA0MyIgZm9yIE5YUCBUeXBlLUMgU3VwZXJTcGVlZCBh Y3RpdmUgc3dpdGNoLgo+ID4gPiA+ICsKPiA+ID4gPiArLSBncGlvczogdGhlIEdQSU8gdXNlZCB0 byBzd2l0Y2ggdGhlIHN1cGVyIHNwZWVkIGFjdGl2ZSBjaGFubmVsLAo+ID4gPgo+ID4gPiBQZXJo YXBzIHN3aXRjaC1ncGlvcyBpbiBjYXNlIHRoZXJlIGFyZSBvdGhlciBncGlvcyBuZWVkZWQuCj4g PiA+Cj4gPiA+ID4gKwkJR1BJT19BQ1RJVkVfSElHSDogR1BJTyBzdGF0ZSBoaWdoIGZvciBjYzE7 Cj4gPiA+ID4gKwkJR1BJT19BQ1RJVkVfTE9XOiAgR1BJTyBzdGF0ZSBsb3cgZm9yIGNjMS4KPiA+ ID4gPiArLSBvcmllbnRhdGlvbi1zd2l0Y2g6IG11c3QgYmUgcHJlc2VudC4KPiA+ID4KPiA+ID4g V2h5IGlzIHRoaXMgbmVlZGVkPyBUaGUgY29tcGF0aWJsZSBjYW4ndCBpbXBseSB0aGlzPwo+ID4g Cj4gPiBJIHRoaW5rIEp1biBMaSBpcyBhZGRlZCB0aGF0IGJhc2VkIG9uIHRoZSBjb21tZW50IEkg cHV0IHRvIGRyaXZlcnMvdXNiL3R5cGVjL211eC5jLAo+ID4gc28gSSdtIHRvIGJsYW1lIGhlcmUu IElmIHdlIGNhbiBoYW5kbGUgdGhpcyB3aXRoIHRoZSBjb21wYXRpYmxlIGxpa2UgSSBndWVzcyB3 ZSBjYW4sCj4gPiBJJ20gaGFwcHkuCj4gCj4gSGkgSGVpa2tpCj4gCj4gQ2FuIEkganVzdCByZW1v dmUgdGhlIG9yaWdpbmFsIGJvb2wgcHJvcGVydHkgY2hlY2s/IGkuZSwgbWF0Y2ggT0sgaWYgdGhl IHJlbW90ZQo+IHBhcmVudCBub2RlIGlzIGluIHN3aXRjaF9saXN0LgoKTm8uIElmIHR5cGVjX3N3 aXRjaF9nZXQoKSBpcyBjYWxsZWQgYmVmb3JlIHRoZSBtdXggZGV2aWNlIGlzCnJlZ2lzdGVyZWQs IHdlIG5lZWQgdG8gcmV0dXJuIC1FUFJPQkVfREVGRVIuIFRoYXQgbWVhbnMgd2UgbmVlZCB0byBi ZQphYmxlIHRvIGlkZW50aWZ5IHRoZSBtdXggZGV2aWNlIG5vZGUuCgpJIHRoaW5rIHdlIHNob3Vs ZCBqdXN0IHVzZSB0aGUgY29tcGF0aWJsZSBsaWtlIFJvYiBzdWdnZXN0ZWQuIFRoZQpUeXBlLUMg bXV4ZXMgc2hvdWxkIHByb2JhYmxlIGhhdmUgdGhlaXIgb3duIGJpbmRpbmdzIGZpbGUgd2hlcmUg aXQncwpkZWZpbmVkIGZvciB0aGVzZSBtdXhlcy4KCgp0aGFua3MsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 19 Mar 2019 10:18:01 +0200 From: Heikki Krogerus Subject: Re: [PATCH v3 1/2] dt-bindings: usb: add documentation for typec switch via GPIO Message-ID: <20190319081801.GP7752@kuha.fi.intel.com> References: <1552299557-6306-1-git-send-email-jun.li@nxp.com> <20190312144527.GA18735@bogus> <20190313093540.GB7752@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: To: Jun Li Cc: Rob Herring , "gregkh@linuxfoundation.org" , "hdegoede@redhat.com" , "andy.shevchenko@gmail.com" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , dl-linux-imx List-ID: On Mon, Mar 18, 2019 at 10:59:31AM +0000, Jun Li wrote: > > > > -----Original Message----- > > From: Heikki Krogerus > > Sent: 2019年3月13日 17:36 > > To: Rob Herring > > Cc: Jun Li ; gregkh@linuxfoundation.org; hdegoede@redhat.com; > > andy.shevchenko@gmail.com; linux-usb@vger.kernel.org; > > devicetree@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH v3 1/2] dt-bindings: usb: add documentation for typec switch > > via GPIO > > > > On Tue, Mar 12, 2019 at 09:45:27AM -0500, Rob Herring wrote: > > > On Mon, Mar 11, 2019 at 10:40:09AM +0000, Jun Li wrote: > > > > Some typec super speed active channel switch can be controlled via a > > > > GPIO, this binding can be used to specify the switch node by a GPIO > > > > and the remote endpoint of its consumer. > > > > > > > > Signed-off-by: Li Jun > > > > --- > > > > .../devicetree/bindings/usb/typec-switch-gpio.txt | 30 > > > > ++++++++++++++++++++++ > > > > 1 file changed, 30 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt > > > > b/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt > > > > new file mode 100644 > > > > index 0000000..4ef76cf > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt > > > > @@ -0,0 +1,30 @@ > > > > +Typec orientation switch via a GPIO > > > > +----------------------------------- > > > > + > > > > +Required properties: > > > > +- compatible: should be set one of following: > > > > + - "nxp,ptn36043" for NXP Type-C SuperSpeed active switch. > > > > + > > > > +- gpios: the GPIO used to switch the super speed active channel, > > > > > > Perhaps switch-gpios in case there are other gpios needed. > > > > > > > + GPIO_ACTIVE_HIGH: GPIO state high for cc1; > > > > + GPIO_ACTIVE_LOW: GPIO state low for cc1. > > > > +- orientation-switch: must be present. > > > > > > Why is this needed? The compatible can't imply this? > > > > I think Jun Li is added that based on the comment I put to drivers/usb/typec/mux.c, > > so I'm to blame here. If we can handle this with the compatible like I guess we can, > > I'm happy. > > Hi Heikki > > Can I just remove the original bool property check? i.e, match OK if the remote > parent node is in switch_list. No. If typec_switch_get() is called before the mux device is registered, we need to return -EPROBE_DEFER. That means we need to be able to identify the mux device node. I think we should just use the compatible like Rob suggested. The Type-C muxes should probable have their own bindings file where it's defined for these muxes. thanks, -- heikki