From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: option: set driver_info for SIM5218 and compatibles From: Johan Hovold Message-Id: <20190319102840.GI6124@localhost> Date: Tue, 19 Mar 2019 11:28:40 +0100 To: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Johan Hovold , =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBGZWIgMjcsIDIwMTkgYXQgMDI6MzI6NThQTSArMDAwMCwgTcOlbnMgUnVsbGfDpXJk IHdyb3RlOgo+IEpvaGFuIEhvdm9sZCA8am9oYW5Aa2VybmVsLm9yZz4gd3JpdGVzOgo+IAo+ID4g QWRkaW5nIEJqw7hybi4KPiA+Cj4gPiBPbiBXZWQsIEZlYiAyNywgMjAxOSBhdCAxMTo1NzoxNkFN ICswMDAwLCBNw6VucyBSdWxsZ8OlcmQgd3JvdGU6Cj4gPj4gSm9oYW4gSG92b2xkIDxqb2hhbkBr ZXJuZWwub3JnPiB3cml0ZXM6Cj4gPj4gCj4gPj4gPiBPbiBUdWUsIEZlYiAyNiwgMjAxOSBhdCAw NTowNzoxMFBNICswMDAwLCBNYW5zIFJ1bGxnYXJkIHdyb3RlOgo+ID4+ID4+IFRoZSBTSU1Db20g U0lNNTIxOCBhbmQgY29tcGF0aWJsZSBkZXZpY2VzIGhhdmUgNSBVU0IgaW50ZXJmYWNlcywgb25s eSA0Cj4gPj4gPj4gb2Ygd2hpY2ggYXJlIHNlcmlhbCBwb3J0cy4gIFRoZSBmaWZ0aCBpcyBhIG5l dHdvcmsgaW50ZXJmYWNlIHN1cHBvcnRlZAo+ID4+ID4+IGJ5IHRoZSBxbWktd3dhbiBkcml2ZXIu ICBGdXJ0aGVybW9yZSwgdGhlIHNlcmlhbCBwb3J0cyBkbyBub3Qgc3VwcG9ydAo+ID4+ID4+IG1v ZGVtIGNvbnRyb2wgc2lnbmFscy4gIEFkZCBkcml2ZXJfaW5mbyBmbGFncyB0byByZWZsZWN0IHRo aXMuCj4gPj4gPj4gCj4gPj4gPj4gU2lnbmVkLW9mZi1ieTogTWFucyBSdWxsZ2FyZCA8bWFuc0Bt YW5zci5jb20+Cj4gPj4gPj4gLS0tCj4gPj4gPj4gIGRyaXZlcnMvdXNiL3NlcmlhbC9vcHRpb24u YyB8IDMgKystCj4gPj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKPiA+PiA+PiAKPiA+PiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc2VyaWFs L29wdGlvbi5jIGIvZHJpdmVycy91c2Ivc2VyaWFsL29wdGlvbi5jCj4gPj4gPj4gaW5kZXggZmI1 NDQzNDA4ODhiLi5hZjRjYmZlY2MzZmYgMTAwNjQ0Cj4gPj4gPj4gLS0tIGEvZHJpdmVycy91c2Iv c2VyaWFsL29wdGlvbi5jCj4gPj4gPj4gKysrIGIvZHJpdmVycy91c2Ivc2VyaWFsL29wdGlvbi5j Cj4gPj4gPj4gQEAgLTEwNjYsNyArMTA2Niw4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgdXNiX2Rl dmljZV9pZCBvcHRpb25faWRzW10gPSB7Cj4gPj4gPj4gIAkgIC5kcml2ZXJfaW5mbyA9IFJTVkQo MykgfSwKPiA+PiA+PiAgCXsgVVNCX0RFVklDRShRVUFMQ09NTV9WRU5ET1JfSUQsIDB4NjYxMyl9 LCAvKiBPbmRhIEg2MDAvWlRFIE1GMzMwICovCj4gPj4gPj4gIAl7IFVTQl9ERVZJQ0UoUVVBTENP TU1fVkVORE9SX0lELCAweDAwMjMpfSwgLyogT05ZWCAzRyBkZXZpY2UgKi8KPiA+PiA+PiAtCXsg VVNCX0RFVklDRShRVUFMQ09NTV9WRU5ET1JfSUQsIDB4OTAwMCl9LCAvKiBTSU1Db20gU0lNNTIx OCAqLwo+ID4+ID4+ICsJeyBVU0JfREVWSUNFKFFVQUxDT01NX1ZFTkRPUl9JRCwgMHg5MDAwKSwg LyogU0lNQ29tIFNJTTUyMTggKi8KPiA+PiA+PiArCSAgLmRyaXZlcl9pbmZvID0gTkNUUkwoMCkg fCBOQ1RSTCgxKSB8IE5DVFJMKDIpIHwgTkNUUkwoMykgfCBSU1ZEKDQpIH0sCj4gPj4gPj4gIAkv KiBRdWVjdGVsIHByb2R1Y3RzIHVzaW5nIFF1YWxjb21tIHZlbmRvciBJRCAqLwo+ID4+ID4+ICAJ eyBVU0JfREVWSUNFKFFVQUxDT01NX1ZFTkRPUl9JRCwgUVVFQ1RFTF9QUk9EVUNUX1VDMTUpfSwK PiA+PiA+PiAgCXsgVVNCX0RFVklDRShRVUFMQ09NTV9WRU5ET1JfSUQsIFFVRUNURUxfUFJPRFVD VF9VQzIwKSwKPiA+PiA+Cj4gPj4gPiBDb3VsZCB5b3UgcGxlYXNlIHByb3ZpZGUgdGhlIG91dHB1 dCBvZiB1c2ItZGV2aWNlcyAob3IgbHN1c2IgLXYpIGZvcgo+ID4+ID4gdGhpcyBkZXZpY2U/Cj4g Pj4gCj4gPj4gbHN1c2IgLXY6Cj4gPj4gWy4uLl0KPiAKPiA+IFNvIHRoZSBwYXRjaCBsb29rcyBm aW5lIHRvIG1lLiBUaGUgZmlmdGggaW50ZXJmYWNlIGlzIFFNSSwgYnV0IGhhc24ndAo+ID4gYmVl biBhdmFpbGFibGUgZm9yIHVzZSB1bnRpbCBub3cgdGhlbiwgYW5kIHRoaXMgc2VlbXMgdG8gaGF2 ZSBiZWVuIHRoZQo+ID4gdmVuZG9ycyBpZGVhIGZyb20gdGhlIHN0YXJ0Ogo+ID4KPiA+IAlodHRw Oi8vd3d3Lm1pY3JvY2hpcC51YS9zaW1jb20vV0NETUEvQVBQTk9URVMvU0lNQ29tXzNHX0xpbnV4 X2RyaXZlcl9BcHBsaWNhdGlvbiUyME5vdGVfVjEuMDAucGRmCj4gCj4gVGhhdCBkb2N1bWVudCBw cmVkYXRlcyB0aGUgcW1pLXd3YW4gZHJpdmVyIGluIHRoZSBrZXJuZWwuICBOb3RlIHRoYXQKPiB0 aGlzIGRyaXZlciBoYXMgYW4gSUQgdGFibGUgZW50cnkgZm9yIGludGVyZmFjZSA0IG9mIHRoaXMg ZGV2aWNlLiAgUmlnaHQKPiBub3csIHdoaWNoZXZlciBkcml2ZXIgaXMgcHJvYmVkIGZpcnN0IGNs YWltcyB0aGF0IGludGVyZmFjZS4gIEkgaGF2ZW4ndAo+IGFjdHVhbGx5IHRyaWVkIHVzaW5nIHRo ZSBRTUkgaW50ZXJmYWNlLCB0aG91Z2guCgpJIGRpZG4ndCBzYXkgaXQgd2FzIGNvcnJlY3QsIGp1 c3QgdGhhdCB0aGUgdmVuZG9yIHByb3Bvc2VkIGJpbmRpbmcgdG8gaXQKYW55d2F5LgoKPiA+IEFu ZCB5b3UncmUgc2VlaW5nIGVycm9ycyB3aGVuIG9wZW5pbmcgcG9ydHMgMC0zIGR1ZSB0byB0aGUg RFRSIGNhbGxzCj4gPiB3aGljaCBJIGd1ZXNzIG5vIG9uZSBub3RpY2VkIG9yIGNhcmVkIGFib3V0 IGJlZm9yZT8KPiAKPiBSaWdodCwgc29tZSB1c2Vyc3BhY2UgdG9vbHMgY29tcGxhaW4gYWJvdXQg dGhpcy4KCkhtbS4gWW91IHNob3VsZG4ndCBzZWUgYW55IGVycm9ycyBvbiBvcGVuICh0aGV5J3Jl IG5vdCBldmVuIGxvZ2dlZCksIGJ1dApJIGd1ZXNzIHlvdXIgdXNlciBzcGFjZSB0b29scyBjb21w bGFpbnMgb24gcmVjZWl2aW5nIC1FUFJPVE8gaW5zdGVhZCBvZgotRUlOVkFMIHdoZW4gdHJ5aW5n IHRvIG1hbmFnZSB0aGVzZSBzaWduYWxzIGRpcmVjdGx5PwoKPiA+IEJlZm9yZSB5b3Ugc2VudCBt ZSB0aGUgbHN1c2IgSSBzZWFyY2hlZCBmb3IgaXQgYW5kIGNhbWUgYWNyb3NzIHRoZSBiZWxvdwo+ ID4gdGhyZWFkIHdoZXJlIEJqw7hybidzIGhhdmluZyBhIGdvIGF0IFNJTUNvbS4gSW4gaXQgdGhl cmUncyBvdXRwdXQgZnJvbSBhCj4gPiBzZWNvbmQgZGV2aWNlIHVzaW5nIHRoZSBzYW1lIGlkIGJ1 dCB3aXRoIGVudGlyZWx5IGRpZmZlcmVudCBkZXNjcmlwdG9ycy4KPiA+Cj4gPiAJaHR0cHM6Ly9m b3J1bS5vcGVud3J0Lm9yZy90L2x0ZS13aXJlbGVzcy1tb2R1bGUtc3VwcG9ydC1ieS1vcGVud3J0 LWxlZC1vbi10cGxpbmsvMTM1ODY/cGFnZT0zCj4gPgo+ID4gSWYgdGhpcyBpcyBhIGNvbW1vbiB0 aGVtZSB3aXRoIHRoaXMgdmVuZG9yIHdlIG1heSBuZWVkIHRvIGJlIGV4dHJhCj4gPiBjYXJlZnVs IHdoZW4gbWFraW5nIGNoYW5nZXMuCj4gCj4gSXNuJ3QgdGhpcyBhIGNvbW1vbiB0aGVtZSB3aXRo IG1vc3QgVVNCIHZlbmRvcnMsIGVzcGVjaWFsbHkgd2lyZWxlc3MgdGhpbmdzPwo+IAo+IFJlZ2Fy ZGxlc3MsIHNldHRpbmcgdGhlIE5DVFJMIGZsYWcgc2hvdWxkIGJlIGhhcm1sZXNzLgoKV2VsbCwg dGhlcmUgYXJlIGRldmljZXMgdGhhdCBkZXBlbmQgb24gZ2V0dGluZyB0aGVzZSByZXF1ZXN0cywg YXQgbGVhc3QKZm9yIHRoZSBRTUkgaW50ZXJmYWNlLiBCdXQgd2UgY2FuIGFsd2F5cyByZXZlcnQg aWYgYW55b25lIGNvbXBsYWlucy4KCk5vdyBhcHBsaWVkLCB0aGFua3MuCgpKb2hhbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B35F7C43381 for ; Tue, 19 Mar 2019 10:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7703320989 for ; Tue, 19 Mar 2019 10:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552991331; bh=7uru8hEoahmypSdyu9vk2O13cSiCTDja0FgNEgQYI5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0Apvg49WsznBVIWppgB0Q0uLzYbebt5oDOcD9+JAKfmWW4CNMfQFTc9/BabmURCPH lZ1LTxywRRNPCVYtTX0T2BALbmnXyV+Gt/cbFan4wqQ9P45McjZ33Ws9iwUW5IFk22 MQl9sJIm9CXKrLxKYTSgHqOTpA3d/rlKnLxn1xDM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727388AbfCSK2u (ORCPT ); Tue, 19 Mar 2019 06:28:50 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:45353 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfCSK2t (ORCPT ); Tue, 19 Mar 2019 06:28:49 -0400 Received: by mail-lj1-f196.google.com with SMTP id y6so8586647ljd.12; Tue, 19 Mar 2019 03:28:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tyI6rgnC+UpX8sancHSdmZtqijH+Q9qbvNjNb20gOVI=; b=nixmaBxyfT1n7djg0LLYAUDpjS62z2LxGgamLkZlkcHmbOvDeUC5/YeKG/g0ea5yoL 1w8KzS2CLFR73naXGMeNiV/EJMbyVgb3yM3Ik4TYmxHef+l2Z0YpEnwdk8OmAQyPEPUl DUITOugqObpDdpnCrTAgqKeh2+O8SwSqHCG9tkGAEhme3DkVB92r21SsvLcoda+f/RRj q6cAfncfwiUsw4uLzqYZ+z9kEfS/DgeTgPEggZlh/JvyVTvf15p/cBphVx+e5W+3i7ZJ En6uMF1Jop5LLK+yBnRNR9ly6EHNpFbjPdjb0mIwGIODpR9nDLy8dWdxwW3eputza4bD bB5g== X-Gm-Message-State: APjAAAVgjnUEMUyeofeRNMTV+TwzFWS8l8nN/nf+zgwxqkxe7IZEFNej 5wKinqpoqbGYe3la1/xcc9s= X-Google-Smtp-Source: APXvYqylX9wN06FgrUuSENkAa8joWU0FuvfIBE86jeRduZbY9UTOPhaS36gyC/rBicnU+oZXFLcwJA== X-Received: by 2002:a2e:5b44:: with SMTP id p65mr13515470ljb.182.1552991327510; Tue, 19 Mar 2019 03:28:47 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id t18sm2730737ljg.64.2019.03.19.03.28.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 03:28:46 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1h6Bz6-0007yw-Q5; Tue, 19 Mar 2019 11:28:41 +0100 Date: Tue, 19 Mar 2019 11:28:40 +0100 From: Johan Hovold To: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Johan Hovold , =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: set driver_info for SIM5218 and compatibles Message-ID: <20190319102840.GI6124@localhost> References: <20190226170710.12709-1-mans@mansr.com> <20190227083342.GJ4747@localhost> <20190227131315.GO4747@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 27, 2019 at 02:32:58PM +0000, Måns Rullgård wrote: > Johan Hovold writes: > > > Adding Bjørn. > > > > On Wed, Feb 27, 2019 at 11:57:16AM +0000, Måns Rullgård wrote: > >> Johan Hovold writes: > >> > >> > On Tue, Feb 26, 2019 at 05:07:10PM +0000, Mans Rullgard wrote: > >> >> The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 > >> >> of which are serial ports. The fifth is a network interface supported > >> >> by the qmi-wwan driver. Furthermore, the serial ports do not support > >> >> modem control signals. Add driver_info flags to reflect this. > >> >> > >> >> Signed-off-by: Mans Rullgard > >> >> --- > >> >> drivers/usb/serial/option.c | 3 ++- > >> >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> >> > >> >> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > >> >> index fb544340888b..af4cbfecc3ff 100644 > >> >> --- a/drivers/usb/serial/option.c > >> >> +++ b/drivers/usb/serial/option.c > >> >> @@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = { > >> >> .driver_info = RSVD(3) }, > >> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ > >> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */ > >> >> - { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ > >> >> + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */ > >> >> + .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) }, > >> >> /* Quectel products using Qualcomm vendor ID */ > >> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)}, > >> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20), > >> > > >> > Could you please provide the output of usb-devices (or lsusb -v) for > >> > this device? > >> > >> lsusb -v: > >> [...] > > > So the patch looks fine to me. The fifth interface is QMI, but hasn't > > been available for use until now then, and this seems to have been the > > vendors idea from the start: > > > > http://www.microchip.ua/simcom/WCDMA/APPNOTES/SIMCom_3G_Linux_driver_Application%20Note_V1.00.pdf > > That document predates the qmi-wwan driver in the kernel. Note that > this driver has an ID table entry for interface 4 of this device. Right > now, whichever driver is probed first claims that interface. I haven't > actually tried using the QMI interface, though. I didn't say it was correct, just that the vendor proposed binding to it anyway. > > And you're seeing errors when opening ports 0-3 due to the DTR calls > > which I guess no one noticed or cared about before? > > Right, some userspace tools complain about this. Hmm. You shouldn't see any errors on open (they're not even logged), but I guess your user space tools complains on receiving -EPROTO instead of -EINVAL when trying to manage these signals directly? > > Before you sent me the lsusb I searched for it and came across the below > > thread where Bjørn's having a go at SIMCom. In it there's output from a > > second device using the same id but with entirely different descriptors. > > > > https://forum.openwrt.org/t/lte-wireless-module-support-by-openwrt-led-on-tplink/13586?page=3 > > > > If this is a common theme with this vendor we may need to be extra > > careful when making changes. > > Isn't this a common theme with most USB vendors, especially wireless things? > > Regardless, setting the NCTRL flag should be harmless. Well, there are devices that depend on getting these requests, at least for the QMI interface. But we can always revert if anyone complains. Now applied, thanks. Johan