From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 9/9] drm/i915: Inline skl_build_pipe_wm() into its only caller Date: Tue, 19 Mar 2019 12:49:58 +0200 Message-ID: <20190319104958.GT3888@intel.com> References: <20190312205844.6339-1-ville.syrjala@linux.intel.com> <20190312205844.6339-10-ville.syrjala@linux.intel.com> <20190319001130.GS4773@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3978389A62 for ; Tue, 19 Mar 2019 10:50:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190319001130.GS4773@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMDU6MTE6MzBQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBUdWUsIE1hciAxMiwgMjAxOSBhdCAxMDo1ODo0NFBNICswMjAwLCBWaWxsZSBTeXJq YWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+IAo+ID4gc2tsX2J1aWxkX3BpcGVfd20oKSBpcyBxdWl0ZSBwb2ludGxl c3Mgbm93LiBKdXN0IGlubGluZSBpdCBpbnRvCj4gCj4gSSB0aGluayB5b3UgYWN0dWFsbHkgbWVh biBza2xfdXBkYXRlX3BpcGVfd20oKSwgcmlnaHQ/CgpJbmRlZWQuCgo+IAo+IFRoZSBjb2RlIGNo YW5nZSBsb29rcyBnb29kLCBzbyB3aXRoIGFuIHVwZGF0ZWQgY29tbWl0IG1lc3NhZ2UsCj4gCj4g UmV2aWV3ZWQtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+CgpUaGFu a3MuCgo+IAo+ID4gc2tsX2NvbXB1dGVfd20oKS4KPiA+IAo+ID4gQ2M6IE5lZWwgRGVzYWkgPG5l ZWwuZGVzYWlAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3BtLmMgfCAzMiArKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ID4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+IGluZGV4IDgwZTk2NGY3ZGU1OC4uYWMwY2Ex NTBhMGQ1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gQEAgLTUyNTcsMjMg KzUyNTcsNiBAQCBib29sIHNrbF9kZGJfYWxsb2NhdGlvbl9vdmVybGFwcyhjb25zdCBzdHJ1Y3Qg c2tsX2RkYl9lbnRyeSAqZGRiLAo+ID4gIAlyZXR1cm4gZmFsc2U7Cj4gPiAgfQo+ID4gIAo+ID4g LXN0YXRpYyBpbnQgc2tsX3VwZGF0ZV9waXBlX3dtKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpj c3RhdGUsCj4gPiAtCQkJICAgICAgY29uc3Qgc3RydWN0IHNrbF9waXBlX3dtICpvbGRfcGlwZV93 bSwKPiA+IC0JCQkgICAgICBzdHJ1Y3Qgc2tsX3BpcGVfd20gKnBpcGVfd20sIC8qIG91dCAqLwo+ ID4gLQkJCSAgICAgIGJvb2wgKmNoYW5nZWQgLyogb3V0ICovKQo+ID4gLXsKPiA+IC0Jc3RydWN0 IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKGNzdGF0ZS0+YmFzZS5jcnRjKTsKPiA+ IC0JaW50IHJldDsKPiA+IC0KPiA+IC0JcmV0ID0gc2tsX2J1aWxkX3BpcGVfd20oY3N0YXRlKTsK PiA+IC0JaWYgKHJldCkKPiA+IC0JCXJldHVybiByZXQ7Cj4gPiAtCj4gPiAtCSpjaGFuZ2VkID0g IXNrbF9waXBlX3dtX2VxdWFscyhjcnRjLCBvbGRfcGlwZV93bSwgcGlwZV93bSk7Cj4gPiAtCj4g PiAtCXJldHVybiAwOwo+ID4gLX0KPiA+IC0KPiA+ICBzdGF0aWMgdTMyCj4gPiAgcGlwZXNfbW9k aWZpZWQoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgewo+ID4gQEAgLTU2 MTIsMTAgKzU1OTUsOSBAQCBzdGF0aWMgaW50Cj4gPiAgc2tsX2NvbXB1dGVfd20oc3RydWN0IGlu dGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgewo+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YzsKPiA+IC0Jc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZTsKPiA+ICsJc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlOwo+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0 Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGU7Cj4gPiAgCXN0cnVjdCBza2xfZGRiX3ZhbHVlcyAqcmVz dWx0cyA9ICZzdGF0ZS0+d21fcmVzdWx0czsKPiA+IC0Jc3RydWN0IHNrbF9waXBlX3dtICpwaXBl X3dtOwo+ID4gIAlib29sIGNoYW5nZWQgPSBmYWxzZTsKPiA+ICAJaW50IHJldCwgaTsKPiA+ICAK PiA+IEBAIC01NjMzLDEyICs1NjE1LDggQEAgc2tsX2NvbXB1dGVfd20oc3RydWN0IGludGVsX2F0 b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgCSAqIHBpcGUgYWxsb2NhdGlvbnMgaGFkIHRvIGNoYW5n ZS4KPiA+ICAJICovCj4gPiAgCWZvcl9lYWNoX29sZG5ld19pbnRlbF9jcnRjX2luX3N0YXRlKHN0 YXRlLCBjcnRjLCBvbGRfY3J0Y19zdGF0ZSwKPiA+IC0JCQkJCSAgICBjc3RhdGUsIGkpIHsKPiA+ IC0JCWNvbnN0IHN0cnVjdCBza2xfcGlwZV93bSAqb2xkX3BpcGVfd20gPQo+ID4gLQkJCSZvbGRf Y3J0Y19zdGF0ZS0+d20uc2tsLm9wdGltYWw7Cj4gPiAtCj4gPiAtCQlwaXBlX3dtID0gJmNzdGF0 ZS0+d20uc2tsLm9wdGltYWw7Cj4gPiAtCQlyZXQgPSBza2xfdXBkYXRlX3BpcGVfd20oY3N0YXRl LCBvbGRfcGlwZV93bSwgcGlwZV93bSwgJmNoYW5nZWQpOwo+ID4gKwkJCQkJICAgIG5ld19jcnRj X3N0YXRlLCBpKSB7Cj4gPiArCQlyZXQgPSBza2xfYnVpbGRfcGlwZV93bShuZXdfY3J0Y19zdGF0 ZSk7Cj4gPiAgCQlpZiAocmV0KQo+ID4gIAkJCXJldHVybiByZXQ7Cj4gPiAgCj4gPiBAQCAtNTY0 Niw3ICs1NjI0LDkgQEAgc2tsX2NvbXB1dGVfd20oc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAq c3RhdGUpCj4gPiAgCQlpZiAocmV0KQo+ID4gIAkJCXJldHVybiByZXQ7Cj4gPiAgCj4gPiAtCQlp ZiAoY2hhbmdlZCkKPiA+ICsJCWlmICghc2tsX3BpcGVfd21fZXF1YWxzKGNydGMsCj4gPiArCQkJ CQkmb2xkX2NydGNfc3RhdGUtPndtLnNrbC5vcHRpbWFsLAo+ID4gKwkJCQkJJm5ld19jcnRjX3N0 YXRlLT53bS5za2wub3B0aW1hbCkpCj4gPiAgCQkJcmVzdWx0cy0+ZGlydHlfcGlwZXMgfD0gZHJt X2NydGNfbWFzaygmY3J0Yy0+YmFzZSk7Cj4gPiAgCX0KPiA+ICAKPiA+IC0tIAo+ID4gMi4xOS4y Cj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo+IAo+IC0tIAo+IE1hdHQgUm9wZXIKPiBHcmFwaGljcyBTb2Z0d2FyZSBFbmdp bmVlcgo+IElvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudAo+IEludGVsIENvcnBv cmF0aW9uCj4gKDkxNikgMzU2LTI3OTUKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4