From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/icl: pass cfgcr* register around instead of pll_id Date: Tue, 19 Mar 2019 13:09:33 +0200 Message-ID: <20190319110932.GV3888@intel.com> References: <20190316004526.12065-1-lucas.demarchi@intel.com> <20190318133152.GJ3888@intel.com> <20190318184034.eqpjpyxupafrbx57@ldmartin-desk.amr.corp.intel.com> <20190318185323.GR3888@intel.com> <20190318233351.id43zijcgtlkdjoc@ldmartin-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43DC289A77 for ; Tue, 19 Mar 2019 11:09:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190318233351.id43zijcgtlkdjoc@ldmartin-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMDQ6MzM6NTFQTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IE9uIE1vbiwgTWFyIDE4LCAyMDE5IGF0IDA4OjUzOjIzUE0gKzAyMDAsIFZpbGxl IFN5cmrDpGzDpCB3cm90ZToKPiA+T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMTE6NDA6MzRBTSAt MDcwMCwgTHVjYXMgRGUgTWFyY2hpIHdyb3RlOgo+ID4+IE9uIE1vbiwgTWFyIDE4LCAyMDE5IGF0 IDAzOjMxOjUyUE0gKzAyMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+PiA+T24gRnJpLCBN YXIgMTUsIDIwMTkgYXQgMDU6NDU6MjZQTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hpIHdyb3RlOgo+ ID4+ID4+IFRoZSBjYWxsZXIgYWxyZWFkeSBrbm93cyB3aGF0IHBsYXRmb3JtIHRoYXQgaXMgYW5k IHdoYXQgcmVnaXN0ZXIgc2hvdWxkCj4gPj4gPj4gYmUgdXNlZC4gSW5zdGVhZCBvZiBrZWVwIGFk ZGluZyBpZi9lbHNlIGNoYWlucyBvbiBhIGxlYWYgZnVuY3Rpb25zLAo+ID4+ID4+IGxldCB0aGUg Y2FsbGVyIHBhc3MgdGhlIHJlZ2lzdGVyLgo+ID4+ID4+Cj4gPj4gPj4gV2UgcmVhZCBjZmdjcjAg dHdpY2UgZm9yIENOTCwgYnV0IHdlIHdlcmUgYWxyZWFkeSBkb2luZyB0aGF0IGFueXdheS4KPiA+ PiA+Pgo+ID4+ID4+IGljbF9jYWxjX2RwX2NvbWJvX3BsbF9saW5rKCkgaXMgb25seSB1c2VkIGZv ciBJQ0wsIGJ1dCBsZXQncyBrZWVwCj4gPj4gPj4gY29uc2lzdGVuY3kgd2l0aCBjbmxfY2FsY193 cnBsbF9saW5rKCkuCj4gPj4gPj4KPiA+PiA+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJj aGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiA+PiA+PiAtLS0KPiA+PiA+PiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jICAgICAgICB8ICA0ICsrKy0KPiA+PiA+PiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgICAgICB8IDI1ICsrKysrKysrKysrKysrLS0tLS0t LS0tLS0KPiA+PiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyB8ICA2 ICsrKy0tLQo+ID4+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oIHwg IDIgKy0KPiA+PiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgICB8ICAy ICstCj4gPj4gPj4gIDUgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRp b25zKC0pCj4gPj4gPj4KPiA+PiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aWNsX2RzaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jCj4gPj4gPj4gaW5kZXgg YmViMzBkOWE4NTVjLi4yOGY1ZGE2OTc2OTMgMTAwNjQ0Cj4gPj4gPj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaWNsX2RzaS5jCj4gPj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aWNsX2RzaS5jCj4gPj4gPj4gQEAgLTExODMsNyArMTE4Myw5IEBAIHN0YXRpYyB2b2lkIGdlbjEx X2RzaV9nZXRfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4+ID4+Cj4g Pj4gPj4gIAkvKiBGSVhNRTogYWRhcHQgaWNsX2RkaV9jbG9ja19nZXQoKSBmb3IgRFNJIGFuZCB1 c2UgdGhhdD8gKi8KPiA+PiA+PiAgCXBsbF9pZCA9IGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChk ZXZfcHJpdiwgcGlwZV9jb25maWctPnNoYXJlZF9kcGxsKTsKPiA+PiA+PiAtCXBpcGVfY29uZmln LT5wb3J0X2Nsb2NrID0gY25sX2NhbGNfd3JwbGxfbGluayhkZXZfcHJpdiwgcGxsX2lkKTsKPiA+ PiA+PiArCXBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrID0gY25sX2NhbGNfd3JwbGxfbGluayhkZXZf cHJpdiwKPiA+PiA+PiArCQkJCQkJICAgICAgSUNMX0RQTExfQ0ZHQ1IwKHBsbF9pZCksCj4gPj4g Pj4gKwkJCQkJCSAgICAgIElDTF9EUExMX0NGR0NSMShwbGxfaWQpKTsKPiA+PiA+PiAgCXBpcGVf Y29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19jbG9jayA9IGludGVsX2RzaS0+cGNsazsK PiA+PiA+PiAgCXBpcGVfY29uZmlnLT5vdXRwdXRfdHlwZXMgfD0gQklUKElOVEVMX09VVFBVVF9E U0kpOwo+ID4+ID4+ICB9Cj4gPj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+PiA+PiBp bmRleCA2OWFhMGQxNDg3OTUuLjI0Njc1ZWY4YjI2MiAxMDA2NDQKPiA+PiA+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RkaS5jCj4gPj4gPj4gQEAgLTEzMDQsMTggKzEzMDQsMTMgQEAgc3RhdGlj IGludCBza2xfY2FsY193cnBsbF9saW5rKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiA+PiA+PiAgfQo+ID4+ID4+Cj4gPj4gPj4gIGludCBjbmxfY2FsY193cnBsbF9saW5rKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+PiA+PiAtCQkJZW51bSBpbnRlbF9k cGxsX2lkIHBsbF9pZCkKPiA+PiA+PiArCQkJaTkxNV9yZWdfdCBjZmdjcjBfcmVnLCBpOTE1X3Jl Z190IGNmZ2NyMV9yZWcpCj4gPj4gPj4gIHsKPiA+PiA+PiAgCXUzMiBjZmdjcjAsIGNmZ2NyMTsK PiA+PiA+PiAgCXUzMiBwMCwgcDEsIHAyLCBkY29fZnJlcSwgcmVmX2Nsb2NrOwo+ID4+ID4+Cj4g Pj4gPj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkgewo+ID4+ID4+IC0JCWNmZ2Ny MCA9IEk5MTVfUkVBRChJQ0xfRFBMTF9DRkdDUjAocGxsX2lkKSk7Cj4gPj4gPj4gLQkJY2ZnY3Ix ID0gSTkxNV9SRUFEKElDTF9EUExMX0NGR0NSMShwbGxfaWQpKTsKPiA+PiA+PiAtCX0gZWxzZSB7 Cj4gPj4gPj4gLQkJY2ZnY3IwID0gSTkxNV9SRUFEKENOTF9EUExMX0NGR0NSMChwbGxfaWQpKTsK PiA+PiA+PiAtCQljZmdjcjEgPSBJOTE1X1JFQUQoQ05MX0RQTExfQ0ZHQ1IxKHBsbF9pZCkpOwo+ ID4+ID4+IC0JfQo+ID4+ID4+ICsJY2ZnY3IwID0gSTkxNV9SRUFEKGNmZ2NyMF9yZWcpOwo+ID4+ ID4+ICsJY2ZnY3IxID0gSTkxNV9SRUFEKGNmZ2NyMV9yZWcpOwo+ID4+ID4KPiA+PiA+RG9uJ3Qg d2UgYWxyZWR5IGhhdmUgdGhlIGRwbGwgc3RhdGUgcmVhZCBvdXQgYXQgdGhpcyBwb2ludD8KPiA+ Pgo+ID4+IG5vcHMuCj4gPgo+ID5XZSBtdXN0IGhhdmUgaXQgc2luY2UgYnh0IGlzIGFscmVhZHkg dXNpbmcgaXQuIEVpdGhlciB0aGF0IG9yIGJ4dCBpcwo+ID5icm9rZW4uCj4gCj4gb2guLiBJIHRo aW5rIHlvdSBmb3Jnb3QgdG8gcHVzaAo+IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9y Zy9zZXJpZXMvNTYzNTQvCgpBaCB5ZXMuIE5vdyBwdXNoZWQuIFRoYW5rcyBmb3IgcmV2aWV3aW5n IGl0LgoKPiAKPiBJIGd1ZXNzIGl0IHdpbGwgYWxzbyBtYWtlIG15IGxpZmUgZWFzaWVyIGhlcmUu Cj4gCj4gTHVjYXMgRGUgTWFyY2hpCj4gCj4gPgo+ID4tLSAKPiA+VmlsbGUgU3lyasOkbMOkCj4g PkludGVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeA==