From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Handle YUV subpixel support better Date: Tue, 19 Mar 2019 14:45:27 +0200 Message-ID: <20190319124527.GY3888@intel.com> References: <20190318140718.1619-1-maarten.lankhorst@linux.intel.com> <20190318141841.GM3888@intel.com> <9b536bc0-8be3-1080-45da-fa57615309ac@linux.intel.com> <20190318181550.GP3888@intel.com> <20190319111555.GW3888@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28A1B899C7 for ; Tue, 19 Mar 2019 12:45:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190319111555.GW3888@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMTksIDIwMTkgYXQgMDE6MTU6NTVQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgTWFyIDE5LCAyMDE5IGF0IDA4OjI4OjU4QU0gKzAxMDAsIE1hYXJ0 ZW4gTGFua2hvcnN0IHdyb3RlOgo+ID4gT3AgMTgtMDMtMjAxOSBvbSAxOToxNSBzY2hyZWVmIFZp bGxlIFN5cmrDpGzDpDoKPiA+ID4gT24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMDQ6MTM6NTdQTSAr MDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPiA+PiBPcCAxOC0wMy0yMDE5IG9tIDE1 OjE4IHNjaHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+ID4gPj4+IE9uIE1vbiwgTWFyIDE4LCAyMDE5 IGF0IDAzOjA3OjE4UE0gKzAxMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ID4gPj4+PiBT aWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgo+ID4gPj4+PiAtLS0KPiA+ID4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3Nwcml0ZS5jIHwgMjkgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiA+ID4+Pj4g IDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiA+ID4+ Pj4KPiA+ID4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0 ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+ID4+Pj4gaW5kZXgg MjY4ZmIzNGZmMGUyLi44NjJmYzE3MjA0MmYgMTAwNjQ0Cj4gPiA+Pj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiA+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiA+Pj4+IEBAIC0yNjksNyArMjY5LDggQEAgaW50IGlu dGVsX3BsYW5lX2NoZWNrX3NyY19jb29yZGluYXRlcyhzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUg KnBsYW5lX3N0YXRlKQo+ID4gPj4+PiAgewo+ID4gPj4+PiAgCWNvbnN0IHN0cnVjdCBkcm1fZnJh bWVidWZmZXIgKmZiID0gcGxhbmVfc3RhdGUtPmJhc2UuZmI7Cj4gPiA+Pj4+ICAJc3RydWN0IGRy bV9yZWN0ICpzcmMgPSAmcGxhbmVfc3RhdGUtPmJhc2Uuc3JjOwo+ID4gPj4+PiAtCXUzMiBzcmNf eCwgc3JjX3ksIHNyY193LCBzcmNfaDsKPiA+ID4+Pj4gKwl1MzIgc3JjX3gsIHNyY195LCBzcmNf dywgc3JjX2gsIGhzdWIsIHZzdWI7Cj4gPiA+Pj4+ICsJYm9vbCByb3RhdGVkID0gZHJtX3JvdGF0 aW9uXzkwX29yXzI3MChwbGFuZV9zdGF0ZS0+YmFzZS5yb3RhdGlvbik7Cj4gPiA+Pj4+ICAKPiA+ ID4+Pj4gIAkvKgo+ID4gPj4+PiAgCSAqIEhhcmR3YXJlIGRvZXNuJ3QgaGFuZGxlIHN1YnBpeGVs IGNvb3JkaW5hdGVzLgo+ID4gPj4+PiBAQCAtMjg3LDE4ICsyODgsMjYgQEAgaW50IGludGVsX3Bs YW5lX2NoZWNrX3NyY19jb29yZGluYXRlcyhzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5l X3N0YXRlKQo+ID4gPj4+PiAgCXNyYy0+eTEgPSBzcmNfeSA8PCAxNjsKPiA+ID4+Pj4gIAlzcmMt PnkyID0gKHNyY195ICsgc3JjX2gpIDw8IDE2Owo+ID4gPj4+PiAgCj4gPiA+Pj4+IC0JaWYgKGZi LT5mb3JtYXQtPmlzX3l1diAmJgo+ID4gPj4+PiAtCSAgICAoc3JjX3ggJiAxIHx8IHNyY193ICYg MSkpIHsKPiA+ID4+Pj4gLQkJRFJNX0RFQlVHX0tNUygic3JjIHgvdyAoJXUsICV1KSBtdXN0IGJl IGEgbXVsdGlwbGUgb2YgMiBmb3IgWVVWIHBsYW5lc1xuIiwKPiA+ID4+Pj4gLQkJCSAgICAgIHNy Y194LCBzcmNfdyk7Cj4gPiA+Pj4+ICsJaWYgKCFmYi0+Zm9ybWF0LT5pc195dXYpCj4gPiA+Pj4+ ICsJCXJldHVybiAwOwo+ID4gPj4+PiArCj4gPiA+Pj4+ICsJLyogWVVWIHNwZWNpZmljIGNoZWNr cyAqLwo+ID4gPj4+PiArCWlmICghcm90YXRlZCkgewo+ID4gPj4+PiArCQloc3ViID0gZmItPmZv cm1hdC0+aHN1YjsKPiA+ID4+Pj4gKwkJdnN1YiA9IGZiLT5mb3JtYXQtPnZzdWI7Cj4gPiA+Pj4+ ICsJfSBlbHNlIHsKPiA+ID4+Pj4gKwkJaHN1YiA9IHZzdWIgPSBtYXgoZmItPmZvcm1hdC0+aHN1 YiwgZmItPmZvcm1hdC0+dnN1Yik7Cj4gPiA+Pj4gV2h5IHRoaXM/IEZyb20gdGhlIGxvb2tzIG9m IHRoaW5ncyB0aGVyZSBzaG91bGQgYmUgbm8gbmVlZCB0byBkZWFsIHdpdGgKPiA+ID4+PiByb3Rh dGlvbiBpbiB0aGlzIGZ1bmN0aW9uIGF0IGFsbC4KPiA+ID4+IEkgd3JvdGUgYSBkdW1iIHRlc3Qg dGhhdCBmYWlscyBpZiBJIHJvdGF0ZSBZVVlWLgo+ID4gPj4KPiA+ID4+IGh0dHBzOi8vcGF0Y2h3 b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC8yODYxNzAvCj4gPiA+Pgo+ID4gPj4gQ29ycnVwdGVk IGltYWdlOgo+ID4gPj4KPiA+ID4+IChrbXNfeXV2OjExNTUpIGlndF9rbXMtREVCVUc6IGRpc3Bs YXk6IEEuMDogcGxhbmVfc2V0X3JvdGF0aW9uKDkwwrApCj4gPiA+PiAoa21zX3l1djoxMTU1KSBp Z3Rfa21zLURFQlVHOiBkaXNwbGF5OiBBLjA6IHNyY19zZXRfcG9zaXRpb24oMTgsMzMpCj4gPiA+ PiAoa21zX3l1djoxMTU1KSBpZ3Rfa21zLURFQlVHOiBkaXNwbGF5OiBBLjA6IHNyY19zZXRfc2l6 ZSg0NHg2NSkKPiA+ID4+IChrbXNfeXV2OjExNTUpIGlndF9rbXMtREVCVUc6IGRpc3BsYXk6IEEu MDogcGxhbmVfc2V0X3Bvc2l0aW9uKDY0LDY0KQo+ID4gPj4gKGttc195dXY6MTE1NSkgaWd0X2tt cy1ERUJVRzogZGlzcGxheTogQS4wOiBwbGFuZV9zZXRfc2l6ZSAoMjU2eDI1NikKPiA+ID4+Cj4g PiA+PiBJIGhhZCBhIDgweDEyOCBmYiwgb25seSBzaG93aW5nIHRoZSBjZW50ZXIgcGFydCB3aGlj aCBzaG91bGQgYmUgd2hpdGUsIHdpdGggYSBibGFjayBib3JkZXIgYXJvdW5kIGl0IHRvIGNhdXNl IENSQyBlcnJvcnMgaWYgd2UgbWVzcyB1cCBjbGlwcGluZy4KPiA+ID4+Cj4gPiA+PiBUaGUgc2Nh bGluZyB3b3JrcyBmaW5lLCBidXQgdGhlIGNsaXBwaW5nIGRvZXMgbm90IGluIHRoaXMgY2FzZS4g SSBhbSBnZXR0aW5nIGEgY29ycnVwdGVkIHBsYW5lIG9uIHNjcmVlbiB3aGljaCBpcyBtb3N0bHkg d2hpdGUsIGJ1dCB3aXRoIGJsYWNrIGRvdHMgaW4gZWFjaCB0aWxlLgo+ID4gPj4KPiA+ID4+IFNj YWxpbmcganVzdCBtYWduaWZpZXMgdGhpcyBjb3JydXB0aW9uLiA6KQo+ID4gPiBIbW0uIEkganVz dCBwb2tlZCBteSBLQkwgYSBiaXQgYW5kIGl0IGlzIGFsc28gc2hvd2luZyBjdXJpb3VzCj4gPiA+ IGJlaGF2aW91ci4gRXZlbiB3aXRoIDkwLzI3MCByb3RhdGlvbiBpdCBpcyBpbiBmYWN0IHRoZSBU SUxFT0ZGCj4gPiA+IFggY29vcmRpbmF0ZSB0aGF0IG5lZWRzIHRvIGJlIGV2ZW4gKGFjdHVhbGx5 IHRoZSBodyBqdXN0IGFwcGVhcnMKPiA+ID4gdG8gaWdub3JlIHRoZSBsc2IpLiBJIGNhbiBtYWtl IHRoZSBZIGNvb3JkaW5hdGUgb2RkLCBhbmQgdGhlIGltYWdlCj4gPiA+IHN0aWxsIGxvb2tzIGNv cnJlY3QgdG8gbXkgZXllcy4gU28gZmVlbHMgbGlrZSBzb21lb25lIGZvcmdvdCB0bwo+ID4gPiB0 byByZW1vdmUgYSAoeCZ+MSkgZnJvbSB0aGUgaHcgd2hlbiB0aGV5IGFkZGVkIHRoZSA5MC8yNzAg cm90YXRpb24sCj4gPiA+IGFuZCB5ZXQgdGhleSB3ZW50IHRvIHRoZSB0cm91YmxlIG9mIG1ha2lu ZyBvZGQgWSBjb29yZGluYXRlcyB3b3JrCj4gPiA+IGNvcnJlY3RseS4gUXVpdGUgc3RhbmdlLgo+ ID4gPgo+ID4gPiBXaWR0aC9oZWlnaHQgYmVpbmcgb2RkIHNlZW1zIHRvIGhhbmRsZWQganVzdCBm aW5lIGJ5IHRoZSBody4KPiA+ID4KPiA+IEhtbSBkb2VzIHRoYXQgbWVhbiB3ZSBzaG91bGQga2Vl cCB0aGUgb3JpZ2luYWwgY2hlY2tzIGluIHBsYWNlIHdoaWxlIGNoZWNraW5nIGZvcm1hdC0+aC92 c3ViLCBhbmQgb24gdG9wIHJlamVjdCB0aGUgdW5yb3RhdGVkIFkgY29vcmRpbmF0ZSBiZWluZyBh IG11bHRpcGxlIG9mIGhzdWIgd2hlbiByb3RhdGluZz8KPiAKPiBOb3QgcXVpdGUgc3VyZS4gQmFz ZWQgb24gd2hhdCBJIHNlZSB3ZSBjb3VsZCBhY3R1YWxseSBqdXN0IHN3YXAgdGhlCj4gY29vcmRp bmF0ZXMgKG9yIGRvIHRoZSBjaGVjayBhZnRlciB0aGUgY29vcmRpbmF0ZXMgYXJlIGFscmVhZHkg cm90YXRlZCkKPiBhbmQgaXQgc2hvdWxkIHN0aWxsIHdvcmsuIEJ1dCBJIGRpZG4ndCBjaGVjayBp ZiB0aGF0IHdvdWxkIHN0aWxsIHdvcmsKPiB3aGVuIHRoZSBzY2FsZXIgaXMgaW52b2x2ZWQuCgpI bW0uIFRoZSBzcGVjIGRpc2FncmVlcyB3aXRoIHRoaXMgb2JzZXJ2ZWQgYmVoYXZpb3VyIG9mIFBM QU5FX09GRlNFVC4KSXQgY2xhaW1zIG91ciBjdXJyZW50IGNvZGUgc2hvdWxkIGJlIGZpbmUuCgpQ TEFORV9TSVpFIGFsc28gaGFzIHRoaXMgc2xpZ2h0bHkgY29uZnVzaW5nIHRhYmxlIGZvciBHTEsr OgpQaXhlbEZvcm1hdAkJUm90YXRlCQlXaWR0aAlIZWlnaHQKWVVWIDQyMCBQbGFuYXIgLSBOVjEy CUFsbAkJRXZlbglFdmVuCllVViA0MjAgUGxhbmFyIC0gUDAxeAlBbGwJCUV2ZW4JRXZlbgpZVVYg NDIyIAkJQWxsIAkJRXZlbglFdmVuClJHQjU2NQkJCTkwLCAyNzAJCUV2ZW4JRXZlbgoKd2hpY2gg cHJldHR5IG11Y2ggbWF0Y2hlcyB0aGUgdy9oIHBhcnQgb2YgeW91ciBwYXRjaC4KCi0tIApWaWxs ZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4