From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [ltp][PATCH v3] Add ltp pivot_root test
Date: Tue, 19 Mar 2019 16:45:12 +0100 [thread overview]
Message-ID: <20190319154512.GA13486@rei.lan> (raw)
In-Reply-To: <20190319091136.GC26794@dell5510>
Hi!
> > +#else
> > +static void run(void)
> > +{
> > + tst_brk(TCONF, NULL, "unshare is undefined.");
> Here NULL is copy paste error (that cleanup parameter is from legacy API, here
> suppress the message).
> We use TST_TEST_TCONF for cases like this.
> + Please guard everything, otherwise we get "defined but not used".
That is what I was going to suggest guard the whole test into #ifdef for
libcap and unshare, there is no point in doing anything else if the test
cannot run without these.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-03-19 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 18:44 [LTP] [ltp][PATCH v3] Add ltp pivot_root test Paul Lawrence
2019-03-05 21:59 ` Matthias Maennich
2019-03-19 9:11 ` Petr Vorel
2019-03-19 15:45 ` Cyril Hrubis [this message]
2019-03-19 15:55 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319154512.GA13486@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.