From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: Potential NULL pointer dereference in
 intel_crt_get_edid
Date: Tue, 19 Mar 2019 10:12:54 -0700
Message-ID: <20190319171254.GE27875@intel.com>
References: <3c286170-5ac2-5599-bd78-3e70f0040cbc@cs.utah.edu>
 <20190318232631.GA27875@intel.com>
 <cd5c2a23-6750-0298-d71c-efaa655afd7d@cs.utah.edu>
 <20190318235308.GB27875@intel.com>
 <034acd15-aa17-8881-0a33-7e6a0f01f202@cs.utah.edu>
 <87wokvfenz.fsf@intel.com>
 <aadc7424-cb20-7ed7-cbd5-4fc9a055feac@cs.utah.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C237E89B51
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Mar 2019 17:12:40 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <aadc7424-cb20-7ed7-cbd5-4fc9a055feac@cs.utah.edu>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Shaobo He <shaobo@cs.utah.edu>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBNYXIgMTksIDIwMTkgYXQgMTA6NTM6NTNBTSAtMDYwMCwgU2hhb2JvIEhlIHdyb3Rl
Ogo+IFRoYW5rIHlvdSB2ZXJ5IG11Y2ggZm9yIHlvdXIgcmVwbHkuIERvIHlvdSBtZWFuIGlmIEkg
dHJhY2sgdGhlIGFyZ3VtZW50IHRvCj4gdGhlIGNhbGxlcnMsIEkgc2hvdWxkIGJlIGFibGUgdG8g
ZmlndXJlIG91dCB0aGF0IHRoZSBwaW4gaXMgYWx3YXlzIHZhbGlkPyBJCj4gdGhpbmsgSSBoYXZl
IHR3byBxdWVzdGlvbnMgZm9yIHRoaXMgYXBwcm9hY2guIEZpcnN0LCBkb2VzIGl0IG1lYW4gdGhh
dCB0aGUKPiBicmFuY2ggcmV0dXJuaW5nIE5VTEwgaXMgcHJhY3RpY2FsbHkgZGVhZCBjb2RlPwoK
WWVzLCB0aGF0J3MgdGhlIGNhc2UuCgpPbmx5IHBvc3NpYmlsaXR5IHRoYXQgd2UgY291bGQgcmVh
Y2ggdGhhdCBpcyBpZiB3aGVuIHdlIGFyZSBhZGRpbmcKYSBuZXcgcGxhdGZvcm0gYnV0IHdlIG1h
a2Ugc29tZSBtaXN0YWtlIG9uIGRlZmluaW5nIHRoZSBwaW4gdGFibGUuCnNvIGl0IGlzIHRoZXJl
IGp1c3QgaW4gY2FzZS4KCj4gU2Vjb25kLCB0aGUgZHJpdmVyIGNvZGUsIGFzCj4gaXQgYXBwZWFy
cyB0byBtZSwgZG9lcyBub3QgaGF2ZSB3ZWxsLWRlZmluZWQgZW50cnkgcG9pbnRzIGxpa2UgdGhl
IG1haW4KPiBmdW5jdGlvbi4KCndlbGNvbWUhIDopCgppdCBpcyBjb21wbGV4IGluZGVlZC4gSXQg
aGFzIHRoZSBwcm9iZSBhbmQgZW50cnkgcG9pbnRzIHdvdWxkIGJlIHRoZSBpb2N0bHMsCmludGVy
cnVwcywgc3lzZnMsIGRlYnVnZnMsIGV0Yy4uLgoKbXkgc3VnZ2VzdGlvbiBpcyB0byB1c2Ugc29t
ZXRoaW5nIGxpa2UgY3Njb3BlL2N0YWdzIHRvIG5hdmlnYXRlIGFuZCB0cnkgdG8KbWFrZSBzb21l
IHNlbnNlIG9mIHRoZSBmdW5jdGlvbnMgYXJvdW5kIHRoYXQgcGFydGljdWxhciBjb2RlIHlvdSBh
cmUgbG9va2luZyBhdC4KCj4gU28gaWYgSSBtYW5hZ2UgdG8gdHJhY2sgdGhlIGFyZ3VtZW50cyB0
byBhIGZ1bmN0aW9uIHdob3NlIGNhbGxlcgo+IGlzIG5vdCBleHBsaWNpdCAoZS5nLiwgaXQncyBh
ZGRyZXNzIGlzIHRha2VuIGluIGEgc3RydWN0dXJlKSwgc2hvdWxkIEkgc3RpbGwKPiBhc3N1bWUg
dGhhdCB0aGUgcGluIGlzIHZhbGlkIHdoZW4gdGhpcyBmdW5jdGlvbiBpcyB1c2VkPwoKb24gdGhp
cyBwYXJ0aWN1bGFyIGNhc2UgeWVzLiBpbiBnZW5lcmFsLCB1c2UgdGhlIGNzY29wZSBvbiB0aGUg
dmZ1bmMgY2FsbCB0byBzZWUKd2hlbiBpdCBnZXRzIGNhbGxlZC4uLgoKPiAKPiBUaGFua3MsCj4g
U2hhb2JvCj4gT24gMjAxOS8zLzE5IDI6MzIsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4gT24gTW9u
LCAxOCBNYXIgMjAxOSwgU2hhb2JvIEhlIDxzaGFvYm9AY3MudXRhaC5lZHU+IHdyb3RlOgo+ID4g
PiBJIHNlZS4gSW4gbGlnaHQgb2YgdGhpcyBjb21taXQsIGlzIGl0IGEgYmV0dGVyIHNvbHV0aW9u
IHRoYW4gYWRkaW5nIE5VTEwtY2hlY2tzCj4gPiA+IGlzIHRvIHJlcGxhY2UgdGhlIGlmIGJyYW5j
aCBjb25kaXRpb25lZCBieSBgV0FSTl9PTmAgd2l0aCBzaW1wbHkgYFdBUk5gIGxpa2UgdGhlCj4g
PiA+IGZvbGxvd2luZywKPiA+ID4gCj4gPiA+IHN0cnVjdCBpMmNfYWRhcHRlciAqaW50ZWxfZ21i
dXNfZ2V0X2FkYXB0ZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiAJ
CQkJCSAgICB1bnNpZ25lZCBpbnQgcGluKQo+ID4gPiB7Cj4gPiA+IAlXQVJOKCFpbnRlbF9nbWJ1
c19pc192YWxpZF9waW4oZGV2X3ByaXYsIHBpbiksICJJbnZhbGlkIHBpbjogJWRcbiIsIHBpbik7
Cj4gPiA+IAo+ID4gPiAJcmV0dXJuICZkZXZfcHJpdi0+Z21idXNbcGluXS5hZGFwdGVyOwo+ID4g
PiB9Cj4gPiAKPiA+IFNvIGFsbCBvZiB0aGlzIGRpc2N1c3Npb24gaXMgaHlwb3RoZXRpY2FsIGlu
IHRoZSBzZW5zZSB0aGF0IGl0IHJlYWxseQo+ID4gc2hvdWxkIG5ldmVyIGhhcHBlbi4gWW91IGNh
biB0cmFjayBkb3duIHRoZSBhcmdzIHBhc3NlZCB0bwo+ID4gaW50ZWxfZ21idXNfZ2V0X2FkYXB0
ZXIoKSwgd2hpbGUgdGhlIHN0YXRpYyBhbmFseXplciBpcyB1bmFibGUgdG8gZG8KPiA+IHRoYXQu
Cj4gPiAKPiA+IEJSLAo+ID4gSmFuaS4KPiA+IAo+ID4gCj4gPiA+IAo+ID4gPiBTaGFvYm8KPiA+
ID4gT24gMy8xOC8xOSA1OjUzIFBNLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4gPiA+ID4gT24gTW9u
LCBNYXIgMTgsIDIwMTkgYXQgMDU6Mzk6NDhQTSAtMDYwMCwgU2hhb2JvIEhlIHdyb3RlOgo+ID4g
PiA+ID4gSGkgUm9kcmlnbywKPiA+ID4gPiA+IAo+ID4gPiA+ID4gU29ycnkgSSdtIGEgYml0IGxv
c3QgaGVyZS4gTWF5IEkgYXNrIHdoZXJlIHRoZSBgV0FSTmAgaXM/Cj4gPiA+ID4gCj4gPiA+ID4g
YWxvbmcgd2l0aCB0aGUgcmV0dXJuIE5VTEwKPiA+ID4gPiAKPiA+ID4gPiBzdHJ1Y3QgaTJjX2Fk
YXB0ZXIgKmludGVsX2dtYnVzX2dldF9hZGFwdGUoKQo+ID4gPiA+ICAgICBpZiAoV0FSTl9PTigh
aW50ZWxfZ21idXNfaXNfdmFsaWRfcGluKGRldl9wcml2LCBwaW4pKSkKPiA+ID4gPiAgICAgICAg
ICAgICAgICAgICByZXR1cm4gTlVMTDsKPiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhh
bmtzLAo+ID4gPiA+ID4gU2hhb2JvCj4gPiA+ID4gPiBPbiAzLzE4LzE5IDU6MjYgUE0sIFJvZHJp
Z28gVml2aSB3cm90ZToKPiA+ID4gPiA+ID4gSGkgU2hhb2JvLAo+ID4gPiA+ID4gPiAKPiA+ID4g
PiA+ID4gbiBNb24sIE1hciAxOCwgMjAxOSBhdCAwNTowMToxMFBNIC0wNjAwLCBTaGFvYm8gSGUg
d3JvdGU6Cj4gPiA+ID4gPiA+ID4gSGVsbG8gZXZlcnlvbmUsCj4gPiA+ID4gPiA+ID4gCj4gPiA+
ID4gPiA+ID4gTXkgbmFtZSBpcyBTaGFvYm8gSGUgYW5kIEkgYW0gYSBncmFkdWF0ZSBzdHVkZW50
IGF0IFVuaXZlcnNpdHkgb2YgVXRhaC4gSSBhbQo+ID4gPiA+ID4gPiA+IHVzaW5nIGEgc3RhdGlj
IGFuYWx5c2lzIHRvb2wgdG8gc2VhcmNoIGZvciBudWxsIHBvaW50ZXIgZGVyZWZlcmVuY2VzIGFu
ZAo+ID4gPiA+ID4gPiA+IGNhbWUgYWNyb3NzIGEgcG90ZW50aWFsbHkgaW52YWxpZCBtZW1vcnkg
YWNjZXNzIGluIHRoZSBmaWxlCj4gPiA+ID4gPiA+ID4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfY3J0LmM6IGluIGZ1bmN0aW9uIGBpbnRlbF9jcnRfZGV0ZWN0X2RkY2AsCj4gPiA+ID4gPiA+
ID4gZnVuY3Rpb24gYGludGVsX2dtYnVzX2dldF9hZGFwdGVyYCBjYW4gcmV0dXJuIGEgTlVMTCBw
b2ludGVyIHdoaWNoIGlzCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBpZiB0aGlzIGhhcHBlbnMg
d2UndmUgZG9uZSBhIHRlcnJpYmxlIGpvYiBvbiBkZWZpbmluZyB0aGUgcGxhdGZvcm0uLi4KPiA+
ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gZGVyZWZlcmVuY2VkIGJ5IHRoZSBjYWxsIHRvIGBkcm1f
Z2V0X2VkaWRgIG9yIGBpbnRlbF9nbWJ1c19pc19mb3JjZWRfYml0YC4KPiA+ID4gPiA+ID4gCj4g
PiA+ID4gPiA+IGJ1dCBpdCBzZWVtcyB5b3UgYXJlIHJpZ2h0Li4uIHRoaXMgd2lsbCByZWFjaCBp
MmNfdHJhbnNmZXIgaW4gdGhlIGVuZAo+ID4gPiA+ID4gPiBhbmQgaXQgd2lsbCBicmVhayBldmVy
eXRoaW5nIGFmdGVyIHdlIGdhdmUgdGhlIFdhcm5pbmcuLi4KPiA+ID4gPiA+ID4gCj4gPiA+ID4g
PiA+ID4gSXQgc2VlbXMgdGhhdCB0aGUgcmV0dXJuIHZhbHVlIG9mIGBpbnRlbF9nbWJ1c19nZXRf
YWRhcHRlcmAgaXMgbmV2ZXIKPiA+ID4gPiA+ID4gPiBOVUxMLWNoZWNrZWQuIElmIHNvLCBpdCB3
b3VsZCBiZSBiZXR0ZXIgdG8gcmVwbGFjZSB0aGUgYnJhbmNoIHRvIHJldHVybiBhCj4gPiA+ID4g
PiA+ID4gTlVMTCBwb2ludGVyIHdpdGggc29tZXRoaW5nIGxpa2UgYEJVR19PTmAuCj4gPiA+ID4g
PiA+IAo+ID4gPiA+ID4gPiB3aGF0IGFib3V0IGp1c3QgYWRkaW5nIGlmICghaTJjKSByZXR1cm4g
ZmFsc2UKPiA+ID4gPiA+ID4gaW5zdGVhZCBvZiBCVUcuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4g
PiBXZSBhbHJlYWR5IGhhdmUgdGhlIFdBUk4gdG8gZGVidWcgaWYgdGhpcyBjYXNlIGV2ZXIgaGFw
cGVucy4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRoYW5rcywKPiA+ID4gPiA+ID4gUm9kcmln
by4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gUGxlYXNlIGxldCBt
ZSBrbm93IGlmIGl0IG1ha2VzIHNlbnNlLiBJIGFtIGxvb2tpbmcgZm9yd2FyZCB0byB5b3VyIHJl
cGx5Lgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IEJlc3QsCj4gPiA+ID4gPiA+ID4gU2hh
b2JvCj4gPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0
dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4