From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Pass dev_priv to intel_is_dual_link_lvds()
Date: Tue, 19 Mar 2019 10:31:40 -0700 [thread overview]
Message-ID: <20190319173140.GH27875@intel.com> (raw)
In-Reply-To: <87imweg8xt.fsf@intel.com>
On Tue, Mar 19, 2019 at 05:50:22PM +0200, Jani Nikula wrote:
> On Mon, 18 Mar 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Mar 18, 2019 at 09:45:16PM +0100, Michal Wajdeczko wrote:
> >> > Make things look a bit nicer by passing dev_priv to
> >>
> >> In other places we are changing naming from dev_priv to i915.
> >> Can we do the same here ?
> >
> > The display code uses dev_priv quite consistently,. We could
> > go for i915 I suppose but I'd prefer a mass conversion rather
> > than the death by a thousand cuts approach. The display
> > code is already messy enough when it comes to naming local
> > variables.
As Ville I'm more in favor of the mass conversion using sed and/or
coccinelle. It's less painful and less confusing.
>
> We could use i915 in display code as a convention for code that does not
> do register access. ;)
For me this is the worst part of gem code... the mix
of i915 and dev_priv for these cases. Something that a massive
and global change could fix?
>
> BR,
> Jani.
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-19 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 20:26 [PATCH 1/3] drm/i915: Add some missing curly braces Ville Syrjala
2019-03-18 20:26 ` [PATCH 2/3] drm/i915: Polish intel_get_lvds_encoder() Ville Syrjala
2019-03-18 20:35 ` Rodrigo Vivi
2019-03-18 20:26 ` [PATCH 3/3] drm/i915: Pass dev_priv to intel_is_dual_link_lvds() Ville Syrjala
2019-03-18 20:35 ` Rodrigo Vivi
2019-03-18 20:45 ` Michal Wajdeczko
2019-03-18 20:59 ` Ville Syrjälä
2019-03-19 15:50 ` Jani Nikula
2019-03-19 17:31 ` Rodrigo Vivi [this message]
2019-03-19 17:36 ` Chris Wilson
2019-03-18 20:34 ` [PATCH 1/3] drm/i915: Add some missing curly braces Rodrigo Vivi
2019-03-19 14:42 ` Ville Syrjälä
2019-03-19 1:21 ` ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2019-03-19 14:26 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319173140.GH27875@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.