From: Benson Leung <bleung@google.com>
To: Guenter Roeck <groeck@google.com>, Urja Rannikko <urjaman@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
bleung@google.com
Subject: Re: [BUG] cros_ec_debugfs causes a WARNING trace during suspend on ASUS C201
Date: Tue, 19 Mar 2019 12:26:30 -0700 [thread overview]
Message-ID: <20190319192630.GA228799@google.com> (raw)
In-Reply-To: <CABXOdTe7gssZqHziUFjWQ5WROmMbHEVzej8j8toq1kkBrSQS+Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
Hi Guenter, Urja,
On Tue, Mar 19, 2019 at 06:37:08AM -0700, Guenter Roeck wrote:
> Hi,
>
> On Tue, Mar 19, 2019 at 3:37 AM Urja Rannikko <urjaman@gmail.com> wrote:
> >
> > Hi,
> >
> > I was testing 5.1-rc1 on my C201 when i found this, dmesg of a
> > suspend/resume attached.
> >
> > Based on a quick look at the code it looks like the reason is that the
> > suspend and resume calls try to cancel/schedule log_poll_work
> > unconditionally but this device doesnt support reading the console log
> > so the delayed work struct was never initialized.
> >
>
> Thanks a lot for the note. I'll send a fix later today.
>
> Guenter
>
Thanks for the report and quick fix. Guenter's fix has been merged and should
be in 5.1-rc2 when Linus cuts it.
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-03-19 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 10:36 [BUG] cros_ec_debugfs causes a WARNING trace during suspend on ASUS C201 Urja Rannikko
2019-03-19 13:37 ` Guenter Roeck
2019-03-19 19:26 ` Benson Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319192630.GA228799@google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=urjaman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.