From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] pkg-generic: Depend on host-{xz, lzip} only for fitting archives
Date: Tue, 19 Mar 2019 22:50:17 +0100 [thread overview]
Message-ID: <20190319215017.GF2702@scaer> (raw)
In-Reply-To: <20190317212014.3831-1-nolange79@gmail.com>
Norbert, All,
On 2019-03-17 22:20 +0100, Norbert Lange spake thusly:
> results in cleaner dependency graphs, and usually omits host-lzip
> from being built.
As for dependency graphs, there will still be a lot of package that may
depend on host-xz, and that would still clutter it a bit more than
necessary (we have much less packages needing host-lzip, 4 exactly).
But that sure is still a nice improvement.
> Signed-off-by: Norbert Lange <nolange79@gmail.com>
> ---
> package/pkg-generic.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 4353bd3868..89da43d5e5 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -607,12 +607,16 @@ $(2)_EXTRACT_DEPENDENCIES += $$(BR2_TAR_HOST_DEPENDENCY)
> endif
>
> ifeq ($$(filter host-tar host-skeleton host-xz host-lzip host-fakedate,$(1)),)
> +ifneq ($$(filter .xz .lzma,$$(suffix $$($(2)_SOURCE))),)
> $(2)_EXTRACT_DEPENDENCIES += $$(BR2_XZCAT_HOST_DEPENDENCY)
> endif
> +endif
>
> ifeq ($$(filter host-tar host-skeleton host-xz host-lzip host-fakedate,$(1)),)
> +ifeq ($$(suffix $$($(2)_SOURCE)),.lz)
Please use the same pattern here as for the other one. It helps with
readability and maintainability.
Regards,
Yann E. MORIN.
> $(2)_EXTRACT_DEPENDENCIES += $$(BR2_LZIP_HOST_DEPENDENCY)
> endif
> +endif
>
> ifeq ($$(BR2_CCACHE),y)
> ifeq ($$(filter host-tar host-skeleton host-xz host-lzip host-fakedate host-ccache,$(1)),)
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-03-19 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 21:20 [Buildroot] [PATCH v2 1/2] pkg-generic: Depend on host-{xz, lzip} only for fitting archives Norbert Lange
2019-03-17 21:20 ` [Buildroot] [PATCH v2 2/2] pkg-generic: Cleanup some redundant checks Norbert Lange
2019-03-19 22:03 ` Yann E. MORIN
2019-03-25 21:20 ` Norbert Lange
2019-04-01 21:10 ` Thomas Petazzoni
2019-04-01 21:47 ` Arnout Vandecappelle
2019-03-19 21:50 ` Yann E. MORIN [this message]
2019-04-01 21:08 ` [Buildroot] [PATCH v2 1/2] pkg-generic: Depend on host-{xz, lzip} only for fitting archives Thomas Petazzoni
2019-04-05 15:39 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319215017.GF2702@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.