From: Wei Yang <richardw.yang@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: yang.zhong@intel.com, peter.maydell@linaro.org, mst@redhat.com,
qemu-devel@nongnu.org, shannon.zhaosl@gmail.com,
qemu-arm@nongnu.org, Wei Yang <richardw.yang@linux.intel.com>
Subject: Re: [Qemu-arm] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()
Date: Wed, 20 Mar 2019 08:37:14 +0800 [thread overview]
Message-ID: <20190320003714.GA11913@richard> (raw)
In-Reply-To: <20190319100038.6263905f@redhat.com>
On Tue, Mar 19, 2019 at 10:00:38AM +0100, Igor Mammedov wrote:
>On Tue, 19 Mar 2019 08:45:23 +0800
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>
>> On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote:
>> >On Fri, 15 Mar 2019 08:44:32 +0800
>> >Wei Yang <richardw.yang@linux.intel.com> wrote:
>> >
>> >in subject: s/extract/generalize/
>> >
>> >> arm and i386 has almost the same function acpi_add_rom_blob(), except
>> >> giving different FWCfgCallback function.
>> >>
>> >> This patch extract acpi_add_rom_blob() to utils.c by passing
>> > s/extract/moves/
>> >
>> >> FWCfgCallback to it.
>> >>
>> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> >
>> >otherwise patch looks fine to me,
>> >but checkpatch complains about comment style so that needs to be fixed as well
>> >
>>
>> BTW, the checkpatch also says
>>
>> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>>
>> Do I need to fix this?
>yep, add me and Michael as maintainers for these new files.
>
It looks current statement already includes those files.
ACPI/SMBIOS
M: Michael S. Tsirkin <mst@redhat.com>
M: Igor Mammedov <imammedo@redhat.com>
S: Supported
F: include/hw/acpi/*
F: hw/acpi/*
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-03-20 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 0:44 [Qemu-arm] [PATCH v3] hw/acpi: extract acpi_add_rom_blob() Wei Yang
2019-03-18 12:39 ` [Qemu-devel] " Igor Mammedov
2019-03-18 13:51 ` [Qemu-arm] " Wei Yang
2019-03-19 0:45 ` [Qemu-arm] " Wei Yang
2019-03-19 9:00 ` Igor Mammedov
2019-03-20 0:37 ` Wei Yang [this message]
2019-03-20 10:53 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320003714.GA11913@richard \
--to=richardw.yang@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.