All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wentao Cai <etsai042@gmail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] Staging: mt7621-dma: Add blank line after declarations
Date: Wed, 20 Mar 2019 06:11:28 +0100	[thread overview]
Message-ID: <20190320051128.GA16864@kroah.com> (raw)
In-Reply-To: <20190320041854.3829-1-etsai042@gmail.com>

On Tue, Mar 19, 2019 at 09:18:54PM -0700, Wentao Cai wrote:
> Add a blank line after declaration to mute checkpatch.pl warning:
> WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 97571f1d697b..beeff4258b19 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
>  	struct device_dma_parameters dma_parms;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;

Please look at what you did here and compare it to what the checkpatch
warning said it was doing.  Hint, checkpatch is wrong here...

Always use your brain when dealing with checkpatch as it is just a dumb
perl script :)

thanks,

greg k-h


  reply	other threads:[~2019-03-20  5:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  4:18 [PATCH] Staging: mt7621-dma: Add blank line after declarations Wentao Cai
2019-03-20  5:11 ` Greg Kroah-Hartman [this message]
2019-03-20  7:10   ` Wentao Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190320051128.GA16864@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=etsai042@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.