From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb-serial: fix mos_parport refcount imbalance on error path From: Johan Hovold Message-Id: <20190320090458.GD15782@localhost> Date: Wed, 20 Mar 2019 10:04:58 +0100 To: Lin Yi Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, zhiyunq@cs.ucr.edu, csong@cs.ucr.edu, ljian236@gmail.com, yiqiuping@gmail.com List-ID: T24gV2VkLCBNYXIgMjAsIDIwMTkgYXQgMTA6Mjk6MTZBTSArMDgwMCwgTGluIFlpIHdyb3RlOgo+ IHdyaXRlX3BhcnBvcnRfcmVmX25vbmJsb2NrIGluY3JlYXNlIG1vc19wYXJwb3J0IHJlZmNvdW50 IHdpdGhvdXQKPiBkZWNyZWFzZSBpdCB3aGVuIHJldHVybiAtRU5PTUVNIGNvZGUsIHNvIG5lZWQg YSBkZWNyZW1lbnQgYmVmb3JlIGZ1bmN0aW9uCj4gcmV0dXJuIC1FTk9NRU0uCgpHb29kIGNhdGNo IQoKWW91ciBwYXRjaCBsb29rcyBnb29kLCBidXQgd291bGRuJ3QgaXQgYmUgYmV0dGVyIHRvIG1v dmUgdGhlIGtyZWZfZ2V0KCkKKGFuZCBtb3NfcGFycG9ydCBhc3NpZ25tZW50KSB0byB0aGUgZW5k IG9mIHRoZSB1cmJ0cmFjayBpbml0aWFsaXNhdGlvbgppbnN0ZWFkPwoKVGhhdCB3YXkgeW91IHdv dWxkbid0IGhhdmUgdG8gYWRkIGFueSBrcmVmX3B1dHMoKSBhdCBhbGwuCgo+IFNpZ25lZC1vZmYt Ynk6IExpbiBZaSA8dGVyb2luY25AMTYzLmNvbT4KPiAtLS0KPiAgZHJpdmVycy91c2Ivc2VyaWFs L21vczc3MjAuYyB8IDIgKysKPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9zZXJpYWwvbW9zNzcyMC5jIGIvZHJpdmVycy91c2Iv c2VyaWFsL21vczc3MjAuYwo+IGluZGV4IGZjNTJhYzcuLjZhYmIzMzUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy91c2Ivc2VyaWFsL21vczc3MjAuYwo+ICsrKyBiL2RyaXZlcnMvdXNiL3NlcmlhbC9t b3M3NzIwLmMKPiBAQCAtMzcxLDEyICszNzEsMTQgQEAgc3RhdGljIGludCB3cml0ZV9wYXJwb3J0 X3JlZ19ub25ibG9jayhzdHJ1Y3QgbW9zNzcxNV9wYXJwb3J0ICptb3NfcGFycG9ydCwKPiAgCXVy YnRyYWNrLT51cmIgPSB1c2JfYWxsb2NfdXJiKDAsIEdGUF9BVE9NSUMpOwo+ICAJaWYgKCF1cmJ0 cmFjay0+dXJiKSB7Cj4gIAkJa2ZyZWUodXJidHJhY2spOwo+ICsJCWtyZWZfcHV0KCZtb3NfcGFy cG9ydC0+cmVmX2NvdW50LCBkZXN0cm95X21vc19wYXJwb3J0KTsKPiAgCQlyZXR1cm4gLUVOT01F TTsKPiAgCX0KPiAgCXVyYnRyYWNrLT5zZXR1cCA9IGttYWxsb2Moc2l6ZW9mKCp1cmJ0cmFjay0+ c2V0dXApLCBHRlBfQVRPTUlDKTsKPiAgCWlmICghdXJidHJhY2stPnNldHVwKSB7Cj4gIAkJdXNi X2ZyZWVfdXJiKHVyYnRyYWNrLT51cmIpOwo+ICAJCWtmcmVlKHVyYnRyYWNrKTsKPiArCQlrcmVm X3B1dCgmbW9zX3BhcnBvcnQtPnJlZl9jb3VudCwgZGVzdHJveV9tb3NfcGFycG9ydCk7Cj4gIAkJ cmV0dXJuIC1FTk9NRU07Cj4gIAl9Cj4gIAl1cmJ0cmFjay0+c2V0dXAtPmJSZXF1ZXN0VHlwZSA9 IChfX3U4KTB4NDA7CgpUaGFua3MsCkpvaGFuCg==