From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 5/5] media: tvp5150: add support to limit tv norms on connector Date: Wed, 20 Mar 2019 11:18:51 -0300 Message-ID: <20190320111851.1749c9ac@coco.lan> References: <20190202121004.9014-1-m.felsch@pengutronix.de> <20190202121004.9014-6-m.felsch@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190202121004.9014-6-m.felsch@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Marco Felsch Cc: devicetree@vger.kernel.org, sakari.ailus@linux.intel.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, hans.verkuil@cisco.com, kernel@pengutronix.de, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org RW0gU2F0LCAgMiBGZWIgMjAxOSAxMzoxMDowNCArMDEwMApNYXJjbyBGZWxzY2ggPG0uZmVsc2No QHBlbmd1dHJvbml4LmRlPiBlc2NyZXZldToKCj4gVGhlIHR2cDUxNTAgYWNjZXB0cyBOVFNDKE0s Siw0LjQzKSwgUEFMIChCLEQsRyxILEksTSxOKSBhbmQgU0VDQU0gdmlkZW8KPiBkYXRhIGFuZCBp cyBhYmxlIHRvIGF1dG8tZGV0ZWN0IHRoZSBpbnB1dCBzaWduYWwuIAoKSG1tLi4uIEknbSBhZnJh aWQgb2YgdGhpcyBjaGFuZ2UuIEFzIGZhciBhcyBJIHJlbWVtYmVyLCBJIHRlc3RlZCBzb21lCndl aXJkIGZvcm1hdCB2YXJpYW50cyBsaWtlIFY0TDJfU1REX1BBTF82MCBhIGxvbmcgdGltZSBhZ28s IGJ1dCB0aGVyZSdzCm5vIHdheSB0byBmb3JjZSB2aWRlbyB0byB1c2UgdGhvc2UuIFRoZSBmb3Jt YXQgc2VsZWN0aW9uIGxvZ2ljIHNpbXBseQpwbGFjZXMgdGhlIGRldmljZSBvbiBhdXRvLWRldGVj dCBtb2RlIGZvciB0aG9zZSB3ZWlyZG9zLCBhbmQgdGhhdAp3b3JrcyBmaW5lIGF0IHRoZSBkZXZp Y2VzIEkga25vdy4KCkEgY2hhbmdlIGxpa2UgdGhhdCBtYXkgYnJlYWsgdGhpbmdzLiBTbyBJIHdv dWxkIGFjdHVhbGx5IGhhdmUgYSBxdWlyawp0byBvcHRpb25hbGx5IGRpc2FibGUgYXV0by1kZXRl Y3Rpb24gb24gZGV2aWNlcyB0aGF0IHRoaXMgaXMgbm90IGtub3cKdG8gd29yay4KCj4gVGhlIGF1 dG8tZGV0ZWN0aW9uCj4gZG9lcyBub3Qgd29yayBpZiB0aGUgY29ubmVjdG9yIGRvZXMgbm90IHJl Y2VpdmUgYW4gaW5wdXQgc2lnbmFsIGFuZCB0aGUKPiB0dnA1MTUwIG1pZ2h0IG5vdCBiZSBjb25m aWd1cmVkIGNvcnJlY3RseS4gVGhpcyBtaXNjb25maWd1cmF0aW9uIGxlYWRzCj4gaW50byB3cm9u ZyBkZWNvZGVkIHZpZGVvIHN0cmVhbXMgaWYgdGhlIHR2cDUxNTAgZ2V0cyBwb3dlcmVkIG9uIGJl Zm9yZQo+IHRoZSB2aWRlbyBzaWduYWwgaXMgcHJlc2VudC4KPiAKPiBMaW1pdCB0aGUgc3VwcG9y dGVkIHR2IG5vcm1zIGFjY29yZGluZyB0byB0aGUgYWN0dWFsIHNlbGVjdGVkIGNvbm5lY3Rvcgo+ IHRvIGF2b2lkIGEgbWlzY29uZmlndXJhdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYXJjbyBG ZWxzY2ggPG0uZmVsc2NoQHBlbmd1dHJvbml4LmRlPgo+IC0tLQo+ICBkcml2ZXJzL21lZGlhL2ky Yy90dnA1MTUwLmMgfCA0MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4g IDEgZmlsZSBjaGFuZ2VkLCA0MSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvaTJjL3R2cDUxNTAuYyBiL2RyaXZlcnMvbWVkaWEvaTJj L3R2cDUxNTAuYwo+IGluZGV4IGYzYTJhZDAwYTQwZC4uNzYxOTc5M2RlZTY3IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvbWVkaWEvaTJjL3R2cDUxNTAuYwo+ICsrKyBiL2RyaXZlcnMvbWVkaWEvaTJj L3R2cDUxNTAuYwo+IEBAIC0zMiw2ICszMiwxMyBAQAo+ICAjZGVmaW5lIFRWUDUxNTBfTUJVU19G TVQJTUVESUFfQlVTX0ZNVF9VWVZZOF8yWDgKPiAgI2RlZmluZSBUVlA1MTUwX0ZJRUxECQlWNEwy X0ZJRUxEX0FMVEVSTkFURQo+ICAjZGVmaW5lIFRWUDUxNTBfQ09MT1JTUEFDRQlWNEwyX0NPTE9S U1BBQ0VfU01QVEUxNzBNCj4gKyNkZWZpbmUgVFZQNTE1MF9TVERfTUFTSwkoVjRMMl9TVERfTlRT QyAgICAgfCBcCj4gKwkJCQkgVjRMMl9TVERfTlRTQ180NDMgfCBcCj4gKwkJCQkgVjRMMl9TVERf UEFMICAgICAgfCBcCj4gKwkJCQkgVjRMMl9TVERfUEFMX00gICAgfCBcCj4gKwkJCQkgVjRMMl9T VERfUEFMX04gICAgfCBcCj4gKwkJCQkgVjRMMl9TVERfUEFMX05jICAgfCBcCj4gKwkJCQkgVjRM Ml9TVERfU0VDQU0pCj4gIAo+ICBNT0RVTEVfREVTQ1JJUFRJT04oIlRleGFzIEluc3RydW1lbnRz IFRWUDUxNTBBL1RWUDUxNTBBTTEvVFZQNTE1MSB2aWRlbyBkZWNvZGVyIGRyaXZlciIpOwo+ICBN T0RVTEVfQVVUSE9SKCJNYXVybyBDYXJ2YWxobyBDaGVoYWIiKTsKPiBAQCAtNzQsNiArODEsNyBA QCBzdHJ1Y3QgdHZwNTE1MCB7Cj4gIAlzdHJ1Y3QgbWVkaWFfcGFkIHBhZHNbVFZQNTE1MF9OVU1f UEFEU107Cj4gIAlpbnQgcGFkc19zdGF0ZVtUVlA1MTUwX05VTV9QQURTXTsKPiAgCXN0cnVjdCB0 dnA1MTUwX2Nvbm5lY3RvciAqY29ubmVjdG9yczsKPiArCXN0cnVjdCB0dnA1MTUwX2Nvbm5lY3Rv ciAqY3VyX2Nvbm5lY3RvcjsKPiAgCWludCBjb25uZWN0b3JzX251bTsKPiAgCWJvb2wgbW9kaWZ5 X3NlY29uZF9saW5rOwo+ICAjZW5kaWYKPiBAQCAtNzk0LDE3ICs4MDIsMjcgQEAgc3RhdGljIGlu dCB0dnA1MTUwX2dfc3RkKHN0cnVjdCB2NGwyX3N1YmRldiAqc2QsIHY0bDJfc3RkX2lkICpzdGQp Cj4gIHN0YXRpYyBpbnQgdHZwNTE1MF9zX3N0ZChzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNkLCB2NGwy X3N0ZF9pZCBzdGQpCj4gIHsKPiAgCXN0cnVjdCB0dnA1MTUwICpkZWNvZGVyID0gdG9fdHZwNTE1 MChzZCk7Cj4gKwl2NGwyX3N0ZF9pZCBzdXBwb3J0ZWRfbm9ybXMgPQo+ICsJCWRlY29kZXItPmN1 cl9jb25uZWN0b3ItPmJhc2UuY29ubmVjdG9yLmFuYWxvZy5zdXBwb3J0ZWRfdHZub3JtczsKPiAg Cj4gIAlpZiAoZGVjb2Rlci0+bm9ybSA9PSBzdGQpCj4gIAkJcmV0dXJuIDA7Cj4gIAo+ICsJLyoK PiArCSAqIGNoZWNrIGlmIHJlcXVlc3RlZCBzdGQgb3IgZ3JvdXAgb2Ygc3RkJ3MgaXMvYXJlIHN1 cHBvcnRlZCBieSB0aGUKPiArCSAqIGNvbm5lY3Rvcgo+ICsJICovCj4gKwlpZiAoKHN1cHBvcnRl ZF9ub3JtcyAmIHN0ZCkgPT0gMCkKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gIAkvKiBDaGFu Z2UgY3JvcHBpbmcgaGVpZ2h0IGxpbWl0cyAqLwo+ICAJaWYgKHN0ZCAmIFY0TDJfU1REXzUyNV82 MCkKPiAgCQlkZWNvZGVyLT5yZWN0LmhlaWdodCA9IFRWUDUxNTBfVl9NQVhfNTI1XzYwOwo+ICAJ ZWxzZQo+ICAJCWRlY29kZXItPnJlY3QuaGVpZ2h0ID0gVFZQNTE1MF9WX01BWF9PVEhFUlM7Cj4g IAo+IC0JZGVjb2Rlci0+bm9ybSA9IHN0ZDsKPiArCS8qIHNldCBvbmx5IHRoZSBzcGVjaWZpYyBz dXBwb3J0ZWQgc3RkIGluIGNhc2Ugb2YgZ3JvdXAgb2Ygc3RkJ3MgKi8KPiArCWRlY29kZXItPm5v cm0gPSBzdXBwb3J0ZWRfbm9ybXMgJiBzdGQ7Cj4gIAo+ICAJcmV0dXJuIHR2cDUxNTBfc2V0X3N0 ZChzZCwgc3RkKTsKPiAgfQo+IEBAIC0xMjk4LDYgKzEzMTYsNyBAQCBzdGF0aWMgaW50IHR2cDUx NTBfbGlua19zZXR1cChzdHJ1Y3QgbWVkaWFfZW50aXR5ICplbnRpdHksCj4gIAlpbnQgKnBhZF9z dGF0ZSA9ICZkZWNvZGVyLT5wYWRzX3N0YXRlWzBdOwo+ICAJaW50IGksIGFjdGl2ZV9wYWQsIHJl dCA9IDA7Cj4gIAlib29sIGlzX3N2aWRlbyA9IGZhbHNlOwo+ICsJYm9vbCB1cGRhdGVfY3VyX2Nv bm5lY3RvciA9IGZhbHNlOwo+ICAKPiAgCS8qCj4gIAkgKiBUaGUgdHZwIHN0YXRlIGlzIGRldGVy bWluZWQgYnkgdGhlIGVuYWJsZWQgc2luayBwYWQgbGluay4KPiBAQCAtMTM0NCwxMCArMTM2Mywx MiBAQCBzdGF0aWMgaW50IHR2cDUxNTBfbGlua19zZXR1cChzdHJ1Y3QgbWVkaWFfZW50aXR5ICpl bnRpdHksCj4gIAkJCQlkZWNvZGVyLT5tb2RpZnlfc2Vjb25kX2xpbmsgPSBmYWxzZTsKPiAgCQkJ CXR2cDUxNTBfc19yb3V0aW5nKHNkLCBUVlA1MTUwX1NWSURFTywKPiAgCQkJCQkJICBUVlA1MTUw X05PUk1BTCwgMCk7Cj4gKwkJCQl1cGRhdGVfY3VyX2Nvbm5lY3RvciA9IHRydWU7Cj4gIAkJCX0K PiAgCQl9IGVsc2Ugewo+ICAJCQl0dnA1MTUwX3Nfcm91dGluZyhzZCwgdHZwNTE1MF9wYWQtPmlu ZGV4LAo+ICAJCQkJCSAgVFZQNTE1MF9OT1JNQUwsIDApOwo+ICsJCQl1cGRhdGVfY3VyX2Nvbm5l Y3RvciA9IHRydWU7Cj4gIAkJfQo+ICAJfSBlbHNlIHsKPiAgCQkvKgo+IEBAIC0xMzc2LDYgKzEz OTcsMTQgQEAgc3RhdGljIGludCB0dnA1MTUwX2xpbmtfc2V0dXAoc3RydWN0IG1lZGlhX2VudGl0 eSAqZW50aXR5LAo+ICAJCQkJCSAgYWN0aXZlX3BhZCwgVFZQNTE1MF9CTEFDS19TQ1JFRU4sIDAp Owo+ICAJCWRlY29kZXItPm1vZGlmeV9zZWNvbmRfbGluayA9IGZhbHNlOwo+ICAJfQo+ICsKPiAr CWlmICh1cGRhdGVfY3VyX2Nvbm5lY3Rvcikgewo+ICsJCS8qIFVwZGF0ZSB0dm5vcm0gYWNjb3Jk aW5nIHRvIGNvbm5lY3RvciAqLwo+ICsJCWRlY29kZXItPmN1cl9jb25uZWN0b3IgPQo+ICsJCQlj b250YWluZXJfb2YocmVtb3RlLCBzdHJ1Y3QgdHZwNTE1MF9jb25uZWN0b3IsIHBhZCk7Cj4gKwkJ dHZwNTE1MF9zX3N0ZChzZCwKPiArCQkJZGVjb2Rlci0+Y3VyX2Nvbm5lY3Rvci0+YmFzZS5jb25u ZWN0b3IuYW5hbG9nLnN1cHBvcnRlZF90dm5vcm1zKTsKPiArCX0KPiAgb3V0Ogo+ICAJcmV0dXJu IHJldDsKPiAgfQo+IEBAIC0xNjA1LDYgKzE2MzQsOSBAQCBzdGF0aWMgaW50IHR2cDUxNTBfcmVn aXN0ZXJlZChzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNkKQo+ICAJCQl9Cj4gIAkJCXR2cDUxNTBfc2Vs bXV4KHNkKTsKPiAgCQkJZGVjb2Rlci0+bW9kaWZ5X3NlY29uZF9saW5rID0gZmFsc2U7Cj4gKwkJ CWRlY29kZXItPmN1cl9jb25uZWN0b3IgPSAmZGVjb2Rlci0+Y29ubmVjdG9yc1tpXTsKPiArCQkJ dHZwNTE1MF9zX3N0ZChzZCwKPiArCQkJCWRlY29kZXItPmNvbm5lY3RvcnNbaV0uYmFzZS5jb25u ZWN0b3IuYW5hbG9nLnN1cHBvcnRlZF90dm5vcm1zKTsKPiAgCQl9Cj4gIAl9Cj4gICNlbmRpZgo+ IEBAIC0xOTI1LDYgKzE5NTcsMTQgQEAgc3RhdGljIGludCB0dnA1MTUwX3BhcnNlX2R0KHN0cnVj dCB0dnA1MTUwICpkZWNvZGVyLCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wKQo+ICAJCQkJcmV0ID0g LUVJTlZBTDsKPiAgCQkJCWdvdG8gZXJyOwo+ICAJCQl9Cj4gKwkJCWlmICghKGMuY29ubmVjdG9y LmFuYWxvZy5zdXBwb3J0ZWRfdHZub3JtcyAmCj4gKwkJCSAgICBUVlA1MTUwX1NURF9NQVNLKSkg ewo+ICsJCQkJZGV2X2VycihkZXYsCj4gKwkJCQkJIkludmFsaWQgdHYgbm9ybShzKSBvbiBjb25u ZWN0b3IgJXMuXG4iLAo+ICsJCQkJCWMubGFiZWwpOwo+ICsJCQkJcmV0ID0gLUVJTlZBTDsKPiAr CQkJCWdvdG8gZXJyOwo+ICsJCQl9Cj4gIAkJCWluKys7Cj4gIAkJCWJyZWFrOwo+ICAJCWNhc2Ug VFZQNTE1MF9QQURfVklEX09VVDoKCgoKVGhhbmtzLApNYXVybwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18097C43381 for ; Wed, 20 Mar 2019 14:19:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D00BA206BA for ; Wed, 20 Mar 2019 14:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553091549; bh=jUkUX2MkRTmPSI/J3twy3hAFphcGa6RqhfvJk8dRIRE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=PaI5n6ZXEtp3GITNsd1KTjQ8X2TlSd1wqYk5Cn1dnhPAns/XF3iMRPtVTXeUh4I81 /ugwp7QtHmsqeyBfsBxj/NAGVYeFpd1pqZPHYoNTO4KuM460xY6gOHfYKyoWJESnK5 zn9U6FibxL30/L2Nms8P/yHOj9iGm6a02jxlPSOs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727159AbfCTOTJ (ORCPT ); Wed, 20 Mar 2019 10:19:09 -0400 Received: from casper.infradead.org ([85.118.1.10]:39456 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726611AbfCTOTJ (ORCPT ); Wed, 20 Mar 2019 10:19:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wzFi9IS0O/D+QXmQSKO06hqofS9jDCRoUvuu/NHU+Ls=; b=Se/L5pIFjJxAc6uxGPM2NtDFi3 k28xZLTIuk7Dta3SVMCPi2PUm+l2fW/kPOmcamekV57uY6VOUxAUakSCsfjFKcOKJMDHc2Vcq9sX7 AjAuhWZV7u0zKJe21y/45Hqrh/J8fb/gQ3a2Aq1f8KEehVRF3sEyPfDHJcxN6Yd1h65FWyEi6cb61 6nbBsCSOl5fq/j8kVDQwIyleHwGMF6RXn8DUcu4RnX/NlI8EBcjko3K+QKpSOYup+8Ck8xLlS4eGr Y3W2ujHEyDKg/1rQAhKtg3p26Sk4Oq5RFw3LN8Z426JhLhyFWaDqHXxw7D3kJLL0nUNTa91g3oOdJ WI9f+gog==; Received: from [179.95.24.146] (helo=coco.lan) by casper.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6c3V-0000tU-3I; Wed, 20 Mar 2019 14:18:57 +0000 Date: Wed, 20 Mar 2019 11:18:51 -0300 From: Mauro Carvalho Chehab To: Marco Felsch Cc: robh+dt@kernel.org, hans.verkuil@cisco.com, sakari.ailus@linux.intel.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 5/5] media: tvp5150: add support to limit tv norms on connector Message-ID: <20190320111851.1749c9ac@coco.lan> In-Reply-To: <20190202121004.9014-6-m.felsch@pengutronix.de> References: <20190202121004.9014-1-m.felsch@pengutronix.de> <20190202121004.9014-6-m.felsch@pengutronix.de> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Sat, 2 Feb 2019 13:10:04 +0100 Marco Felsch escreveu: > The tvp5150 accepts NTSC(M,J,4.43), PAL (B,D,G,H,I,M,N) and SECAM video > data and is able to auto-detect the input signal. Hmm... I'm afraid of this change. As far as I remember, I tested some weird format variants like V4L2_STD_PAL_60 a long time ago, but there's no way to force video to use those. The format selection logic simply places the device on auto-detect mode for those weirdos, and that works fine at the devices I know. A change like that may break things. So I would actually have a quirk to optionally disable auto-detection on devices that this is not know to work. > The auto-detection > does not work if the connector does not receive an input signal and the > tvp5150 might not be configured correctly. This misconfiguration leads > into wrong decoded video streams if the tvp5150 gets powered on before > the video signal is present. > > Limit the supported tv norms according to the actual selected connector > to avoid a misconfiguration. > > Signed-off-by: Marco Felsch > --- > drivers/media/i2c/tvp5150.c | 42 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 41 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c > index f3a2ad00a40d..7619793dee67 100644 > --- a/drivers/media/i2c/tvp5150.c > +++ b/drivers/media/i2c/tvp5150.c > @@ -32,6 +32,13 @@ > #define TVP5150_MBUS_FMT MEDIA_BUS_FMT_UYVY8_2X8 > #define TVP5150_FIELD V4L2_FIELD_ALTERNATE > #define TVP5150_COLORSPACE V4L2_COLORSPACE_SMPTE170M > +#define TVP5150_STD_MASK (V4L2_STD_NTSC | \ > + V4L2_STD_NTSC_443 | \ > + V4L2_STD_PAL | \ > + V4L2_STD_PAL_M | \ > + V4L2_STD_PAL_N | \ > + V4L2_STD_PAL_Nc | \ > + V4L2_STD_SECAM) > > MODULE_DESCRIPTION("Texas Instruments TVP5150A/TVP5150AM1/TVP5151 video decoder driver"); > MODULE_AUTHOR("Mauro Carvalho Chehab"); > @@ -74,6 +81,7 @@ struct tvp5150 { > struct media_pad pads[TVP5150_NUM_PADS]; > int pads_state[TVP5150_NUM_PADS]; > struct tvp5150_connector *connectors; > + struct tvp5150_connector *cur_connector; > int connectors_num; > bool modify_second_link; > #endif > @@ -794,17 +802,27 @@ static int tvp5150_g_std(struct v4l2_subdev *sd, v4l2_std_id *std) > static int tvp5150_s_std(struct v4l2_subdev *sd, v4l2_std_id std) > { > struct tvp5150 *decoder = to_tvp5150(sd); > + v4l2_std_id supported_norms = > + decoder->cur_connector->base.connector.analog.supported_tvnorms; > > if (decoder->norm == std) > return 0; > > + /* > + * check if requested std or group of std's is/are supported by the > + * connector > + */ > + if ((supported_norms & std) == 0) > + return -EINVAL; > + > /* Change cropping height limits */ > if (std & V4L2_STD_525_60) > decoder->rect.height = TVP5150_V_MAX_525_60; > else > decoder->rect.height = TVP5150_V_MAX_OTHERS; > > - decoder->norm = std; > + /* set only the specific supported std in case of group of std's */ > + decoder->norm = supported_norms & std; > > return tvp5150_set_std(sd, std); > } > @@ -1298,6 +1316,7 @@ static int tvp5150_link_setup(struct media_entity *entity, > int *pad_state = &decoder->pads_state[0]; > int i, active_pad, ret = 0; > bool is_svideo = false; > + bool update_cur_connector = false; > > /* > * The tvp state is determined by the enabled sink pad link. > @@ -1344,10 +1363,12 @@ static int tvp5150_link_setup(struct media_entity *entity, > decoder->modify_second_link = false; > tvp5150_s_routing(sd, TVP5150_SVIDEO, > TVP5150_NORMAL, 0); > + update_cur_connector = true; > } > } else { > tvp5150_s_routing(sd, tvp5150_pad->index, > TVP5150_NORMAL, 0); > + update_cur_connector = true; > } > } else { > /* > @@ -1376,6 +1397,14 @@ static int tvp5150_link_setup(struct media_entity *entity, > active_pad, TVP5150_BLACK_SCREEN, 0); > decoder->modify_second_link = false; > } > + > + if (update_cur_connector) { > + /* Update tvnorm according to connector */ > + decoder->cur_connector = > + container_of(remote, struct tvp5150_connector, pad); > + tvp5150_s_std(sd, > + decoder->cur_connector->base.connector.analog.supported_tvnorms); > + } > out: > return ret; > } > @@ -1605,6 +1634,9 @@ static int tvp5150_registered(struct v4l2_subdev *sd) > } > tvp5150_selmux(sd); > decoder->modify_second_link = false; > + decoder->cur_connector = &decoder->connectors[i]; > + tvp5150_s_std(sd, > + decoder->connectors[i].base.connector.analog.supported_tvnorms); > } > } > #endif > @@ -1925,6 +1957,14 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np) > ret = -EINVAL; > goto err; > } > + if (!(c.connector.analog.supported_tvnorms & > + TVP5150_STD_MASK)) { > + dev_err(dev, > + "Invalid tv norm(s) on connector %s.\n", > + c.label); > + ret = -EINVAL; > + goto err; > + } > in++; > break; > case TVP5150_PAD_VID_OUT: Thanks, Mauro