From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Marek Vasut <marex@denx.de>, NXP Linux Team <linux-imx@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board
Date: Wed, 20 Mar 2019 22:51:58 +0800 [thread overview]
Message-ID: <20190320145149.GD8337@dragon> (raw)
In-Reply-To: <CAOMZO5D=-U050D1_REB_v+rGa0FqvtEiU0wfnKpLOQYXQjKijQ@mail.gmail.com>
On Wed, Mar 20, 2019 at 09:32:38AM -0300, Fabio Estevam wrote:
> Hi Marek,
>
> On Mon, Mar 4, 2019 at 9:12 AM Marek Vasut <marex@denx.de> wrote:
>
> > + regulators {
> > + compatible = "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + reg_usbh1_vbus: regulator@3 {
>
> Please move the regulator outside the 'simple-bus':
>
> reg_usbh1_vbus: regulator-usbh1-vbus {
>
> > + compatible = "regulator-fixed";
> > + reg = <3>;
>
> The 'reg' property can also be removed.
>
> > + regulator-name = "vbus";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpio1 2 0>;
>
> The GPIO flag 0 means active high, but since you are not passing
> 'enable-active-high' this should be:
>
> gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;
>
> > +&i2c2 {
> > + stmpe610@41 {
>
> Node name should be generic, so:
>
> touchscreen@41
>
> > +&ldb {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_lvds0>;
> > + status = "okay";
> > +
> > + lvds0: lvds-channel@0 {
>
> There is an @0 without a corresponding reg property. This triggers a
> dtc warning when building with W=1.
>
> Please fix it.
Okay, I dropped the patch and wait for new version.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-20 14:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 12:11 [PATCH V3 1/2] of: Add vendor prefix for Menlo Systems GmbH Marek Vasut
2019-03-04 12:11 ` Marek Vasut
2019-03-04 12:11 ` [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board Marek Vasut
2019-03-20 9:01 ` Uwe Kleine-König
2019-03-20 9:03 ` Shawn Guo
2019-03-21 2:47 ` Marek Vasut
2019-03-20 12:32 ` Fabio Estevam
2019-03-20 14:51 ` Shawn Guo [this message]
2019-03-21 2:40 ` Marek Vasut
2019-03-21 2:57 ` Marek Vasut
2019-03-20 8:52 ` [PATCH V3 1/2] of: Add vendor prefix for Menlo Systems GmbH Shawn Guo
2019-03-20 8:52 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320145149.GD8337@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.