From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 7/9] drm/i915: Move some variables to tighter scope Date: Wed, 20 Mar 2019 17:27:36 +0200 Message-ID: <20190320152736.GO3888@intel.com> References: <20190312205844.6339-1-ville.syrjala@linux.intel.com> <20190312205844.6339-8-ville.syrjala@linux.intel.com> <20190319001049.GQ4773@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 130C189FD1 for ; Wed, 20 Mar 2019 15:27:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190319001049.GQ4773@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMDU6MTA6NDlQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBUdWUsIE1hciAxMiwgMjAxOSBhdCAxMDo1ODo0MlBNICswMjAwLCBWaWxsZSBTeXJq YWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+IAo+ID4gQ2xlYW4gdXAgc2tsX2FsbG9jYXRlX3BpcGVfZGRiKCkgYSBi aXQgYnkgbW92aW5nIHRoZSAnd20nIHZhcmlhYmxlCj4gPiB0byB0aWdodGVyIHNjb3BlLiBXZSds bCBhbHNvIGNvbnNpdGlmeSBpdCB3aGVyZSBhcHByb3ByaWF0ZS4KPiA+IAo+ID4gQ2M6IE5lZWwg RGVzYWkgPG5lZWwuZGVzYWlAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyMyArKysrKysrKysrKysrLS0tLS0tLS0tLQo+ ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiA+ IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiBpbmRleCA4YWZiYzU2YWQ4OWEuLmI5NThh MWEwMDAxNCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+IEBAIC00MzM2LDcg KzQzMzYsNiBAQCBza2xfYWxsb2NhdGVfcGlwZV9kZGIoc3RydWN0IGludGVsX2NydGNfc3RhdGUg KmNzdGF0ZSwKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShjcnRjLT5kZXYpOwo+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2lu dGVsX2NydGMoY3J0Yyk7Cj4gPiAgCXN0cnVjdCBza2xfZGRiX2VudHJ5ICphbGxvYyA9ICZjc3Rh dGUtPndtLnNrbC5kZGI7Cj4gPiAtCXN0cnVjdCBza2xfcGxhbmVfd20gKndtOwo+ID4gIAl1MTYg YWxsb2Nfc2l6ZSwgc3RhcnQgPSAwOwo+ID4gIAl1MTYgdG90YWxbSTkxNV9NQVhfUExBTkVTXSA9 IHt9Owo+ID4gIAl1MTYgdXZfdG90YWxbSTkxNV9NQVhfUExBTkVTXSA9IHt9Owo+ID4gQEAgLTQz OTMsNyArNDM5Miw4IEBAIHNrbF9hbGxvY2F0ZV9waXBlX2RkYihzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3N0YXRlLAo+ID4gIAlmb3IgKGxldmVsID0gaWxrX3dtX21heF9sZXZlbChkZXZfcHJp dik7IGxldmVsID49IDA7IGxldmVsLS0pIHsKPiA+ICAJCWJsb2NrcyA9IDA7Cj4gPiAgCQlmb3Jf ZWFjaF9wbGFuZV9pZF9vbl9jcnRjKGludGVsX2NydGMsIHBsYW5lX2lkKSB7Cj4gPiAtCQkJd20g PSAmY3N0YXRlLT53bS5za2wub3B0aW1hbC5wbGFuZXNbcGxhbmVfaWRdOwo+ID4gKwkJCWNvbnN0 IHN0cnVjdCBza2xfcGxhbmVfd20gKndtID0KPiA+ICsJCQkJJmNzdGF0ZS0+d20uc2tsLm9wdGlt YWwucGxhbmVzW3BsYW5lX2lkXTsKPiA+ICAKPiA+ICAJCQlpZiAocGxhbmVfaWQgPT0gUExBTkVf Q1VSU09SKSB7Cj4gPiAgCQkJCWlmIChXQVJOX09OKHdtLT53bVtsZXZlbF0ubWluX2RkYl9hbGxv YyA+Cj4gPiBAQCAtNDQyNyw2ICs0NDI3LDggQEAgc2tsX2FsbG9jYXRlX3BpcGVfZGRiKHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gPiAgCSAqIHByb3BvcnRpb25hbCB0byBpdHMg cmVsYXRpdmUgZGF0YSByYXRlLgo+ID4gIAkgKi8KPiA+ICAJZm9yX2VhY2hfcGxhbmVfaWRfb25f Y3J0YyhpbnRlbF9jcnRjLCBwbGFuZV9pZCkgewo+ID4gKwkJY29uc3Qgc3RydWN0IHNrbF9wbGFu ZV93bSAqd20gPQo+ID4gKwkJCSZjc3RhdGUtPndtLnNrbC5vcHRpbWFsLnBsYW5lc1twbGFuZV9p ZF07Cj4gPiAgCQl1NjQgcmF0ZTsKPiA+ICAJCXUxNiBleHRyYTsKPiA+ICAKPiA+IEBAIC00NDQw LDggKzQ0NDIsNiBAQCBza2xfYWxsb2NhdGVfcGlwZV9kZGIoc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNzdGF0ZSwKPiA+ICAJCWlmICh0b3RhbF9kYXRhX3JhdGUgPT0gMCkKPiA+ICAJCQlicmVh azsKPiA+ICAKPiA+IC0JCXdtID0gJmNzdGF0ZS0+d20uc2tsLm9wdGltYWwucGxhbmVzW3BsYW5l X2lkXTsKPiA+IC0KPiA+ICAJCXJhdGUgPSBwbGFuZV9kYXRhX3JhdGVbcGxhbmVfaWRdOwo+ID4g IAkJZXh0cmEgPSBtaW5fdCh1MTYsIGFsbG9jX3NpemUsCj4gPiAgCQkJICAgICAgRElWNjRfVTY0 X1JPVU5EX1VQKGFsbG9jX3NpemUgKiByYXRlLAo+ID4gQEAgLTQ0NjYsMTQgKzQ0NjYsMTQgQEAg c2tsX2FsbG9jYXRlX3BpcGVfZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4g PiAgCS8qIFNldCB0aGUgYWN0dWFsIEREQiBzdGFydC9lbmQgcG9pbnRzIGZvciBlYWNoIHBsYW5l ICovCj4gPiAgCXN0YXJ0ID0gYWxsb2MtPnN0YXJ0Owo+ID4gIAlmb3JfZWFjaF9wbGFuZV9pZF9v bl9jcnRjKGludGVsX2NydGMsIHBsYW5lX2lkKSB7Cj4gPiAtCQlzdHJ1Y3Qgc2tsX2RkYl9lbnRy eSAqcGxhbmVfYWxsb2MsICp1dl9wbGFuZV9hbGxvYzsKPiA+ICsJCXN0cnVjdCBza2xfZGRiX2Vu dHJ5ICpwbGFuZV9hbGxvYyA9Cj4gPiArCQkJJmNzdGF0ZS0+d20uc2tsLnBsYW5lX2RkYl95W3Bs YW5lX2lkXTsKPiA+ICsJCXN0cnVjdCBza2xfZGRiX2VudHJ5ICp1dl9wbGFuZV9hbGxvYyA9Cj4g PiArCQkJJmNzdGF0ZS0+d20uc2tsLnBsYW5lX2RkYl91dltwbGFuZV9pZF07Cj4gPiAgCj4gPiAg CQlpZiAocGxhbmVfaWQgPT0gUExBTkVfQ1VSU09SKQo+ID4gIAkJCWNvbnRpbnVlOwo+ID4gIAo+ ID4gLQkJcGxhbmVfYWxsb2MgPSAmY3N0YXRlLT53bS5za2wucGxhbmVfZGRiX3lbcGxhbmVfaWRd Owo+ID4gLQkJdXZfcGxhbmVfYWxsb2MgPSAmY3N0YXRlLT53bS5za2wucGxhbmVfZGRiX3V2W3Bs YW5lX2lkXTsKPiA+IC0KPiA+ICAJCS8qIEdlbjExKyB1c2VzIGEgc2VwYXJhdGUgcGxhbmUgZm9y IFVWIHdhdGVybWFya3MgKi8KPiA+ICAJCVdBUk5fT04oSU5URUxfR0VOKGRldl9wcml2KSA+PSAx MSAmJiB1dl90b3RhbFtwbGFuZV9pZF0pOwo+ID4gIAo+IAo+IFRoaXMgaHVuayBpcyBmaW5lLCBi dXQgaXNuJ3Qgd2hhdCdzIGRlc2NyaWJlZCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuCj4gTWF5YmUg dGhyb3cgYW4gZXh0cmEgc2VudGVuY2UgaW4gdGhlcmUgcmVmZXJlbmNpbmcgdGhpcyBjaGFuZ2U/ CgpBbWVuZGVkIHRoZSBjb21taXQgbWVzc2FnZSBhIGJpdCwgYW5kIGZpeGVkIHVwIHRoZSB1cGRh dGUgdnMuIGJ1aWxkCnR5cG8gaW4gdGhlIGNvbW1pdCBtZXNzYWdlIG9mIHRoZSBvdGhlciBwYXRj aC4KClNlcmllcyBwdXNoZWQgdG8gZGlucS4gVGhhbmtzIGZvciB0aGUgcmV2aWV3LgoKPiAKPiBB c2lkZSBmcm9tIHRoYXQsCj4gCj4gUmV2aWV3ZWQtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5y b3BlckBpbnRlbC5jb20+Cj4gCj4gPiBAQCAtNDQ5OSw3ICs0NDk5LDggQEAgc2tsX2FsbG9jYXRl X3BpcGVfZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gPiAgCSAqLwo+ID4g IAlmb3IgKGxldmVsKys7IGxldmVsIDw9IGlsa193bV9tYXhfbGV2ZWwoZGV2X3ByaXYpOyBsZXZl bCsrKSB7Cj4gPiAgCQlmb3JfZWFjaF9wbGFuZV9pZF9vbl9jcnRjKGludGVsX2NydGMsIHBsYW5l X2lkKSB7Cj4gPiAtCQkJd20gPSAmY3N0YXRlLT53bS5za2wub3B0aW1hbC5wbGFuZXNbcGxhbmVf aWRdOwo+ID4gKwkJCXN0cnVjdCBza2xfcGxhbmVfd20gKndtID0KPiA+ICsJCQkJJmNzdGF0ZS0+ d20uc2tsLm9wdGltYWwucGxhbmVzW3BsYW5lX2lkXTsKPiA+ICAKPiA+ICAJCQkvKgo+ID4gIAkJ CSAqIFdlIG9ubHkgZGlzYWJsZSB0aGUgd2F0ZXJtYXJrcyBmb3IgZWFjaCBwbGFuZSBpZgo+ID4g QEAgLTQ1MzUsNyArNDUzNiw5IEBAIHNrbF9hbGxvY2F0ZV9waXBlX2RkYihzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqY3N0YXRlLAo+ID4gIAkgKiBkb24ndCBoYXZlIGVub3VnaCBEREIgYmxvY2tz IGZvciBpdC4KPiA+ICAJICovCj4gPiAgCWZvcl9lYWNoX3BsYW5lX2lkX29uX2NydGMoaW50ZWxf Y3J0YywgcGxhbmVfaWQpIHsKPiA+IC0JCXdtID0gJmNzdGF0ZS0+d20uc2tsLm9wdGltYWwucGxh bmVzW3BsYW5lX2lkXTsKPiA+ICsJCXN0cnVjdCBza2xfcGxhbmVfd20gKndtID0KPiA+ICsJCQkm Y3N0YXRlLT53bS5za2wub3B0aW1hbC5wbGFuZXNbcGxhbmVfaWRdOwo+ID4gKwo+ID4gIAkJaWYg KHdtLT50cmFuc193bS5wbGFuZV9yZXNfYiA+PSB0b3RhbFtwbGFuZV9pZF0pCj4gPiAgCQkJbWVt c2V0KCZ3bS0+dHJhbnNfd20sIDAsIHNpemVvZih3bS0+dHJhbnNfd20pKTsKPiA+ICAJfQo+ID4g LS0gCj4gPiAyLjE5LjIKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gTWF0dCBSb3Blcgo+IEdyYXBoaWNz IFNvZnR3YXJlIEVuZ2luZWVyCj4gSW9URyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50 Cj4gSW50ZWwgQ29ycG9yYXRpb24KPiAoOTE2KSAzNTYtMjc5NQoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=