From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Samuel Holland <samuel@sholland.org>,
Eric Biggers <ebiggers@kernel.org>,
stable@vger.kernel.org
Subject: Re: Build error in 4.14 stable-queue
Date: Thu, 21 Mar 2019 06:27:22 +0100 [thread overview]
Message-ID: <20190321052722.GB21413@kroah.com> (raw)
In-Reply-To: <20190321002844.GD25262@sasha-vm>
On Wed, Mar 20, 2019 at 08:28:44PM -0400, Sasha Levin wrote:
> On Wed, Mar 20, 2019 at 06:50:00PM -0500, Samuel Holland wrote:
> > On 03/20/19 17:27, Eric Biggers wrote:
> > > queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch
> > > causes a build error:
> > >
> > > CC drivers/clocksource/arm_arch_timer.o
> > > drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'?
> > > .read_cntpct_el0 = sun50i_a64_read_cntpct_el0,
> > > ^~~~~~~~~~~~~~~
> > > read_cntvct_el0
> > > make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1
> > > make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2
> >
> > 4.14 looks to be before the kernel switched to using CNTPCT internally, so that
> > hook doesn't exist. The line should be removed. (sun50i_a64_read_cntpct_el0
> > still needs to be there for the .read_cntp_tval_el0 implementation.)
> >
> > Apologies for the breakage,
> > Samuel
>
> I've dropped it from 4.14, thanks all!
I don't see it dropped in the public tree, so I've dropped it for real
now :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-21 5:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 22:27 Build error in 4.14 stable-queue Eric Biggers
2019-03-20 23:50 ` Samuel Holland
2019-03-21 0:28 ` Sasha Levin
2019-03-21 5:27 ` Greg Kroah-Hartman [this message]
2019-03-21 13:51 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321052722.GB21413@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ebiggers@kernel.org \
--cc=samuel@sholland.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.