From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/amd/powerplay: delete some dead code Date: Thu, 21 Mar 2019 09:27:07 +0300 Message-ID: <20190321062707.GB21489@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher Cc: "David (ChunMing) Zhou" , Chengming Gui , David Airlie , Kevin Wang , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Huang Rui , Daniel Vetter , Likun Gao , Christian =?iso-8859-1?Q?K=F6nig?= VGhlICJzaXplIiB2YXJpYWJsZSBpcyB1bnNpZ25lZC4gIFdlIG5ldmVyIHBhc3MgaW52YWxpZCBz aXplcyB0byB0aGlzCmZ1bmN0aW9uIGFuZCB3ZSBhbHJlYWR5IHVzZWQgaXQgYXMgYW4gYXJyYXkg b2Zmc2V0IGVhcmxpZXIgc28gaXQncwp0b28gbGF0ZSB0byBjaGVjayBoZXJlLgoKU2lnbmVkLW9m Zi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgotLS0KIGRyaXZl cnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L3NtdV92MTFfMC5jIHwgMyAtLS0KIDEgZmlsZSBjaGFu Z2VkLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93 ZXJwbGF5L3NtdV92MTFfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvc211X3Yx MV8wLmMKaW5kZXggMTcxNDM4ODhlMzdlLi5iNjAyOTc1NTYzZmMgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L3NtdV92MTFfMC5jCisrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvcG93ZXJwbGF5L3NtdV92MTFfMC5jCkBAIC0xNjY4LDkgKzE2NjgsNiBAQCBzdGF0aWMg aW50IHNtdV92MTFfMF9zZXRfcG93ZXJfcHJvZmlsZV9tb2RlKHN0cnVjdCBzbXVfY29udGV4dCAq c211LCBsb25nICppbnB1dAogCX0KIAogCWlmIChzbXUtPnBvd2VyX3Byb2ZpbGVfbW9kZSA9PSBQ UF9TTUNfUE9XRVJfUFJPRklMRV9DVVNUT00pIHsKLQkJaWYgKHNpemUgPCAwKQotCQkJcmV0dXJu IC1FSU5WQUw7Ci0KIAkJcmV0ID0gc211X3YxMV8wX2dldF9hY3Rpdml0eV9tb25pdG9yX2NvZWZm KHNtdSwKIAkJCQkJCQkgICAodWludDhfdCAqKSgmYWN0aXZpdHlfbW9uaXRvciksCiAJCQkJCQkJ ICAgV09SS0xPQURfUFBMSUJfQ1VTVE9NX0JJVCk7Ci0tIAoyLjE3LjEKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFt ZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 21 Mar 2019 06:27:07 +0000 Subject: [PATCH] drm/amd/powerplay: delete some dead code Message-Id: <20190321062707.GB21489@kadam> List-Id: References: <20180206123500.GA9203@mwanda> In-Reply-To: <20180206123500.GA9203@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Deucher Cc: "David (ChunMing) Zhou" , Chengming Gui , David Airlie , Kevin Wang , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Huang Rui , Daniel Vetter , Likun Gao , Christian =?iso-8859-1?Q?K=F6nig?= The "size" variable is unsigned. We never pass invalid sizes to this function and we already used it as an array offset earlier so it's too late to check here. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c index 17143888e37e..b602975563fc 100644 --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c @@ -1668,9 +1668,6 @@ static int smu_v11_0_set_power_profile_mode(struct smu_context *smu, long *input } if (smu->power_profile_mode = PP_SMC_POWER_PROFILE_CUSTOM) { - if (size < 0) - return -EINVAL; - ret = smu_v11_0_get_activity_monitor_coeff(smu, (uint8_t *)(&activity_monitor), WORKLOAD_PPLIB_CUSTOM_BIT); -- 2.17.1