Re: [PATCH] [Outreachy kernel] staging: sm750fb: avoid camelcase

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Mar 21, 2019 at 11:21:15AM +0530, Payal Kshirsagar wrote:
> Eliminate camelcase to meet the style.

Meet what style?

> 
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_mode.c | 94 +++++++++++++++++------------------
>  1 file changed, 47 insertions(+), 47 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 4dac691..5dfa87d 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -13,13 +13,13 @@
>   * HW only supports 7 predefined pixel clocks, and clock select is
>   * in bit 29:27 of Display Control register.
>   */
> -static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> -						  unsigned long dispControl)
> +static unsigned long display_control_adjust_SM750LE(struct mode_parameter *p_mode_param,
> +						    unsigned long disp_control)

Try doing only one type of fix per patch.

One to fix up structure fields, and then another one for function names.
Putting them all together makes it very hard to review.  This should be
a patch series for this type of fix.

thanks,

greg k-h