[PATCH] [Outreachy kernel] staging: emxx_udc: lines should not end with parenthesis

[PATCH] [Outreachy kernel] staging: emxx_udc: lines should not end with parenthesis

[Payal Kshirsagar]

Adjust code to meet the style of “lines should not end with
parenthesis”.
In file named as drivers/staging/emxx_udc/emxx_udc.c

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/emxx_udc/emxx_udc.c | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index b960a21..743a519 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -459,22 +459,22 @@ static void _nbu2ss_dma_map_single(struct nbu2ss_udc *udc,
 		if (req->unaligned) {
 			req->req.dma = ep->phys_buf;
 		} else {
-			req->req.dma = dma_map_single(
-				udc->gadget.dev.parent,
-				req->req.buf,
-				req->req.length,
-				(direct == USB_DIR_IN)
-				? DMA_TO_DEVICE : DMA_FROM_DEVICE);
+			req->req.dma = dma_map_single(udc->gadget.dev.parent,
+						      req->req.buf,
+						      req->req.length,
+						      (direct == USB_DIR_IN)
+						      ? DMA_TO_DEVICE
+						      : DMA_FROM_DEVICE);
 		}
 		req->mapped = 1;
 	} else {
 		if (!req->unaligned)
-			dma_sync_single_for_device(
-				udc->gadget.dev.parent,
-				req->req.dma,
-				req->req.length,
-				(direct == USB_DIR_IN)
-				? DMA_TO_DEVICE : DMA_FROM_DEVICE);
+			dma_sync_single_for_device(udc->gadget.dev.parent,
+						   req->req.dma,
+						   req->req.length,
+						   (direct == USB_DIR_IN)
+						   ? DMA_TO_DEVICE
+						   : DMA_FROM_DEVICE);
 
 		req->mapped = 0;
 	}
@@ -1414,8 +1414,8 @@ static inline int _nbu2ss_req_feature(struct nbu2ss_udc *udc, bool bset)
 			if (selector == USB_ENDPOINT_HALT) {
 				ep_adrs = wIndex & 0xFF;
 				if (!bset) {
-					_nbu2ss_endpoint_toggle_reset(
-						udc, ep_adrs);
+					_nbu2ss_endpoint_toggle_reset(udc,
+								      ep_adrs);
 				}
 
 				_nbu2ss_set_endpoint_stall(udc, ep_adrs, bset);
@@ -2594,9 +2594,9 @@ static int nbu2ss_ep_queue(struct usb_ep *_ep,
 
 	if (req->unaligned) {
 		if (!ep->virt_buf)
-			ep->virt_buf = dma_alloc_coherent(
-				NULL, PAGE_SIZE,
-				&ep->phys_buf, GFP_ATOMIC | GFP_DMA);
+			ep->virt_buf = dma_alloc_coherent(NULL, PAGE_SIZE,
+							  &ep->phys_buf,
+							  GFP_ATOMIC | GFP_DMA);
 		if (ep->epnum > 0)  {
 			if (ep->direct == USB_DIR_IN)
 				memcpy(ep->virt_buf, req->req.buf,
-- 
2.7.4

Re: [PATCH] [Outreachy kernel] staging: emxx_udc: lines should not end with parenthesis

[Greg KH]

On Thu, Mar 21, 2019 at 10:07:50AM +0530, Payal Kshirsagar wrote:
> Adjust code to meet the style of “lines should not end with
> parenthesis”.
> In file named as drivers/staging/emxx_udc/emxx_udc.c

I do not understand this sentance.

We know what file is being changed, you said so in the subject line.  So
I do not think this is needed.

Please fix up and resend.

thanks,

greg k-h

Re: [PATCH] [Outreachy kernel] staging: emxx_udc: lines should not end with parenthesis

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

On Thu, 21 Mar 2019 at 12:49, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Thu, Mar 21, 2019 at 10:07:50AM +0530, Payal Kshirsagar wrote:
> > Adjust code to meet the style of “lines should not end with
> > parenthesis”.
> > In file named as drivers/staging/emxx_udc/emxx_udc.c
>
> I do not understand this sentance.
>
> We know what file is being changed, you said so in the subject line.  So
> I do not think this is needed.
>
> Please fix up and resend.
>
> okay, i will send v2 for this patch.
payal

> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 1068 bytes --]