From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aditya Pakki <pakki001@umn.edu>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nathan Chancellor <natechancellor@gmail.com>,
kjlu@umn.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc
Date: Thu, 21 Mar 2019 10:20:40 +0300 [thread overview]
Message-ID: <20190321072039.GI2202@kadam> (raw)
In-Reply-To: <20190319201509.16252-1-pakki001@umn.edu>
On Tue, Mar 19, 2019 at 03:15:08PM -0500, Aditya Pakki wrote:
> phydm.internal is allocated using kzalloc which is used multiple
> times without a check for NULL pointer. This patch avoids such a
> scenario.
>
> --
> v1: Patch collision with different things, fix as per Greg
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
Gar... Sorry, no, that's not quite right. It should be:
blah blah blah...
Signed-off-by: you
---
V1: Patch collision with different things, fix as per Greg
Try applying your patch with `cat raw_email.txt | git am` and you'll see
the problem with the commit message.
regards,
dan carpenter
prev parent reply other threads:[~2019-03-21 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 20:15 [PATCH v2] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc Aditya Pakki
2019-03-20 7:23 ` Greg Kroah-Hartman
2019-03-21 7:20 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321072039.GI2202@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.