Re: [PATCH 1/2] drm/i915: Add missing scanline case for 8 cpp watermarks.

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Mar 21, 2019 at 10:15:45AM +0100, Maarten Lankhorst wrote:
> Now that we can rotate 64 bpp formats, we need to add the rotation case.
> This wasn't caught by CI or me, because the rotated formats were skipping
> because the rotated watermarks exceeded the allocation limits.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index fcd3baff8b65..5977dca2c55d 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4689,6 +4689,9 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state,
>  		case 4:
>  			wp->y_min_scanlines = 4;
>  			break;
> +		case 8:
> +			wp->y_min_scanlines = 2;
> +			break;

Spec says n/a here. And indeed the table says 90/270 is not supported
with any 64bpp format.

>  		default:
>  			MISSING_CASE(wp->cpp);
>  			return -EINVAL;
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx