From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97740C43381 for ; Thu, 21 Mar 2019 13:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59D77218D8 for ; Thu, 21 Mar 2019 13:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553176317; bh=NoxdM54ZKRf7XrL4jvGVmeYxkOsanb0bTEVgt/cgEoU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Zz0r4u/6R0KOzXwIyDwiW+ZT0vOBPGduw4ucuc2Crwn6STKioO0JNALEfBL2BoRmE sDzhkQZOodLgU+9obSMkMKzc/R9sunDck0TiA/lbqiHeu3HG8HWbxs43uTSSRc8paU 5nNYaqRgoKuPncvyeE9R85hdc+ySiq+lSZhZKGhA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727891AbfCUNv4 (ORCPT ); Thu, 21 Mar 2019 09:51:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:60932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbfCUNv4 (ORCPT ); Thu, 21 Mar 2019 09:51:56 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1F2F21874; Thu, 21 Mar 2019 13:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553176316; bh=NoxdM54ZKRf7XrL4jvGVmeYxkOsanb0bTEVgt/cgEoU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iian3Cj//2g5XDy5WMSWO01JXbKOwFe9O3maidWNnNwTh3YqnCN/MZEQOz2x+6fon wPeO1OaxVphm3EdsyLzjB6zIFthoDISkH1R+WJuqc2OItiX+DVY3JPxbhYb59fyZ8J CVnX75SGzUQR4aDqCixA53Es9J7i0jtS2zz+iOh4= Date: Thu, 21 Mar 2019 09:51:54 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: Samuel Holland , Eric Biggers , stable@vger.kernel.org Subject: Re: Build error in 4.14 stable-queue Message-ID: <20190321135154.GF25262@sasha-vm> References: <20190320222726.GA698@sol.localdomain> <20190321002844.GD25262@sasha-vm> <20190321052722.GB21413@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190321052722.GB21413@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Mar 21, 2019 at 06:27:22AM +0100, Greg Kroah-Hartman wrote: >On Wed, Mar 20, 2019 at 08:28:44PM -0400, Sasha Levin wrote: >> On Wed, Mar 20, 2019 at 06:50:00PM -0500, Samuel Holland wrote: >> > On 03/20/19 17:27, Eric Biggers wrote: >> > > queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch >> > > causes a build error: >> > > >> > > CC drivers/clocksource/arm_arch_timer.o >> > > drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'? >> > > .read_cntpct_el0 = sun50i_a64_read_cntpct_el0, >> > > ^~~~~~~~~~~~~~~ >> > > read_cntvct_el0 >> > > make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1 >> > > make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2 >> > >> > 4.14 looks to be before the kernel switched to using CNTPCT internally, so that >> > hook doesn't exist. The line should be removed. (sun50i_a64_read_cntpct_el0 >> > still needs to be there for the .read_cntp_tval_el0 implementation.) >> > >> > Apologies for the breakage, >> > Samuel >> >> I've dropped it from 4.14, thanks all! > >I don't see it dropped in the public tree, so I've dropped it for real >now :) You were not supposed to be awake that early! :p -- Thanks, Sasha