From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49EFDC43381 for ; Thu, 21 Mar 2019 14:10:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16736218B0 for ; Thu, 21 Mar 2019 14:10:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="XSA7w0hE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728512AbfCUOKt (ORCPT ); Thu, 21 Mar 2019 10:10:49 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54845 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728348AbfCUOKr (ORCPT ); Thu, 21 Mar 2019 10:10:47 -0400 Received: by mail-wm1-f68.google.com with SMTP id f3so2920081wmj.4 for ; Thu, 21 Mar 2019 07:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f4Yy8aT4ycVuxQwpiNrF9Jt/1u0alja7ueCVDU3Wfcc=; b=XSA7w0hEGsCuO8dBAvnii+Ng4fmaFPTj7+snfhYC12lXS5uWeU0LjwxAR8d/iOAFAe Mb4fhA+LQ774WVGOnvjH8FZMufnnzmAIwhpr1pmI7gtCNZgUuWTp6IGvosZaku/BK1dx eWyqGoc/5i9iA+k4E1pmNqq3c7EWjvOc1iQA+rg1lgGgQdBoaiyi4xaViZhmsOQYC93Z pCm/pcFsWMwlYET5yoXzFbyzWD44RVUKhtwILA5Xn57royrjmEeXsAUn6+PRQdjRffBm D5/sxdnlQ0BhuKgrAT42EDMdK9Ri2EMDftNPvpeOdSjamqo+7YYefy1VpmdanwHT94iS bNdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f4Yy8aT4ycVuxQwpiNrF9Jt/1u0alja7ueCVDU3Wfcc=; b=YjXueOARGMgbWF6DMcc5dLVLBH1bbKAd+XtKZQfoyH9qWO+q9pispmQtzR8QVnmNkR uyndsVBRj7av9ADPOp2eIuoNNrTzLwbHA9Zv63ECTRMIKUqNDDBATQSuVQ87yZoa3rBU BqBBaXZwW2cTE2dn2svxR9HldIo6TUW/aKZUhwZ/vepJ6SCAsdcS2qA9/H4ktsBxnbIK JvuCNMUi/MErypzNq3iXzBNHKxbJtCiOvSPNdWPChiPcjsXxbzqeh+8g8vmiQXVMbda3 QqQBLfoGG14AdcpQqDedODRoWljCbL2nFbJPlydIAaOvCRHTSG9/G3tCTUD4JtR7FeX8 eSwQ== X-Gm-Message-State: APjAAAXrPZWlWX3gkuNTcfn4+4sx+ZpN8C9JzjmsHoFoPkgW6PAJOFga C5eri2RCLWBpxPd3q6YltObpEcbgWGA= X-Google-Smtp-Source: APXvYqwlKkBSCmjjreR+9pWEK3P/7hj+gapQAPoZ2sRxGOVAd5/mTbMZuZzINnsYX34LXDjlvJVDoA== X-Received: by 2002:a1c:7a03:: with SMTP id v3mr2616193wmc.59.1553177445509; Thu, 21 Mar 2019 07:10:45 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id m6sm8942198wrr.53.2019.03.21.07.10.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 07:10:45 -0700 (PDT) Date: Thu, 21 Mar 2019 15:00:05 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, sbrivio@redhat.com Subject: Re: [PATCH net-next v3 03/12] net: sched: flower: introduce reference counting for filters Message-ID: <20190321140005.GK2087@nanopsycho> References: <20190321131744.19224-1-vladbu@mellanox.com> <20190321131744.19224-4-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321131744.19224-4-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Mar 21, 2019 at 02:17:35PM CET, vladbu@mellanox.com wrote: >Extend flower filters with reference counting in order to remove dependency >on rtnl lock in flower ops and allow to modify filters concurrently. >Reference to flower filter can be taken/released concurrently as soon as it >is marked as 'unlocked' by last patch in this series. Use atomic reference >counter type to make concurrent modifications safe. > >Always take reference to flower filter while working with it: >- Modify fl_get() to take reference to filter. >- Implement tp->put() callback as fl_put() function to allow cls API to >release reference taken by fl_get(). >- Modify fl_change() to assume that caller holds reference to fold and take >reference to fnew. >- Take reference to filter while using it in fl_walk(). > >Implement helper functions to get/put filter reference counter. > >Signed-off-by: Vlad Buslov >Reviewed-by: Stefano Brivio Acked-by: Jiri Pirko