From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7049C43381 for ; Thu, 21 Mar 2019 14:19:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45B6E218E2 for ; Thu, 21 Mar 2019 14:19:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="HW58ETGM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728249AbfCUOTo (ORCPT ); Thu, 21 Mar 2019 10:19:44 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40512 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728013AbfCUOTn (ORCPT ); Thu, 21 Mar 2019 10:19:43 -0400 Received: by mail-wr1-f66.google.com with SMTP id t5so6781368wri.7 for ; Thu, 21 Mar 2019 07:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=02UWJtIx+WinWc14uQJfZmt37+0B/IRI/5oeralGKi4=; b=HW58ETGMFyNWDD/JB+X7iwTSH2LXKzENYpj5/GwhnKbT7JfBWwdTnIbmJqIbvgAhsc 1qU4njwklC10D3TTLzz0/SZ0eIrdOchb9A9zQXJptBh9Bh7+r/OZHB5MfSoF/gQet+bT 6oBZ99g5MAIXv/misoG+kBaSTvUWjpONUFdlUdKc660dMkwV/UEnNvuZloUlRiPaYgbh kY5c0wYBnzvbp4yQc5C27+FcyUaCcszgdWoqxZxNuJqffndaReBldPRa12WGrLJIFlnu vuDENzFgQuxW+n5L1aDlx+Q275U8qNZhh9TqWfMboXekMiUBl4s9SJBpn29Vqyn6dBGe Bvng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=02UWJtIx+WinWc14uQJfZmt37+0B/IRI/5oeralGKi4=; b=Lh2Jf02GZ6MHhgu69or6B3a6NVnyLRFHH7liQbSiYqwII8PonClGvnim1dCip11E/3 WGvrttZoIHdlSg31gWGmuewabqBJN3FVP9cZHiEe8Q+WV46PgAnLk67pCMua/rzSoMXs hjx3S8QQ0nE0gaItldt4woI6SZLMMGWxk5IYH0RdxvW/pzGtBqWb/QPjrmdcaSmSXIll hKIGJ/XoOgzpSPKrwuuQaGk1KUU24NiS1Dgu5BG3T1HVtAVA3XUAYVfhHiyPZHl72OjJ EZgscPZSlwrAfRAFyekVHxXTnkRq6CAPMUVC4ekzJVoIibbF+f5fAGn2Xo7NNTbnOLFs ajtQ== X-Gm-Message-State: APjAAAXD3JmcrC+6wf14CoCfTM7cqPSthnYvF7ar3xhLkkkI+gBszcoz Cw/vYS9pVOSuTkumqhKPtrj0siNNDFk= X-Google-Smtp-Source: APXvYqzTYZor2evaUb/nFdPJ28vQX64kpG4InfPRSrZ2QCFE9J1XxjCgYb9kU6Gzb5EVb5R/Nt2g8Q== X-Received: by 2002:adf:face:: with SMTP id a14mr2998443wrs.320.1553177982540; Thu, 21 Mar 2019 07:19:42 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id v2sm3959077wme.29.2019.03.21.07.19.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 07:19:41 -0700 (PDT) Date: Thu, 21 Mar 2019 15:09:02 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, sbrivio@redhat.com Subject: Re: [PATCH net-next v3 10/12] net: sched: flower: protect flower classifier state with spinlock Message-ID: <20190321140902.GN2087@nanopsycho> References: <20190321131744.19224-1-vladbu@mellanox.com> <20190321131744.19224-11-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321131744.19224-11-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Mar 21, 2019 at 02:17:42PM CET, vladbu@mellanox.com wrote: >struct tcf_proto was extended with spinlock to be used by classifiers >instead of global rtnl lock. Use it to protect shared flower classifier >data structures (handle_idr, mask hashtable and list) and fields of >individual filters that can be accessed concurrently. This patch set uses >tcf_proto->lock as per instance lock that protects all filters on >tcf_proto. > >Signed-off-by: Vlad Buslov >Reviewed-by: Stefano Brivio Acked-by: Jiri Pirko