From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fabien Dessenne <fabien.dessenne@st.com>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH] tty: fix NULL pointer issue when tty_port ops is not set
Date: Thu, 21 Mar 2019 18:38:47 +0100 [thread overview]
Message-ID: <20190321173847.GA7032@kroah.com> (raw)
In-Reply-To: <1553183006-12820-1-git-send-email-fabien.dessenne@st.com>
On Thu, Mar 21, 2019 at 04:43:26PM +0100, Fabien Dessenne wrote:
> Unlike 'client_ops' which is initialized to 'default_client_ops', the
> port operations 'ops' may be left to NULL.
> Check the 'ops' value before checking the 'ops->x' value.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
> drivers/tty/tty_port.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
> index 044c3cb..a9e12b3 100644
> --- a/drivers/tty/tty_port.c
> +++ b/drivers/tty/tty_port.c
> @@ -325,7 +325,7 @@ static void tty_port_shutdown(struct tty_port *port, struct tty_struct *tty)
> if (tty && C_HUPCL(tty))
> tty_port_lower_dtr_rts(port);
>
> - if (port->ops->shutdown)
> + if (port->ops && port->ops->shutdown)
> port->ops->shutdown(port);
> }
> out:
> @@ -398,7 +398,7 @@ EXPORT_SYMBOL_GPL(tty_port_tty_wakeup);
> */
> int tty_port_carrier_raised(struct tty_port *port)
> {
> - if (port->ops->carrier_raised == NULL)
> + if (!port->ops || !port->ops->carrier_raised)
> return 1;
> return port->ops->carrier_raised(port);
> }
> @@ -414,7 +414,7 @@ EXPORT_SYMBOL(tty_port_carrier_raised);
> */
> void tty_port_raise_dtr_rts(struct tty_port *port)
> {
> - if (port->ops->dtr_rts)
> + if (port->ops && port->ops->dtr_rts)
> port->ops->dtr_rts(port, 1);
> }
> EXPORT_SYMBOL(tty_port_raise_dtr_rts);
> @@ -429,7 +429,7 @@ EXPORT_SYMBOL(tty_port_raise_dtr_rts);
> */
> void tty_port_lower_dtr_rts(struct tty_port *port)
> {
> - if (port->ops->dtr_rts)
> + if (port->ops && port->ops->dtr_rts)
> port->ops->dtr_rts(port, 0);
> }
> EXPORT_SYMBOL(tty_port_lower_dtr_rts);
> @@ -684,7 +684,7 @@ int tty_port_open(struct tty_port *port, struct tty_struct *tty,
>
> if (!tty_port_initialized(port)) {
> clear_bit(TTY_IO_ERROR, &tty->flags);
> - if (port->ops->activate) {
> + if (port->ops && port->ops->activate) {
> int retval = port->ops->activate(port, tty);
> if (retval) {
> mutex_unlock(&port->mutex);
> --
> 2.7.4
>
Can you hit this today with any in-kernel drivers? Or is this only for
your new code you are adding?
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-21 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 15:43 [PATCH] tty: fix NULL pointer issue when tty_port ops is not set Fabien Dessenne
2019-03-21 17:38 ` Greg Kroah-Hartman [this message]
2019-03-22 8:35 ` Fabien DESSENNE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321173847.GA7032@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benjamin.gaignard@st.com \
--cc=fabien.dessenne@st.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.