Re: [PATCH] staging: rtl8192e: fix line over 80 caharacters

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Mar 21, 2019 at 11:29:55PM +0530, anushkacharu9@gmail.com wrote:
> From: Anushka Shukla <anushkacharu9@gmail.com>
> 
>  -Fix line over 80 character issue in dot11d.c file 
>  -Define a new variable tri_first_channel of u8  data type. 
>  -Assign triple->first_channel as tri_first_channel
> 
> Signed-off-by: Anushka Shukla <anushkacharu9@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c
> index 68f53013cb95..62f34b38be21 100644
> --- a/drivers/staging/rtl8192e/dot11d.c
> +++ b/drivers/staging/rtl8192e/dot11d.c
> @@ -140,12 +140,13 @@ void dot11d_update_country(struct rtllib_device *dev, u8 *address,
>  				    __func__);
>  			return;
>  		}
> +		u8 tri_first_channel = triple->first_channel;

How about just "first_channel"?

Makes more sense, "tri_" isn't that descriptive here.

But, you need to actually build this code and notice how you have a
build warning, that's not ok :(

thanks,

greg k-h