Re: [PATCH 2/3] [Outreachy kernel] staging: sm750fb: avoid camelcase structure fields

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Mar 21, 2019 at 04:41:49PM +0530, Payal Kshirsagar wrote:
> Eliminate camelcase structure fields to fix the style issue – ‘avoid
> camelcase’.
> 
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_mode.c | 52 +++++++++++++++++------------------
>  1 file changed, 26 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 5e35fec..b55cd96 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -13,13 +13,13 @@
>   * HW only supports 7 predefined pixel clocks, and clock select is
>   * in bit 29:27 of Display Control register.
>   */
> -static unsigned long display_control_adjust_SM750LE(struct mode_parameter *pModeParam,
> +static unsigned long display_control_adjust_SM750LE(struct mode_parameter *p_mode_param,

Why did you put "p_" as the prefix here?

The original code is trying to use the horrible Hungarian Notation way
of naming variables (and doing a bad job of it), which is not needed in
the kernel at all.  No need to keep following that, this should just be
"mode_param", right?  We "know" it is a pointer by virtue that the
compiler will tell us if we get it wrong.

thanks,

greg k-h