From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Thu, 21 Mar 2019 22:33:13 +0100
Subject: [Buildroot] [PATCH v1] package/qt5base: fix xkbcommon option
In-Reply-To: <20190321212323.22920-1-ps.report@gmx.net>
References: <20190321212323.22920-1-ps.report@gmx.net>
Message-ID: <20190321213313.GC2660@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Peter, All,

On 2019-03-21 22:23 +0100, Peter Seiderer spake thusly:
> - Qt 5.6: according to configure --help the command line option to
>   enable x11 xkbcommon support is '-system-xkbcommon-x11'
> 
> - Qt 5.12: according to configure --help the command line option to
>   enable xkbcommon support is '-xkbcommon'
> 
> Fixes [1]:
> 
>   ERROR: Invalid value given for boolean command line option 'xkbcommon'.
> 
> [1] http://autobuild.buildroot.net/results/87076d03bb92a9940447ca80fc1f202e35ef39da
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/qt5/qt5base/qt5base.mk | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 14536980a8..b0469172c0 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -153,7 +153,13 @@ QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_DIRECTFB),-directfb,-no-dir
>  QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_DIRECTFB),directfb)
> 
>  ifeq ($(BR2_PACKAGE_QT5BASE_XCB),y)
> -QT5BASE_CONFIGURE_OPTS += -xcb -system-xkbcommon
> +QT5BASE_CONFIGURE_OPTS += -xcb
> +ifeq ($(BR2_PACKAGE_QT5_VERSION_5_6),y)
> +QT5BASE_CONFIGURE_OPTS += -xcb -system-xkbcommon-x11
> +else
> +QT5BASE_CONFIGURE_OPTS += -xcb -xkbcommon

Two things:

 1. -xcb is passed twice: once uncoditionally on the Qt version, and
    once for each Qt version;

 2. The build failure you reference is about a qt-5.12 build, which
    complains about an "Invalid value given for boolean command line
    option 'xkbcommon'".

So, it looks like qt-5.12 does not linke -xkbcommon, but this is exactly
what you are passing with this patch...

Did I misunderstand something?

Cordialement,
Yann E. MORIN.

> +endif
> +
>  QT5BASE_DEPENDENCIES   += \
>  	libxcb \
>  	xcb-util-wm \
> --
> 2.21.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'