From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=++q7=RY=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D1AE9C43381
	for <netdev@archiver.kernel.org>; Thu, 21 Mar 2019 23:01:23 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 7A96E21917
	for <netdev@archiver.kernel.org>; Thu, 21 Mar 2019 23:01:23 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="d/ZHak8W"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726891AbfCUXBW (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 21 Mar 2019 19:01:22 -0400
Received: from mail.nic.cz ([217.31.204.67]:39234 "EHLO mail.nic.cz"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725999AbfCUXBW (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 21 Mar 2019 19:01:22 -0400
Received: from localhost (unknown [172.20.6.218])
        by mail.nic.cz (Postfix) with ESMTPS id 74FFD63514;
        Fri, 22 Mar 2019 00:01:20 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default;
        t=1553209280; bh=pd2XOz/WYQtmWRe251KB0RXHY3AUl+nNrCp5dmkh4mI=;
        h=Date:From:To;
        b=d/ZHak8WIBkqnJAkmi6Xs5q+uzvRVVj8/xHBrFR6eDMXv+VciYqV87owVGmgTbreY
         wTdyDgUjrAm3MPPRwd8BrUgAQzSLZmX5B1PULNVM7Lb3vvEEJvpPmI3oZM0lQWqF6Z
         IC2GEearpajM0MP22o697v74zvnRv/t25eSdC/sQ=
Date:   Fri, 22 Mar 2019 00:01:20 +0100
From:   Marek Behun <marek.behun@nic.cz>
To:     Christian Lamparter <chunkeey@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Michal =?UTF-8?B?Vm9rw6HEjQ==?= <vokac.m@gmail.com>,
        John Crispin <john@phrozen.org>,
        Wei Yongjun <weiyongjun1@huawei.com>
Subject: Re: [PATCH net-next 1/1] net: dsa: qca8k: Fix internal PHY MDIO
 address
Message-ID: <20190322000120.7a87fde5@nic.cz>
In-Reply-To: <2275278.j5OWp99DLc@debian64>
References: <20190321182319.10664-1-marek.behun@nic.cz>
        <4f2160f2-28f1-bd61-86ee-3db77fd67ba4@gmail.com>
        <20190321205555.358eaaee@nic.cz>
        <2275278.j5OWp99DLc@debian64>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: clamav-milter 0.99.2 at mail
X-Virus-Status: Clean
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> Hm, it's not really a "external mode". But let's try one more time.
> The idea is that if an external mdio-bus (from the SoC) has already
> registered the PHY 0x0 - 0x4 from the QCA8337, the qca8k should not
> expose the same PHYs as it's own mdio-bus because then the PHYs end
> up being registered twice.

Hi,
yes, I understand this bit. What I was talking about was that the MDIO
addresses of internal PHYs are 0 to 4, it does not matter if you access
them via switch or directly. But the current code for direct access is
using addresses 1 to 5, which does not work at all. It should also
substract 1 from the port number.

Marek