From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] rtc: omap: checkpatch cleanup
Date: Fri, 22 Mar 2019 07:35:13 +0100 [thread overview]
Message-ID: <20190322063513.GX29054@piout.net> (raw)
In-Reply-To: <20190320133153.GH15782@localhost>
On 20/03/2019 14:31:53+0100, Johan Hovold wrote:
> On Wed, Mar 20, 2019 at 01:45:35PM +0100, Alexandre Belloni wrote:
> > Properly align code with opening parenthesis.
>
> FWIW, this is a checkpatch --strict warning you're addressing, and not
> something that is enforced by the coding standard.
>
> Indenting continuation lines at least two tabs further conforms with the
> coding style which says to indent lines substantially to the right (and
> you don't have to run around realigning things should a function call be
> renamed, etc).
>
> But your call.
>
That's fine, I can drop that one.
> Johan
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-03-22 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 12:45 [PATCH 1/3] rtc: omap: switch to rtc_time64_to_tm/rtc_tm_to_time64 Alexandre Belloni
2019-03-20 12:45 ` [PATCH 2/3] rtc: omap: convert to SPDX identifier Alexandre Belloni
2019-03-20 12:45 ` [PATCH 3/3] rtc: omap: checkpatch cleanup Alexandre Belloni
2019-03-20 13:31 ` Johan Hovold
2019-03-22 6:35 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322063513.GX29054@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.