From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F412FC43381 for ; Fri, 22 Mar 2019 11:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2E242192C for ; Fri, 22 Mar 2019 11:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253957; bh=dVB8mm9g7TXmk6jyHWAgK5L53uSn/G/vQak8mKzg7kA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=04y62xRNPEIhJy7hYaTjb89IU/XwShkmRYfQwY4TVxf3ypy/KgFf+YzK96VvWBQYP LV+oXp5SM8NZWCkyIMb1o5z4uy6CFMK7v7ILxk3+zhaEgY3Iw3gxVtLMqmntEEF+Ik YwhxCN2DgUpBwpSrFvFxU/HjpAqrNfF14KAnD/64= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729363AbfCVLZ4 (ORCPT ); Fri, 22 Mar 2019 07:25:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:53512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728732AbfCVLZz (ORCPT ); Fri, 22 Mar 2019 07:25:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23CBF21916; Fri, 22 Mar 2019 11:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253954; bh=dVB8mm9g7TXmk6jyHWAgK5L53uSn/G/vQak8mKzg7kA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pgTzBGBGF+r07d4F53nKd2IBib3fWqdTMqEHwFLQPxq3bjpB10ZE87rYn5p7xxWdz QTpQhe8sBVuyN8D2mEdu3uPsG2/ZTWI3lzz2eAIp7CnASFP0lGOhlch+bQLwxW8AnG U1cPLzdkW/Fq+yLFqNQ82UEQYPXI+qzLXCiPLFUQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Cox , QiaoChong , Sudip Mukherjee Subject: [PATCH 3.18 122/134] parport_pc: fix find_superio io compare code, should use equal test. Date: Fri, 22 Mar 2019 12:15:35 +0100 Message-Id: <20190322111219.245634038@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: QiaoChong commit 21698fd57984cd28207d841dbdaa026d6061bceb upstream. In the original code before 181bf1e815a2 the loop was continuing until it finds the first matching superios[i].io and p->base. But after 181bf1e815a2 the logic changed and the loop now returns the pointer to the first mismatched array element which is then used in get_superio_dma() and get_superio_irq() and thus returning the wrong value. Fix the condition so that it now returns the correct pointer. Fixes: 181bf1e815a2 ("parport_pc: clean up the modified while loops using for") Cc: Alan Cox Cc: stable@vger.kernel.org Signed-off-by: QiaoChong [rewrite the commit message] Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/parport/parport_pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/parport/parport_pc.c +++ b/drivers/parport/parport_pc.c @@ -1377,7 +1377,7 @@ static struct superio_struct *find_super { int i; for (i = 0; i < NR_SUPERIOS; i++) - if (superios[i].io != p->base) + if (superios[i].io == p->base) return &superios[i]; return NULL; }