From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E43C43381 for ; Fri, 22 Mar 2019 13:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 428C521873 for ; Fri, 22 Mar 2019 13:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553260560; bh=q0yXjPaSgnFacPwb7WXEtdBd/iRw1KfJqtoZtL80xSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hCAWOJD4V6hoiar0zRFe+HJZw2oCFEfFBZX/bXHuvdWkLF76lhh+XtG1Y1Md3xbye cBBTGPIH8eVY18H/Rv4QkxoRyFK3aYIlBsGGsa5paJwOni7hYzQGI3f+49vCvackKp ZIzuCWpezeBhhzBec+j9NFLJXd0cQENQ5My30N90= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729590AbfCVNP6 (ORCPT ); Fri, 22 Mar 2019 09:15:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:55252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728703AbfCVL1b (ORCPT ); Fri, 22 Mar 2019 07:27:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 17786218A2; Fri, 22 Mar 2019 11:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553254050; bh=q0yXjPaSgnFacPwb7WXEtdBd/iRw1KfJqtoZtL80xSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y9C2x0PpCqfU2xT1HHqB68QOkwA/WVQEvavOdfLNd5fSt35SpiexsPZhcVPP2uXbK jrUyL38UYPugJRg1X417rGQukSRYhwI/t0F1C8FsRPTz7k+S2N6ePs+Fuw5jB6e1uT oYa2f0VRWB6RecvkdsVawBEvFu0oNXGpAXVl1rcU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 017/230] atm: he: fix sign-extension overflow on large shift Date: Fri, 22 Mar 2019 12:12:35 +0100 Message-Id: <20190322111237.966968897@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111236.796964179@linuxfoundation.org> References: <20190322111236.796964179@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit cb12d72b27a6f41325ae23a11033cf5fedfa1b97 ] Shifting the 1 by exp by an int can lead to sign-extension overlow when exp is 31 since 1 is an signed int and sign-extending this result to an unsigned long long will set the upper 32 bits. Fix this by shifting an unsigned long. Detected by cppcheck: (warning) Shifting signed 32-bit value by 31 bits is undefined behaviour Signed-off-by: Colin Ian King Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/he.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 0f5cb37636bcc..010581e8bee05 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -717,7 +717,7 @@ static int he_init_cs_block_rcm(struct he_dev *he_dev) instead of '/ 512', use '>> 9' to prevent a call to divdu3 on x86 platforms */ - rate_cps = (unsigned long long) (1 << exp) * (man + 512) >> 9; + rate_cps = (unsigned long long) (1UL << exp) * (man + 512) >> 9; if (rate_cps < 10) rate_cps = 10; /* 2.2.1 minimum payload rate is 10 cps */ -- 2.19.1