From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 663ABC43381 for ; Fri, 22 Mar 2019 12:54:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29DC72082C for ; Fri, 22 Mar 2019 12:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553259242; bh=bTra26YYqtWRHazsgSPPBqhN2gEfQHJapYGNheFuoC4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PtuzQ5z82jTwS+4dGsSmA1nX7GvvKOVc66bLcLaZ1R/WlEl9BySkhFI5FVu6wLpeX vFO6MC3UVhPzLJSuIpsOQXJOwyEunRlMw7K7BGbtbpSUI2czOOgNRja1uSda8sA95p vLhd4e9uzSIzsxviB3UvTgkeBWrbaOeJcvZSXEAo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732566AbfCVLvb (ORCPT ); Fri, 22 Mar 2019 07:51:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:55326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732293AbfCVLvZ (ORCPT ); Fri, 22 Mar 2019 07:51:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFBF120850; Fri, 22 Mar 2019 11:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553255485; bh=bTra26YYqtWRHazsgSPPBqhN2gEfQHJapYGNheFuoC4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UDMesj8K1XBKq9dL6515SuEMv6Ohuz7Jev6YyNDfRsywQHFilRJfDaXxhzUpbvSJu +DWN4+D1KhA40sP1FP/LnYqjZo/J7j40gBz4JdZnu94J8OStmiUgGUfsOFAmWWzA7s HSuqS/DcOytHz/NPBYcwX9ZfGY2qkLTrZVxCeBd8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lubomir Rintel , Steve deRosier , Kalle Valo Subject: [PATCH 4.14 106/183] libertas_tf: dont set URB_ZERO_PACKET on IN USB transfer Date: Fri, 22 Mar 2019 12:15:34 +0100 Message-Id: <20190322111249.376554164@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111241.819468003@linuxfoundation.org> References: <20190322111241.819468003@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lubomir Rintel commit 607076a904c435f2677fadaadd4af546279db68b upstream. It doesn't make sense and the USB core warns on each submit of such URB, easily flooding the message buffer with tracebacks. Analogous issue was fixed in regular libertas driver in commit 6528d8804780 ("libertas: don't set URB_ZERO_PACKET on IN USB transfer"). Cc: stable@vger.kernel.org Signed-off-by: Lubomir Rintel Reviewed-by: Steve deRosier Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c +++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c @@ -433,8 +433,6 @@ static int __if_usb_submit_rx_urb(struct skb_tail_pointer(skb), MRVDRV_ETH_RX_PACKET_BUFFER_SIZE, callbackfn, cardp); - cardp->rx_urb->transfer_flags |= URB_ZERO_PACKET; - lbtf_deb_usb2(&cardp->udev->dev, "Pointer for rx_urb %p\n", cardp->rx_urb); ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC);