From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH 4.14 130/183] drm/i915: Relax mmap VMA check Date: Fri, 22 Mar 2019 12:15:58 +0100 Message-ID: <20190322111251.164509439@linuxfoundation.org> References: <20190322111241.819468003@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id D27026E352 for ; Fri, 22 Mar 2019 11:52:44 +0000 (UTC) In-Reply-To: <20190322111241.819468003@linuxfoundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: linux-kernel@vger.kernel.org Cc: Sasha Levin , Greg Kroah-Hartman , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Akash Goel , Guenter Roeck , Adam Zabrocki List-Id: intel-gfx@lists.freedesktop.org NC4xNC1zdGFibGUgcmV2aWV3IHBhdGNoLiAgSWYgYW55b25lIGhhcyBhbnkgb2JqZWN0aW9ucywg cGxlYXNlIGxldCBtZSBrbm93LgoKLS0tLS0tLS0tLS0tLS0tLS0tCgpbIFVwc3RyZWFtIGNvbW1p dCBjYTIyZjMyYTYyOTZjYmZhMjlkZTU2MzI4Yzg1MDU1NjBhMThjZmE4IF0KCkxlZ2FjeSBiZWhh dmlvdXIgd2FzIHRvIGFsbG93IG5vbi1wYWdlLWFsaWduZWQgbW1hcCByZXF1ZXN0cywgYXMgZG9l cyB0aGUKbGludXggbW1hcCgyKSBpbXBsZW1lbnRhdGlvbiBieSB2aXJ0dWUgb2YgYXV0b21hdGlj YWxseSByb3VuZGluZyB1cCBmb3IKdGhlIGNhbGxlci4KClRvIGF2b2lkIGJyZWFraW5nIGxlZ2Fj eSB1c2Vyc3BhY2UgcmVsYXggdGhlIG5ld2x5IGludHJvZHVjZWQgZml4LgoKU2lnbmVkLW9mZi1i eTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KRml4ZXM6IDVjNDYw NGU3NTdiYSAoImRybS9pOTE1OiBQcmV2ZW50IGEgcmFjZSBkdXJpbmcgSTkxNV9HRU1fTU1BUCBp b2N0bCB3aXRoIFdDIHNldCIpClJlcG9ydGVkLWJ5OiBHdWVudGVyIFJvZWNrIDxsaW51eEByb2Vj ay11cy5uZXQ+CkNjOiBBZGFtIFphYnJvY2tpIDxhZGFtemFAbWljcm9zb2Z0LmNvbT4KQ2M6IEpv b25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KQ2M6IDxzdGFi bGVAdmdlci5rZXJuZWwub3JnPiAjIHY0LjArCkNjOiBBa2FzaCBHb2VsIDxha2FzaC5nb2VsQGlu dGVsLmNvbT4KQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgpDYzog SmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KQ2M6IFJvZHJpZ28gVml2 aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KQ2M6IGludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr PgpMaW5rOiBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMjAx OTAzMDUxMTA0MDkuMjg2MzMtMS10dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20KKGNoZXJy eSBwaWNrZWQgZnJvbSBjb21taXQgYTkwZTE5NDhlZmI2NDhmNTY3NDQ0Zjg3ZjNjMTliMmEwNzg3 YWZmZCkKU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PgpTaWduZWQtb2ZmLWJ5OiBTYXNoYSBMZXZpbiA8c2FzaGFsQGtlcm5lbC5vcmc+Ci0tLQogZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8ICAgIDMgKystCiAxIGZpbGUgY2hhbmdlZCwg MiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgotLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKQEAgLTE2 NDAsNyArMTY0MCw4IEBAIF9fdm1hX21hdGNoZXMoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEK IAlpZiAodm1hLT52bV9maWxlICE9IGZpbHApCiAJCXJldHVybiBmYWxzZTsKIAotCXJldHVybiB2 bWEtPnZtX3N0YXJ0ID09IGFkZHIgJiYgKHZtYS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCkgPT0g c2l6ZTsKKwlyZXR1cm4gdm1hLT52bV9zdGFydCA9PSBhZGRyICYmCisJICAgICAgICh2bWEtPnZt X2VuZCAtIHZtYS0+dm1fc3RhcnQpID09IFBBR0VfQUxJR04oc2l6ZSk7CiB9CiAKIC8qKgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02820C43381 for ; Fri, 22 Mar 2019 11:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8BC52195D for ; Fri, 22 Mar 2019 11:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553255568; bh=+J2GXQYH3DJQlABn1ySJMtSO/dLH2hMhgpR36Z2sIlc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gaSsc1X141/4qJJwSsrw6SPAqHbzI6/Nkudc1dDttt94JVM78ph6pUpCMauqOKbtP VlZxtbF1vpny0JLJwRYLJFt6GTTRbYfp3URUUORyY+WiQ5W8P3uEbLmfHGVmPLpqyF vZrL8UCno8tHkM5Pd/M9i2BVN/3xtWVqzJB1zijw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732955AbfCVLwr (ORCPT ); Fri, 22 Mar 2019 07:52:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:56798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732578AbfCVLwp (ORCPT ); Fri, 22 Mar 2019 07:52:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3493520693; Fri, 22 Mar 2019 11:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553255564; bh=+J2GXQYH3DJQlABn1ySJMtSO/dLH2hMhgpR36Z2sIlc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yKeqi6SEnwfyZJrRaYmoCBDGB+IHxEr/uY/weUzNDSjgsK9UwlYjBpe0r3dua1NJc 2c3h+75k68ZRG7B4VMe9Jz8Eu0Am7ILbc/QWcrhkW3MJE0ZaGnH0FTXC5QxyGyV1FM rWUfwiHiwTZTDiYvfxmaI1YLgee/jKayM9drMPY8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tvrtko Ursulin , Guenter Roeck , Adam Zabrocki , Joonas Lahtinen , Akash Goel , Chris Wilson , Jani Nikula , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Sasha Levin Subject: [PATCH 4.14 130/183] drm/i915: Relax mmap VMA check Date: Fri, 22 Mar 2019 12:15:58 +0100 Message-Id: <20190322111251.164509439@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111241.819468003@linuxfoundation.org> References: <20190322111241.819468003@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit ca22f32a6296cbfa29de56328c8505560a18cfa8 ] Legacy behaviour was to allow non-page-aligned mmap requests, as does the linux mmap(2) implementation by virtue of automatically rounding up for the caller. To avoid breaking legacy userspace relax the newly introduced fix. Signed-off-by: Tvrtko Ursulin Fixes: 5c4604e757ba ("drm/i915: Prevent a race during I915_GEM_MMAP ioctl with WC set") Reported-by: Guenter Roeck Cc: Adam Zabrocki Cc: Joonas Lahtinen Cc: # v4.0+ Cc: Akash Goel Cc: Chris Wilson Cc: Jani Nikula Cc: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org Reviewed-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20190305110409.28633-1-tvrtko.ursulin@linux.intel.com (cherry picked from commit a90e1948efb648f567444f87f3c19b2a0787affd) Signed-off-by: Rodrigo Vivi Signed-off-by: Sasha Levin --- drivers/gpu/drm/i915/i915_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1640,7 +1640,8 @@ __vma_matches(struct vm_area_struct *vma if (vma->vm_file != filp) return false; - return vma->vm_start == addr && (vma->vm_end - vma->vm_start) == size; + return vma->vm_start == addr && + (vma->vm_end - vma->vm_start) == PAGE_ALIGN(size); } /**